[djwong-xfs:llm-fixes-31 137/161] fs/xfs/xfs_quota.h:198:73: warning: statement with no effect

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git llm-fixes-31
head:   99720b43a50e52830dacd44219a5f40dc8cab503
commit: 02ba3b2929d48bb926d06e902754b4f5249ce78c [137/161] xfs: reattach dquots after changing inode ids
config: x86_64-buildonly-randconfig-004-20260822 (https://download.01.org/0day-ci/archive/20260822/[email protected]/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260822/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

All warnings (new ones prefixed by >>):

   In file included from fs/xfs/scrub/inode_repair.c:34:
   fs/xfs/scrub/inode_repair.c: In function 'xrep_inode_ids':
>> fs/xfs/xfs_quota.h:198:73: warning: statement with no effect [-Wunused-value]
     198 | #define xfs_qm_dqattach_locked(ip, fl)                                  (0)
         |                                                                         ^
   fs/xfs/scrub/inode_repair.c:1791:17: note: in expansion of macro 'xfs_qm_dqattach_locked'
    1791 |                 xfs_qm_dqattach_locked(sc->ip, false);
         |                 ^~~~~~~~~~~~~~~~~~~~~~


vim +198 fs/xfs/xfs_quota.h

ad4a74739708e1 Darrick J. Wong     2021-01-22  193  
92f8ff73f18672 Chandra Seetharaman 2013-07-11  194  #define xfs_qm_vop_create_dqattach(tp, ip, u, g, p)
7d095257e32121 Christoph Hellwig   2009-06-08  195  #define xfs_qm_vop_rename_dqattach(it)					(0)
7d095257e32121 Christoph Hellwig   2009-06-08  196  #define xfs_qm_vop_chown(tp, ip, old, new)				(NULL)
c14cfccabe2af2 Darrick J. Wong     2018-05-04  197  #define xfs_qm_dqattach(ip)						(0)
7d095257e32121 Christoph Hellwig   2009-06-08 @198  #define xfs_qm_dqattach_locked(ip, fl)					(0)
7d095257e32121 Christoph Hellwig   2009-06-08  199  #define xfs_qm_dqdetach(ip)
7ac6eb46c9f32d Darrick J. Wong     2021-01-25  200  #define xfs_qm_dqrele(d)			do { (d) = (d); } while(0)
7ac6eb46c9f32d Darrick J. Wong     2021-01-25  201  #define xfs_qm_statvfs(ip, s)			do { } while(0)
7d095257e32121 Christoph Hellwig   2009-06-08  202  #define xfs_qm_newmount(mp, a, b)					(0)
d5d9dd5b3026a8 Darrick J. Wong     2024-11-03  203  #define xfs_qm_resume_quotaon(mp)		((void)0)
7d095257e32121 Christoph Hellwig   2009-06-08  204  #define xfs_qm_mount_quotas(mp)
7d095257e32121 Christoph Hellwig   2009-06-08  205  #define xfs_qm_unmount(mp)
5d2bf8a55e03b0 Christoph Hellwig   2010-11-06  206  #define xfs_qm_unmount_quotas(mp)
108523b8de676a Darrick J. Wong     2021-08-06  207  #define xfs_inode_near_dquot_enforcement(ip, type)			(false)
200491875ce144 Darrick J. Wong     2024-02-22  208  

:::::: The code at line 198 was first introduced by commit
:::::: 7d095257e321214e4cf359abd131ba1f09c60cba xfs: kill xfs_qmops

:::::: TO: Christoph Hellwig <[email protected]>
:::::: CC: Christoph Hellwig <[email protected]>

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki