Re: [PATCH v2] gfs2: annotate i_gl with __rcu and convert to accessor helpers

Dan,

On Sun, Aug 23, 2026 at 9:02 PM Dan Carpenter <[email protected]> wrote:
> Hi Adrian,
>
> kernel test robot noticed the following build warnings:
>
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>
> url:    https://github.com/intel-lab-lkp/linux/commits/Adrian-Garcia-Casado/gfs2-annotate-i_gl-with-__rcu-and-convert-to-accessor-helpers/20260806-113610
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git for-next
> patch link:    https://lore.kernel.org/r/6a74d41a.f3f7def5.e164f.560e%40mx.google.com
> patch subject: [PATCH v2] gfs2: annotate i_gl with __rcu and convert to accessor helpers
> config: x86_64-randconfig-161 (https://download.01.org/0day-ci/archive/20260824/[email protected]/config)
> compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
> smatch: v0.5.0-9187-g5189e3fb
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <[email protected]>
> | Reported-by: Dan Carpenter <[email protected]>
> | Closes: https://lore.kernel.org/r/[email protected]/
>
> New smatch warnings:
> fs/gfs2/inode.c:150 gfs2_inode_lookup() warn: inconsistent indenting
>
> vim +150 fs/gfs2/inode.c
>
> 194c011fc4650d fs/gfs2/ops_inode.c Steven Whitehouse    2011-05-09  127  struct inode *gfs2_inode_lookup(struct super_block *sb, unsigned int type,
> 3ce37b2cb49176 fs/gfs2/inode.c     Andreas Gruenbacher  2016-06-14  128                                 u64 no_addr, u64 no_formal_ino,
> 3ce37b2cb49176 fs/gfs2/inode.c     Andreas Gruenbacher  2016-06-14  129                                 unsigned int blktype)
> 194c011fc4650d fs/gfs2/ops_inode.c Steven Whitehouse    2011-05-09  130  {
> 194c011fc4650d fs/gfs2/ops_inode.c Steven Whitehouse    2011-05-09  131         struct inode *inode;
> 194c011fc4650d fs/gfs2/ops_inode.c Steven Whitehouse    2011-05-09  132         struct gfs2_inode *ip;
> 3ce37b2cb49176 fs/gfs2/inode.c     Andreas Gruenbacher  2016-06-14  133         struct gfs2_holder i_gh;
> 194c011fc4650d fs/gfs2/ops_inode.c Steven Whitehouse    2011-05-09  134         int error;
> 194c011fc4650d fs/gfs2/ops_inode.c Steven Whitehouse    2011-05-09  135
> 6df9f9a253c7dc fs/gfs2/inode.c     Andreas Gruenbacher  2016-06-17  136         gfs2_holder_mark_uninitialized(&i_gh);
> 5f6e13baebf31d fs/gfs2/inode.c     Andreas Gruenbacher  2021-11-29  137         inode = iget5_locked(sb, no_addr, iget_test, iget_set, &no_addr);
> 194c011fc4650d fs/gfs2/ops_inode.c Steven Whitehouse    2011-05-09  138         if (!inode)
> ac3beb6a5de048 fs/gfs2/inode.c     Steven Whitehouse    2014-01-16  139                 return ERR_PTR(-ENOMEM);
> 194c011fc4650d fs/gfs2/ops_inode.c Steven Whitehouse    2011-05-09  140
> e97321fa095f1e fs/gfs2/inode.c     Bob Peterson         2016-04-12  141         ip = GFS2_I(inode);
> e97321fa095f1e fs/gfs2/inode.c     Bob Peterson         2016-04-12  142
> 40a4c512ad2564 fs/gfs2/inode.c     Mateusz Guzik        2025-10-09  143         if (inode_state_read_once(inode) & I_NEW) {
> 194c011fc4650d fs/gfs2/ops_inode.c Steven Whitehouse    2011-05-09  144                 struct gfs2_sbd *sdp = GFS2_SB(inode);
> 5f6e13baebf31d fs/gfs2/inode.c     Andreas Gruenbacher  2021-11-29  145                 struct gfs2_glock *io_gl;
> c412a97cf6c525 fs/gfs2/inode.c     Bob Peterson         2022-08-22  146                 int extra_flags = 0;
> 194c011fc4650d fs/gfs2/ops_inode.c Steven Whitehouse    2011-05-09  147
> 2c5f4a53476e3c fs/gfs2/inode.c     Andreas Gruenbacher  2025-11-13  148                 gfs2_setup_inode(inode);
> f7e98cd66761db fs/gfs2/inode.c     Adrian Garcia Casado 2026-08-06  149                 { struct gfs2_glock *gl;
> f7e98cd66761db fs/gfs2/inode.c     Adrian Garcia Casado 2026-08-06 @150                 error = gfs2_glock_get(sdp, no_addr, &gfs2_inode_glops, CREATE, &gl);
> f7e98cd66761db fs/gfs2/inode.c     Adrian Garcia Casado 2026-08-06  151                 if (!error)
> f7e98cd66761db fs/gfs2/inode.c     Adrian Garcia Casado 2026-08-06  152                         rcu_assign_pointer(ip->i_gl, gl); }
>
> What's going with the indenting?  This looks like debug code
> accidentlly escaped?

this patch can be ignored; it has been superseded by the following patch set:

https://lore.kernel.org/gfs2/[email protected]

Thanks,
Andreas

> 29464ee36bcaae fs/gfs2/inode.c     Andreas Gruenbacher  2022-01-24  153                 if (unlikely(error))
> 29464ee36bcaae fs/gfs2/inode.c     Andreas Gruenbacher  2022-01-24  154                         goto fail;
> 29464ee36bcaae fs/gfs2/inode.c     Andreas Gruenbacher  2022-01-24  155
> 29464ee36bcaae fs/gfs2/inode.c     Andreas Gruenbacher  2022-01-24  156                 error = gfs2_glock_get(sdp, no_addr, &gfs2_iopen_glops, CREATE,
> 29464ee36bcaae fs/gfs2/inode.c     Andreas Gruenbacher  2022-01-24  157                                        &io_gl);
>
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki
>