Re: [PATCH] rtc: pcf85063: disable the clkout output by default

Hi Sverdlin,

kernel test robot noticed the following build errors:

[auto build test ERROR on abelloni/rtc-next]
[also build test ERROR on linus/master v7.2 next-20260824]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/A-Sverdlin/rtc-pcf85063-disable-the-clkout-output-by-default/20260824-100759
base:   https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git rtc-next
patch link:    https://lore.kernel.org/r/20260824080801.709764-1-alexander.sverdlin%40siemens.com
patch subject: [PATCH] rtc: pcf85063: disable the clkout output by default
config: nios2-allmodconfig (https://download.01.org/0day-ci/archive/20260826/[email protected]/config)
compiler: nios2-linux-gcc (GCC) 11.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260826/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

All errors (new ones prefixed by >>):

   drivers/rtc/rtc-pcf85063.c: In function 'pcf85063_clkout_register_clk':
>> drivers/rtc/rtc-pcf85063.c:527:9: error: 'ret' undeclared (first use in this function); did you mean 'net'?
     527 |         ret = regmap_update_bits(pcf85063->regmap, PCF85063_REG_CTRL2,
         |         ^~~
         |         net
   drivers/rtc/rtc-pcf85063.c:527:9: note: each undeclared identifier is reported only once for each function it appears in


vim +527 drivers/rtc/rtc-pcf85063.c

   497	
   498	static struct clk *pcf85063_clkout_register_clk(struct pcf85063 *pcf85063)
   499	{
   500		struct clk *clk;
   501		struct clk_init_data init = {};
   502		struct device_node *node = pcf85063->rtc->dev.parent->of_node;
   503		struct device_node *fixed_clock;
   504	
   505		fixed_clock = of_get_child_by_name(node, "clock");
   506		if (fixed_clock) {
   507			/*
   508			 * skip registering square wave clock when a fixed
   509			 * clock has been registered. The fixed clock is
   510			 * registered automatically when being referenced.
   511			 */
   512			of_node_put(fixed_clock);
   513			return NULL;
   514		}
   515	
   516		init.name = "pcf85063-clkout";
   517		init.ops = &pcf85063_clkout_ops;
   518		init.flags = 0;
   519		init.parent_names = NULL;
   520		init.num_parents = 0;
   521		pcf85063->clkout_hw.init = &init;
   522	
   523		/* optional override of the clockname */
   524		of_property_read_string(node, "clock-output-names", &init.name);
   525	
   526		/* power-on default is the 32768 Hz output on; gate it until claimed */
 > 527		ret = regmap_update_bits(pcf85063->regmap, PCF85063_REG_CTRL2,
   528					 PCF85063_REG_CLKO_F_MASK, PCF85063_REG_CLKO_F_OFF);
   529		if (ret)
   530			return ret;
   531	
   532		/* register the clock */
   533		clk = devm_clk_register(&pcf85063->rtc->dev, &pcf85063->clkout_hw);
   534	
   535		if (!IS_ERR(clk))
   536			of_clk_add_provider(node, of_clk_src_simple_get, clk);
   537	
   538		return clk;
   539	}
   540	#endif
   541	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki