drivers/usb/chipidea/ci_hdrc_imx.c:532 ci_hdrc_imx_probe() warn: missing error code 'ret'
Dan Carpenter <[email protected]>
| Newsgroups | dev.linux.lists.oe-kbuild |
|---|---|
| Message-ID | <20260709104009.VDqk7w4a0vkeUuhXCztYLkM7DJ_BG8YtiOLeh2-n33E@z> |
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 51512e22efe813d8223de27f6fd02a8a48ea2323 commit: 2e9762f45efb53e7e7fc61f4ebf7a3507f5daa45 usb: chipidea: ci_hdrc_imx: use "wakeup" suffix for wakeup interrupt name config: microblaze-randconfig-r072-20260703 (https://download.01.org/0day-ci/archive/20260703/[email protected]/config) compiler: microblaze-linux-gcc (GCC) 14.3.0 smatch: v0.5.0-9185-gbcc58b9c If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Fixes: 2e9762f45efb ("usb: chipidea: ci_hdrc_imx: use "wakeup" suffix for wakeup interrupt name") | Reported-by: kernel test robot <[email protected]> | Reported-by: Dan Carpenter <[email protected]> | Closes: https://lore.kernel.org/r/[email protected]/ smatch warnings: drivers/usb/chipidea/ci_hdrc_imx.c:532 ci_hdrc_imx_probe() warn: missing error code 'ret' vim +/ret +532 drivers/usb/chipidea/ci_hdrc_imx.c ee0dc2f7d52279 drivers/usb/chipidea/ci_hdrc_imx.c Xu Yang 2025-03-18 527 data->wakeup_irq = platform_get_irq_optional(pdev, 1); ee0dc2f7d52279 drivers/usb/chipidea/ci_hdrc_imx.c Xu Yang 2025-03-18 528 if (data->wakeup_irq > 0) { 2e9762f45efb53 drivers/usb/chipidea/ci_hdrc_imx.c Xu Yang 2026-01-12 529 irq_name = devm_kasprintf(dev, GFP_KERNEL, "%s:wakeup", pdata.name); 2e9762f45efb53 drivers/usb/chipidea/ci_hdrc_imx.c Xu Yang 2026-01-12 530 if (!irq_name) { 2e9762f45efb53 drivers/usb/chipidea/ci_hdrc_imx.c Xu Yang 2026-01-12 531 dev_err_probe(dev, -ENOMEM, "failed to create irq_name\n"); 2e9762f45efb53 drivers/usb/chipidea/ci_hdrc_imx.c Xu Yang 2026-01-12 @532 goto err_clk; ret = -ENOMEM; 2e9762f45efb53 drivers/usb/chipidea/ci_hdrc_imx.c Xu Yang 2026-01-12 533 } 2e9762f45efb53 drivers/usb/chipidea/ci_hdrc_imx.c Xu Yang 2026-01-12 534 ee0dc2f7d52279 drivers/usb/chipidea/ci_hdrc_imx.c Xu Yang 2025-03-18 535 ret = devm_request_threaded_irq(dev, data->wakeup_irq, ee0dc2f7d52279 drivers/usb/chipidea/ci_hdrc_imx.c Xu Yang 2025-03-18 536 NULL, ci_wakeup_irq_handler, ee0dc2f7d52279 drivers/usb/chipidea/ci_hdrc_imx.c Xu Yang 2025-03-18 537 IRQF_ONESHOT | IRQF_NO_AUTOEN, 2e9762f45efb53 drivers/usb/chipidea/ci_hdrc_imx.c Xu Yang 2026-01-12 538 irq_name, data); ee0dc2f7d52279 drivers/usb/chipidea/ci_hdrc_imx.c Xu Yang 2025-03-18 539 if (ret) ee0dc2f7d52279 drivers/usb/chipidea/ci_hdrc_imx.c Xu Yang 2025-03-18 540 goto err_clk; ee0dc2f7d52279 drivers/usb/chipidea/ci_hdrc_imx.c Xu Yang 2025-03-18 541 } ee0dc2f7d52279 drivers/usb/chipidea/ci_hdrc_imx.c Xu Yang 2025-03-18 542 05986ba9b025ae drivers/usb/chipidea/ci_hdrc_imx.c Sascha Hauer 2013-08-14 543 ret = imx_usbmisc_init(data->usbmisc_data); d142d6be231713 drivers/usb/chipidea/ci13xxx_imx.c Richard Zhao 2012-09-12 544 if (ret) { 7c8e8909417eb6 drivers/usb/chipidea/ci_hdrc_imx.c Peter Chen 2018-10-16 545 dev_err(dev, "usbmisc init failed, ret=%d\n", ret); 8c531e0a8c2d82 drivers/usb/chipidea/ci_hdrc_imx.c Fedor Pchelkin 2025-03-16 546 goto phy_shutdown; d142d6be231713 drivers/usb/chipidea/ci13xxx_imx.c Richard Zhao 2012-09-12 547 } d142d6be231713 drivers/usb/chipidea/ci13xxx_imx.c Richard Zhao 2012-09-12 548 7c8e8909417eb6 drivers/usb/chipidea/ci_hdrc_imx.c Peter Chen 2018-10-16 549 data->ci_pdev = ci_hdrc_add_device(dev, 1530280084c390 drivers/usb/chipidea/ci13xxx_imx.c Richard Zhao 2012-07-07 550 pdev->resource, pdev->num_resources, f6a3b3a37c4772 drivers/usb/chipidea/ci13xxx_imx.c Michael Grzeschik 2013-06-13 551 &pdata); 770719df7b2cee drivers/usb/chipidea/ci13xxx_imx.c Fabio Estevam 2013-06-13 552 if (IS_ERR(data->ci_pdev)) { 770719df7b2cee drivers/usb/chipidea/ci13xxx_imx.c Fabio Estevam 2013-06-13 553 ret = PTR_ERR(data->ci_pdev); 18171cfc3c236a drivers/usb/chipidea/ci_hdrc_imx.c Alexander Stein 2022-06-14 554 dev_err_probe(dev, ret, "ci_hdrc_add_device failed\n"); 8c531e0a8c2d82 drivers/usb/chipidea/ci_hdrc_imx.c Fedor Pchelkin 2025-03-16 555 goto phy_shutdown; 1530280084c390 drivers/usb/chipidea/ci13xxx_imx.c Richard Zhao 2012-07-07 556 } 1530280084c390 drivers/usb/chipidea/ci13xxx_imx.c Richard Zhao 2012-07-07 557 df17aa9fb31f6a drivers/usb/chipidea/ci_hdrc_imx.c Li Jun 2019-10-09 558 if (data->usbmisc_data) { 93c2c7330a3b6d drivers/usb/chipidea/ci_hdrc_imx.c Li Jun 2019-09-09 559 if (!IS_ERR(pdata.id_extcon.edev) || 93c2c7330a3b6d drivers/usb/chipidea/ci_hdrc_imx.c Li Jun 2019-09-09 560 of_property_read_bool(np, "usb-role-switch")) 93c2c7330a3b6d drivers/usb/chipidea/ci_hdrc_imx.c Li Jun 2019-09-09 561 data->usbmisc_data->ext_id = 1; 93c2c7330a3b6d drivers/usb/chipidea/ci_hdrc_imx.c Li Jun 2019-09-09 562 93c2c7330a3b6d drivers/usb/chipidea/ci_hdrc_imx.c Li Jun 2019-09-09 563 if (!IS_ERR(pdata.vbus_extcon.edev) || 93c2c7330a3b6d drivers/usb/chipidea/ci_hdrc_imx.c Li Jun 2019-09-09 564 of_property_read_bool(np, "usb-role-switch")) 93c2c7330a3b6d drivers/usb/chipidea/ci_hdrc_imx.c Li Jun 2019-09-09 565 data->usbmisc_data->ext_vbus = 1; d6f93d21001e43 drivers/usb/chipidea/ci_hdrc_imx.c Peter Chen 2020-07-28 566 d6f93d21001e43 drivers/usb/chipidea/ci_hdrc_imx.c Peter Chen 2020-07-28 567 /* usbmisc needs to know dr mode to choose wakeup setting */ d6f93d21001e43 drivers/usb/chipidea/ci_hdrc_imx.c Peter Chen 2020-07-28 568 data->usbmisc_data->available_role = d6f93d21001e43 drivers/usb/chipidea/ci_hdrc_imx.c Peter Chen 2020-07-28 569 ci_hdrc_query_available_role(data->ci_pdev); df17aa9fb31f6a drivers/usb/chipidea/ci_hdrc_imx.c Li Jun 2019-10-09 570 } 93c2c7330a3b6d drivers/usb/chipidea/ci_hdrc_imx.c Li Jun 2019-09-09 571 05986ba9b025ae drivers/usb/chipidea/ci_hdrc_imx.c Sascha Hauer 2013-08-14 572 ret = imx_usbmisc_init_post(data->usbmisc_data); a068533079a0a1 drivers/usb/chipidea/ci13xxx_imx.c Michael Grzeschik 2013-03-30 573 if (ret) { 7c8e8909417eb6 drivers/usb/chipidea/ci_hdrc_imx.c Peter Chen 2018-10-16 574 dev_err(dev, "usbmisc post failed, ret=%d\n", ret); 770719df7b2cee drivers/usb/chipidea/ci13xxx_imx.c Fabio Estevam 2013-06-13 575 goto disable_device; a068533079a0a1 drivers/usb/chipidea/ci13xxx_imx.c Michael Grzeschik 2013-03-30 576 } a068533079a0a1 drivers/usb/chipidea/ci13xxx_imx.c Michael Grzeschik 2013-03-30 577 e14db48dfcf3ab drivers/usb/chipidea/ci_hdrc_imx.c Peter Chen 2015-02-11 578 if (data->supports_runtime_pm) { 7c8e8909417eb6 drivers/usb/chipidea/ci_hdrc_imx.c Peter Chen 2018-10-16 579 pm_runtime_set_active(dev); 7c8e8909417eb6 drivers/usb/chipidea/ci_hdrc_imx.c Peter Chen 2018-10-16 580 pm_runtime_enable(dev); e14db48dfcf3ab drivers/usb/chipidea/ci_hdrc_imx.c Peter Chen 2015-02-11 581 } 1530280084c390 drivers/usb/chipidea/ci13xxx_imx.c Richard Zhao 2012-07-07 582 7c8e8909417eb6 drivers/usb/chipidea/ci_hdrc_imx.c Peter Chen 2018-10-16 583 device_set_wakeup_capable(dev, true); 6d6531104d2069 drivers/usb/chipidea/ci_hdrc_imx.c Peter Chen 2015-02-11 584 1530280084c390 drivers/usb/chipidea/ci13xxx_imx.c Richard Zhao 2012-07-07 585 return 0; 1530280084c390 drivers/usb/chipidea/ci13xxx_imx.c Richard Zhao 2012-07-07 586 770719df7b2cee drivers/usb/chipidea/ci13xxx_imx.c Fabio Estevam 2013-06-13 587 disable_device: 8e22978c57087a drivers/usb/chipidea/ci_hdrc_imx.c Alexander Shishkin 2013-06-24 588 ci_hdrc_remove_device(data->ci_pdev); 8c531e0a8c2d82 drivers/usb/chipidea/ci_hdrc_imx.c Fedor Pchelkin 2025-03-16 589 phy_shutdown: 8c531e0a8c2d82 drivers/usb/chipidea/ci_hdrc_imx.c Fedor Pchelkin 2025-03-16 590 if (data->override_phy_control) 8c531e0a8c2d82 drivers/usb/chipidea/ci_hdrc_imx.c Fedor Pchelkin 2025-03-16 591 usb_phy_shutdown(data->phy); ea1418b5f1a394 drivers/usb/chipidea/ci13xxx_imx.c Sascha Hauer 2013-06-13 592 err_clk: 5dbe9ac28355fd drivers/usb/chipidea/ci_hdrc_imx.c Xu Yang 2023-12-28 593 clk_disable_unprepare(data->clk_wakeup); 5dbe9ac28355fd drivers/usb/chipidea/ci_hdrc_imx.c Xu Yang 2023-12-28 594 err_wakeup_clk: 7c8e8909417eb6 drivers/usb/chipidea/ci_hdrc_imx.c Peter Chen 2018-10-16 595 imx_disable_unprepare_clks(dev); 8cab0e9a3f3e8d drivers/usb/chipidea/ci_hdrc_imx.c Fedor Pchelkin 2025-03-16 596 qos_remove_request: d1609c312d42f3 drivers/usb/chipidea/ci_hdrc_imx.c Peter Chen 2019-04-28 597 if (pdata.flags & CI_HDRC_PMQOS) 77b352456941e8 drivers/usb/chipidea/ci_hdrc_imx.c Rafael J. Wysocki 2020-02-12 598 cpu_latency_qos_remove_request(&data->pm_qos_req); 141822aa3f79ef drivers/usb/chipidea/ci_hdrc_imx.c André Draszik 2019-08-10 599 data->ci_pdev = NULL; 74adad500346fb drivers/usb/chipidea/ci_hdrc_imx.c Joe Hattori 2024-12-16 600 err_put: 4e28f79e3dffa5 drivers/usb/chipidea/ci_hdrc_imx.c Fedor Pchelkin 2025-03-16 601 if (data->usbmisc_data) 74adad500346fb drivers/usb/chipidea/ci_hdrc_imx.c Joe Hattori 2024-12-16 602 put_device(data->usbmisc_data->dev); 1530280084c390 drivers/usb/chipidea/ci13xxx_imx.c Richard Zhao 2012-07-07 603 return ret; 1530280084c390 drivers/usb/chipidea/ci13xxx_imx.c Richard Zhao 2012-07-07 604 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki