drivers/gpu/drm/amd/pm/swsmu/smu15/smu_v15_0.c:1529:51-61: opportunity for str_enable_disable(enablement)
kernel test robot <[email protected]>
| Newsgroups | dev.linux.lists.oe-kbuild |
|---|---|
| Message-ID | <[email protected]> |
BCC: [email protected] CC: [email protected] CC: [email protected] TO: Pratik Vishwakarma <[email protected]> CC: Alex Deucher <[email protected]> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: dd3210c47e8d3ac6b4e9141fc68acc03b38c0ba3 commit: c7fc0f372374cf463be2ba4b5b21c20c3c051bb6 drm/amd: Enable SMU 15_0_0 support date: 6 months ago :::::: branch date: 26 hours ago :::::: commit date: 6 months ago config: x86_64-randconfig-103-20260711 (https://download.01.org/0day-ci/archive/20260712/[email protected]/config) compiler: gcc-14 (Debian 14.2.0-19) 14.2.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Fixes: c7fc0f372374 ("drm/amd: Enable SMU 15_0_0 support") | Reported-by: kernel test robot <[email protected]> | Reported-by: Julia Lawall <[email protected]> | Closes: https://lore.kernel.org/r/[email protected]/ cocci warnings: (new ones prefixed by >>) >> drivers/gpu/drm/amd/pm/swsmu/smu15/smu_v15_0.c:1529:51-61: opportunity for str_enable_disable(enablement) drivers/gpu/drm/amd/pm/swsmu/smu15/smu_v15_0.c:1537:49-59: opportunity for str_enable_disable(enablement) drivers/gpu/drm/amd/pm/swsmu/smu15/smu_v15_0.c:1545:49-59: opportunity for str_enable_disable(enablement) drivers/gpu/drm/amd/pm/swsmu/smu15/smu_v15_0.c:1553:51-61: opportunity for str_enable_disable(enablement) drivers/gpu/drm/amd/pm/swsmu/smu15/smu_v15_0.c:1561:49-59: opportunity for str_enable_disable(enablement) drivers/gpu/drm/amd/pm/swsmu/smu15/smu_v15_0.c:1569:48-58: opportunity for str_enable_disable(enablement) drivers/gpu/drm/amd/pm/swsmu/smu15/smu_v15_0.c:1577:56-66: opportunity for str_enable_disable(enablement) drivers/gpu/drm/amd/pm/swsmu/smu15/smu_v15_0.c:1585:51-61: opportunity for str_enable_disable(enablement) vim +1529 drivers/gpu/drm/amd/pm/swsmu/smu15/smu_v15_0.c c7fc0f372374cf Pratik Vishwakarma 2025-12-05 1519 c7fc0f372374cf Pratik Vishwakarma 2025-12-05 1520 int smu_v15_0_deep_sleep_control(struct smu_context *smu, c7fc0f372374cf Pratik Vishwakarma 2025-12-05 1521 bool enablement) c7fc0f372374cf Pratik Vishwakarma 2025-12-05 1522 { c7fc0f372374cf Pratik Vishwakarma 2025-12-05 1523 struct amdgpu_device *adev = smu->adev; c7fc0f372374cf Pratik Vishwakarma 2025-12-05 1524 int ret = 0; c7fc0f372374cf Pratik Vishwakarma 2025-12-05 1525 c7fc0f372374cf Pratik Vishwakarma 2025-12-05 1526 if (smu_cmn_feature_is_supported(smu, SMU_FEATURE_DS_GFXCLK_BIT)) { c7fc0f372374cf Pratik Vishwakarma 2025-12-05 1527 ret = smu_cmn_feature_set_enabled(smu, SMU_FEATURE_DS_GFXCLK_BIT, enablement); c7fc0f372374cf Pratik Vishwakarma 2025-12-05 1528 if (ret) { c7fc0f372374cf Pratik Vishwakarma 2025-12-05 @1529 dev_err(adev->dev, "Failed to %s GFXCLK DS!\n", enablement ? "enable" : "disable"); c7fc0f372374cf Pratik Vishwakarma 2025-12-05 1530 return ret; c7fc0f372374cf Pratik Vishwakarma 2025-12-05 1531 } c7fc0f372374cf Pratik Vishwakarma 2025-12-05 1532 } c7fc0f372374cf Pratik Vishwakarma 2025-12-05 1533 c7fc0f372374cf Pratik Vishwakarma 2025-12-05 1534 if (smu_cmn_feature_is_supported(smu, SMU_FEATURE_DS_UCLK_BIT)) { c7fc0f372374cf Pratik Vishwakarma 2025-12-05 1535 ret = smu_cmn_feature_set_enabled(smu, SMU_FEATURE_DS_UCLK_BIT, enablement); c7fc0f372374cf Pratik Vishwakarma 2025-12-05 1536 if (ret) { c7fc0f372374cf Pratik Vishwakarma 2025-12-05 1537 dev_err(adev->dev, "Failed to %s UCLK DS!\n", enablement ? "enable" : "disable"); c7fc0f372374cf Pratik Vishwakarma 2025-12-05 1538 return ret; c7fc0f372374cf Pratik Vishwakarma 2025-12-05 1539 } c7fc0f372374cf Pratik Vishwakarma 2025-12-05 1540 } c7fc0f372374cf Pratik Vishwakarma 2025-12-05 1541 c7fc0f372374cf Pratik Vishwakarma 2025-12-05 1542 if (smu_cmn_feature_is_supported(smu, SMU_FEATURE_DS_FCLK_BIT)) { c7fc0f372374cf Pratik Vishwakarma 2025-12-05 1543 ret = smu_cmn_feature_set_enabled(smu, SMU_FEATURE_DS_FCLK_BIT, enablement); c7fc0f372374cf Pratik Vishwakarma 2025-12-05 1544 if (ret) { c7fc0f372374cf Pratik Vishwakarma 2025-12-05 1545 dev_err(adev->dev, "Failed to %s FCLK DS!\n", enablement ? "enable" : "disable"); c7fc0f372374cf Pratik Vishwakarma 2025-12-05 1546 return ret; c7fc0f372374cf Pratik Vishwakarma 2025-12-05 1547 } c7fc0f372374cf Pratik Vishwakarma 2025-12-05 1548 } c7fc0f372374cf Pratik Vishwakarma 2025-12-05 1549 c7fc0f372374cf Pratik Vishwakarma 2025-12-05 1550 if (smu_cmn_feature_is_supported(smu, SMU_FEATURE_DS_SOCCLK_BIT)) { c7fc0f372374cf Pratik Vishwakarma 2025-12-05 1551 ret = smu_cmn_feature_set_enabled(smu, SMU_FEATURE_DS_SOCCLK_BIT, enablement); c7fc0f372374cf Pratik Vishwakarma 2025-12-05 1552 if (ret) { c7fc0f372374cf Pratik Vishwakarma 2025-12-05 1553 dev_err(adev->dev, "Failed to %s SOCCLK DS!\n", enablement ? "enable" : "disable"); c7fc0f372374cf Pratik Vishwakarma 2025-12-05 1554 return ret; c7fc0f372374cf Pratik Vishwakarma 2025-12-05 1555 } c7fc0f372374cf Pratik Vishwakarma 2025-12-05 1556 } c7fc0f372374cf Pratik Vishwakarma 2025-12-05 1557 c7fc0f372374cf Pratik Vishwakarma 2025-12-05 1558 if (smu_cmn_feature_is_supported(smu, SMU_FEATURE_DS_LCLK_BIT)) { c7fc0f372374cf Pratik Vishwakarma 2025-12-05 1559 ret = smu_cmn_feature_set_enabled(smu, SMU_FEATURE_DS_LCLK_BIT, enablement); c7fc0f372374cf Pratik Vishwakarma 2025-12-05 1560 if (ret) { c7fc0f372374cf Pratik Vishwakarma 2025-12-05 1561 dev_err(adev->dev, "Failed to %s LCLK DS!\n", enablement ? "enable" : "disable"); c7fc0f372374cf Pratik Vishwakarma 2025-12-05 1562 return ret; c7fc0f372374cf Pratik Vishwakarma 2025-12-05 1563 } c7fc0f372374cf Pratik Vishwakarma 2025-12-05 1564 } c7fc0f372374cf Pratik Vishwakarma 2025-12-05 1565 c7fc0f372374cf Pratik Vishwakarma 2025-12-05 1566 if (smu_cmn_feature_is_supported(smu, SMU_FEATURE_DS_VCN_BIT)) { c7fc0f372374cf Pratik Vishwakarma 2025-12-05 1567 ret = smu_cmn_feature_set_enabled(smu, SMU_FEATURE_DS_VCN_BIT, enablement); c7fc0f372374cf Pratik Vishwakarma 2025-12-05 1568 if (ret) { c7fc0f372374cf Pratik Vishwakarma 2025-12-05 1569 dev_err(adev->dev, "Failed to %s VCN DS!\n", enablement ? "enable" : "disable"); c7fc0f372374cf Pratik Vishwakarma 2025-12-05 1570 return ret; c7fc0f372374cf Pratik Vishwakarma 2025-12-05 1571 } c7fc0f372374cf Pratik Vishwakarma 2025-12-05 1572 } c7fc0f372374cf Pratik Vishwakarma 2025-12-05 1573 c7fc0f372374cf Pratik Vishwakarma 2025-12-05 1574 if (smu_cmn_feature_is_supported(smu, SMU_FEATURE_DS_MP0CLK_BIT)) { c7fc0f372374cf Pratik Vishwakarma 2025-12-05 1575 ret = smu_cmn_feature_set_enabled(smu, SMU_FEATURE_DS_MP0CLK_BIT, enablement); c7fc0f372374cf Pratik Vishwakarma 2025-12-05 1576 if (ret) { c7fc0f372374cf Pratik Vishwakarma 2025-12-05 1577 dev_err(adev->dev, "Failed to %s MP0/MPIOCLK DS!\n", enablement ? "enable" : "disable"); c7fc0f372374cf Pratik Vishwakarma 2025-12-05 1578 return ret; c7fc0f372374cf Pratik Vishwakarma 2025-12-05 1579 } c7fc0f372374cf Pratik Vishwakarma 2025-12-05 1580 } c7fc0f372374cf Pratik Vishwakarma 2025-12-05 1581 c7fc0f372374cf Pratik Vishwakarma 2025-12-05 1582 if (smu_cmn_feature_is_supported(smu, SMU_FEATURE_DS_MP1CLK_BIT)) { c7fc0f372374cf Pratik Vishwakarma 2025-12-05 1583 ret = smu_cmn_feature_set_enabled(smu, SMU_FEATURE_DS_MP1CLK_BIT, enablement); c7fc0f372374cf Pratik Vishwakarma 2025-12-05 1584 if (ret) { c7fc0f372374cf Pratik Vishwakarma 2025-12-05 1585 dev_err(adev->dev, "Failed to %s MP1CLK DS!\n", enablement ? "enable" : "disable"); c7fc0f372374cf Pratik Vishwakarma 2025-12-05 1586 return ret; c7fc0f372374cf Pratik Vishwakarma 2025-12-05 1587 } c7fc0f372374cf Pratik Vishwakarma 2025-12-05 1588 } c7fc0f372374cf Pratik Vishwakarma 2025-12-05 1589 c7fc0f372374cf Pratik Vishwakarma 2025-12-05 1590 return ret; c7fc0f372374cf Pratik Vishwakarma 2025-12-05 1591 } c7fc0f372374cf Pratik Vishwakarma 2025-12-05 1592 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki