drivers/net/ethernet/airoha/airoha_ppe.c:97 airoha_ppe_set_cpu_port() warn: subtract is higher precedence than shift

BCC: [email protected]
CC: [email protected]
CC: [email protected]
TO: Lorenzo Bianconi <[email protected]>
CC: Jakub Kicinski <[email protected]>
CC: Simon Horman <[email protected]>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   dd3210c47e8d3ac6b4e9141fc68acc03b38c0ba3
commit: f44218cd5e6a3d98b137344b808ee154117ce765 net: airoha: Reset PPE cpu port configuration in airoha_ppe_hw_init()
date:   4 months ago
:::::: branch date: 29 hours ago
:::::: commit date: 4 months ago
config: microblaze-randconfig-r071-20260711 (https://download.01.org/0day-ci/archive/20260712/[email protected]/config)
compiler: microblaze-linux-gcc (GCC) 8.5.0
smatch: v0.5.0-9185-gbcc58b9c

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Fixes: f44218cd5e6a ("net: airoha: Reset PPE cpu port configuration in airoha_ppe_hw_init()")
| Reported-by: kernel test robot <[email protected]>
| Reported-by: Dan Carpenter <[email protected]>
| Closes: https://lore.kernel.org/r/[email protected]/

smatch warnings:
drivers/net/ethernet/airoha/airoha_ppe.c:97 airoha_ppe_set_cpu_port() warn: subtract is higher precedence than shift
drivers/net/ethernet/airoha/airoha_ppe.c:97 airoha_ppe_set_cpu_port() warn: subtract is higher precedence than shift
drivers/net/ethernet/airoha/airoha_ppe.c:97 airoha_ppe_set_cpu_port() warn: subtract is higher precedence than shift
drivers/net/ethernet/airoha/airoha_ppe.c:97 airoha_ppe_set_cpu_port() warn: subtract is higher precedence than shift

vim +97 drivers/net/ethernet/airoha/airoha_ppe.c

00a7678310fe3d3 Lorenzo Bianconi 2025-02-28   87  
f44218cd5e6a3d9 Lorenzo Bianconi 2026-03-17   88  void airoha_ppe_set_cpu_port(struct airoha_gdm_port *port, u8 ppe_id)
f44218cd5e6a3d9 Lorenzo Bianconi 2026-03-17   89  {
f44218cd5e6a3d9 Lorenzo Bianconi 2026-03-17   90  	struct airoha_qdma *qdma = port->qdma;
f44218cd5e6a3d9 Lorenzo Bianconi 2026-03-17   91  	u8 fport = airoha_get_fe_port(port);
f44218cd5e6a3d9 Lorenzo Bianconi 2026-03-17   92  	struct airoha_eth *eth = qdma->eth;
f44218cd5e6a3d9 Lorenzo Bianconi 2026-03-17   93  	u8 qdma_id = qdma - &eth->qdma[0];
f44218cd5e6a3d9 Lorenzo Bianconi 2026-03-17   94  	u32 fe_cpu_port;
f44218cd5e6a3d9 Lorenzo Bianconi 2026-03-17   95  
f44218cd5e6a3d9 Lorenzo Bianconi 2026-03-17   96  	fe_cpu_port = qdma_id ? FE_PSE_PORT_CDM2 : FE_PSE_PORT_CDM1;
f44218cd5e6a3d9 Lorenzo Bianconi 2026-03-17  @97  	airoha_fe_rmw(eth, REG_PPE_DFT_CPORT(ppe_id, fport),
f44218cd5e6a3d9 Lorenzo Bianconi 2026-03-17   98  		      DFT_CPORT_MASK(fport),
f44218cd5e6a3d9 Lorenzo Bianconi 2026-03-17   99  		      __field_prep(DFT_CPORT_MASK(fport), fe_cpu_port));
f44218cd5e6a3d9 Lorenzo Bianconi 2026-03-17  100  }
f44218cd5e6a3d9 Lorenzo Bianconi 2026-03-17  101  

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki