drivers/regulator/pf1550-regulator.c:399:8-33: WARNING: Threaded IRQ with no primary handler requested without IRQF_ONESHOT (unless it is nested IRQ)
kernel test robot <[email protected]>
| Newsgroups | dev.linux.lists.oe-kbuild |
|---|---|
| Message-ID | <[email protected]> |
BCC: [email protected] CC: [email protected] CC: [email protected] TO: Samuel Kayode <[email protected]> CC: Lee Jones <[email protected]> CC: Frank Li <[email protected]> CC: Mark Brown <[email protected]> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: fce2dfa773ced15f27dd27cd0b482a7473cdcf2a commit: 7320d41c29bbd80144bb89112b8bf0c8223b94a1 regulator: pf1550: Add support for regulator date: 9 months ago :::::: branch date: 11 hours ago :::::: commit date: 9 months ago config: powerpc64-randconfig-r064-20260716 (https://download.01.org/0day-ci/archive/20260717/[email protected]/config) compiler: clang version 23.0.0git (https://github.com/llvm/llvm-project b3e6e6dabdc02153552a64fc74ff5c7532447eed) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Fixes: 7320d41c29bb ("regulator: pf1550: Add support for regulator") | Reported-by: kernel test robot <[email protected]> | Reported-by: Julia Lawall <[email protected]> | Closes: https://lore.kernel.org/r/[email protected]/ cocci warnings: (new ones prefixed by >>) >> drivers/regulator/pf1550-regulator.c:399:8-33: WARNING: Threaded IRQ with no primary handler requested without IRQF_ONESHOT (unless it is nested IRQ) vim +399 drivers/regulator/pf1550-regulator.c 7320d41c29bbd8 Samuel Kayode 2025-10-01 345 7320d41c29bbd8 Samuel Kayode 2025-10-01 346 static int pf1550_regulator_probe(struct platform_device *pdev) 7320d41c29bbd8 Samuel Kayode 2025-10-01 347 { 7320d41c29bbd8 Samuel Kayode 2025-10-01 348 const struct pf1550_ddata *pf1550 = dev_get_drvdata(pdev->dev.parent); 7320d41c29bbd8 Samuel Kayode 2025-10-01 349 struct regulator_config config = { }; 7320d41c29bbd8 Samuel Kayode 2025-10-01 350 struct pf1550_regulator_info *info; 7320d41c29bbd8 Samuel Kayode 2025-10-01 351 int i, irq = -1, ret = 0; 7320d41c29bbd8 Samuel Kayode 2025-10-01 352 7320d41c29bbd8 Samuel Kayode 2025-10-01 353 info = devm_kzalloc(&pdev->dev, sizeof(*info), GFP_KERNEL); 7320d41c29bbd8 Samuel Kayode 2025-10-01 354 if (!info) 7320d41c29bbd8 Samuel Kayode 2025-10-01 355 return -ENOMEM; 7320d41c29bbd8 Samuel Kayode 2025-10-01 356 7320d41c29bbd8 Samuel Kayode 2025-10-01 357 config.regmap = dev_get_regmap(pf1550->dev, NULL); 7320d41c29bbd8 Samuel Kayode 2025-10-01 358 if (!config.regmap) 7320d41c29bbd8 Samuel Kayode 2025-10-01 359 return dev_err_probe(&pdev->dev, -ENODEV, 7320d41c29bbd8 Samuel Kayode 2025-10-01 360 "failed to get parent regmap\n"); 7320d41c29bbd8 Samuel Kayode 2025-10-01 361 7320d41c29bbd8 Samuel Kayode 2025-10-01 362 config.dev = pf1550->dev; 7320d41c29bbd8 Samuel Kayode 2025-10-01 363 config.regmap = pf1550->regmap; 7320d41c29bbd8 Samuel Kayode 2025-10-01 364 info->dev = &pdev->dev; 7320d41c29bbd8 Samuel Kayode 2025-10-01 365 info->pf1550 = pf1550; 7320d41c29bbd8 Samuel Kayode 2025-10-01 366 7320d41c29bbd8 Samuel Kayode 2025-10-01 367 memcpy(info->regulator_descs, pf1550_regulators, 7320d41c29bbd8 Samuel Kayode 2025-10-01 368 sizeof(info->regulator_descs)); 7320d41c29bbd8 Samuel Kayode 2025-10-01 369 7320d41c29bbd8 Samuel Kayode 2025-10-01 370 for (i = 0; i < ARRAY_SIZE(pf1550_regulators); i++) { 7320d41c29bbd8 Samuel Kayode 2025-10-01 371 struct regulator_desc *desc; 7320d41c29bbd8 Samuel Kayode 2025-10-01 372 7320d41c29bbd8 Samuel Kayode 2025-10-01 373 desc = &info->regulator_descs[i].desc; 7320d41c29bbd8 Samuel Kayode 2025-10-01 374 7320d41c29bbd8 Samuel Kayode 2025-10-01 375 if ((desc->id == PF1550_SW2 && !pf1550->dvs2_enable) || 7320d41c29bbd8 Samuel Kayode 2025-10-01 376 (desc->id == PF1550_SW1 && !pf1550->dvs1_enable)) { 7320d41c29bbd8 Samuel Kayode 2025-10-01 377 /* OTP_SW2_DVS_ENB == 1? or OTP_SW1_DVS_ENB == 1? */ 7320d41c29bbd8 Samuel Kayode 2025-10-01 378 desc->volt_table = pf1550_sw12_volts; 7320d41c29bbd8 Samuel Kayode 2025-10-01 379 desc->n_voltages = ARRAY_SIZE(pf1550_sw12_volts); 7320d41c29bbd8 Samuel Kayode 2025-10-01 380 desc->ops = &pf1550_sw1_ops; 7320d41c29bbd8 Samuel Kayode 2025-10-01 381 } 7320d41c29bbd8 Samuel Kayode 2025-10-01 382 7320d41c29bbd8 Samuel Kayode 2025-10-01 383 info->rdevs[i] = devm_regulator_register(&pdev->dev, desc, 7320d41c29bbd8 Samuel Kayode 2025-10-01 384 &config); 7320d41c29bbd8 Samuel Kayode 2025-10-01 385 if (IS_ERR(info->rdevs[i])) 7320d41c29bbd8 Samuel Kayode 2025-10-01 386 return dev_err_probe(&pdev->dev, 7320d41c29bbd8 Samuel Kayode 2025-10-01 387 PTR_ERR(info->rdevs[i]), 7320d41c29bbd8 Samuel Kayode 2025-10-01 388 "failed to initialize regulator-%d\n", 7320d41c29bbd8 Samuel Kayode 2025-10-01 389 i); 7320d41c29bbd8 Samuel Kayode 2025-10-01 390 } 7320d41c29bbd8 Samuel Kayode 2025-10-01 391 7320d41c29bbd8 Samuel Kayode 2025-10-01 392 platform_set_drvdata(pdev, info); 7320d41c29bbd8 Samuel Kayode 2025-10-01 393 7320d41c29bbd8 Samuel Kayode 2025-10-01 394 for (i = 0; i < PF1550_REGULATOR_IRQ_NR; i++) { 7320d41c29bbd8 Samuel Kayode 2025-10-01 395 irq = platform_get_irq(pdev, i); 7320d41c29bbd8 Samuel Kayode 2025-10-01 396 if (irq < 0) 7320d41c29bbd8 Samuel Kayode 2025-10-01 397 return irq; 7320d41c29bbd8 Samuel Kayode 2025-10-01 398 7320d41c29bbd8 Samuel Kayode 2025-10-01 @399 ret = devm_request_threaded_irq(&pdev->dev, irq, NULL, 7320d41c29bbd8 Samuel Kayode 2025-10-01 400 pf1550_regulator_irq_handler, 7320d41c29bbd8 Samuel Kayode 2025-10-01 401 IRQF_NO_SUSPEND, 7320d41c29bbd8 Samuel Kayode 2025-10-01 402 "pf1550-regulator", info); 7320d41c29bbd8 Samuel Kayode 2025-10-01 403 if (ret) 7320d41c29bbd8 Samuel Kayode 2025-10-01 404 return dev_err_probe(&pdev->dev, ret, 7320d41c29bbd8 Samuel Kayode 2025-10-01 405 "failed: irq request (IRQ: %d)\n", 7320d41c29bbd8 Samuel Kayode 2025-10-01 406 i); 7320d41c29bbd8 Samuel Kayode 2025-10-01 407 } 7320d41c29bbd8 Samuel Kayode 2025-10-01 408 7320d41c29bbd8 Samuel Kayode 2025-10-01 409 return 0; 7320d41c29bbd8 Samuel Kayode 2025-10-01 410 } 7320d41c29bbd8 Samuel Kayode 2025-10-01 411 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki