drivers/iommu/generic_pt/fmt/../iommu_pt.h:908 vtdss_map_range() warn: impossible condition '(paddr > 18446744073709551615) => (0-u32max > u64max)'
kernel test robot <[email protected]>
| Newsgroups | dev.linux.lists.oe-kbuild |
|---|---|
| Message-ID | <[email protected]> |
BCC: [email protected] CC: [email protected] CC: [email protected] TO: Jason Gunthorpe <[email protected]> CC: Joerg Roedel <[email protected]> CC: Samiullah Khawaja <[email protected]> CC: Kevin Tian <[email protected]> CC: Lu Baolu <[email protected]> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 94515f3a7d4256a5062176b7d6ed0471938cd51a commit: d6c65b0fd6218bd21ed0be7a8d3218e8f6dc91de iommupt: Avoid rewalking during map date: 4 months ago :::::: branch date: 4 hours ago :::::: commit date: 4 months ago config: i386-randconfig-141-20260718 (https://download.01.org/0day-ci/archive/20260718/[email protected]/config) compiler: clang version 22.1.3 (https://github.com/llvm/llvm-project e9846648fd6183ee6d8cbdb4502213fcf902a211) smatch: v0.5.0-9185-gbcc58b9c If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Fixes: d6c65b0fd621 ("iommupt: Avoid rewalking during map") | Reported-by: kernel test robot <[email protected]> | Reported-by: Dan Carpenter <[email protected]> | Closes: https://lore.kernel.org/r/[email protected]/ smatch warnings: drivers/iommu/generic_pt/fmt/../iommu_pt.h:908 vtdss_map_range() warn: impossible condition '(paddr > 18446744073709551615) => (0-u32max > u64max)' drivers/iommu/generic_pt/fmt/../iommu_pt.h:908 riscv_64_map_range() warn: impossible condition '(paddr > 18446744073709551615) => (0-u32max > u64max)' vim +908 drivers/iommu/generic_pt/fmt/../iommu_pt.h dcd6a011a8d523a Jason Gunthorpe 2025-11-04 885 d6c65b0fd6218bd Jason Gunthorpe 2026-02-27 886 static int NS(map_range)(struct pt_iommu *iommu_table, dma_addr_t iova, d6c65b0fd6218bd Jason Gunthorpe 2026-02-27 887 phys_addr_t paddr, dma_addr_t len, unsigned int prot, d6c65b0fd6218bd Jason Gunthorpe 2026-02-27 888 gfp_t gfp, size_t *mapped) dcd6a011a8d523a Jason Gunthorpe 2025-11-04 889 { dcd6a011a8d523a Jason Gunthorpe 2025-11-04 890 pt_vaddr_t pgsize_bitmap = iommu_table->domain.pgsize_bitmap; dcd6a011a8d523a Jason Gunthorpe 2025-11-04 891 struct pt_common *common = common_from_iommu(iommu_table); dcd6a011a8d523a Jason Gunthorpe 2025-11-04 892 struct iommu_iotlb_gather iotlb_gather; dcd6a011a8d523a Jason Gunthorpe 2025-11-04 893 struct pt_iommu_map_args map = { dcd6a011a8d523a Jason Gunthorpe 2025-11-04 894 .iotlb_gather = &iotlb_gather, dcd6a011a8d523a Jason Gunthorpe 2025-11-04 895 .oa = paddr, dcd6a011a8d523a Jason Gunthorpe 2025-11-04 896 }; dcd6a011a8d523a Jason Gunthorpe 2025-11-04 897 bool single_page = false; dcd6a011a8d523a Jason Gunthorpe 2025-11-04 898 struct pt_range range; dcd6a011a8d523a Jason Gunthorpe 2025-11-04 899 int ret; dcd6a011a8d523a Jason Gunthorpe 2025-11-04 900 dcd6a011a8d523a Jason Gunthorpe 2025-11-04 901 iommu_iotlb_gather_init(&iotlb_gather); dcd6a011a8d523a Jason Gunthorpe 2025-11-04 902 dcd6a011a8d523a Jason Gunthorpe 2025-11-04 903 if (WARN_ON(!(prot & (IOMMU_READ | IOMMU_WRITE)))) dcd6a011a8d523a Jason Gunthorpe 2025-11-04 904 return -EINVAL; dcd6a011a8d523a Jason Gunthorpe 2025-11-04 905 dcd6a011a8d523a Jason Gunthorpe 2025-11-04 906 /* Check the paddr doesn't exceed what the table can store */ dcd6a011a8d523a Jason Gunthorpe 2025-11-04 907 if ((sizeof(pt_oaddr_t) < sizeof(paddr) && dcd6a011a8d523a Jason Gunthorpe 2025-11-04 @908 (pt_vaddr_t)paddr > PT_VADDR_MAX) || dcd6a011a8d523a Jason Gunthorpe 2025-11-04 909 (common->max_oasz_lg2 != PT_VADDR_MAX_LG2 && dcd6a011a8d523a Jason Gunthorpe 2025-11-04 910 oalog2_div(paddr, common->max_oasz_lg2))) dcd6a011a8d523a Jason Gunthorpe 2025-11-04 911 return -ERANGE; dcd6a011a8d523a Jason Gunthorpe 2025-11-04 912 dcd6a011a8d523a Jason Gunthorpe 2025-11-04 913 ret = pt_iommu_set_prot(common, &map.attrs, prot); dcd6a011a8d523a Jason Gunthorpe 2025-11-04 914 if (ret) dcd6a011a8d523a Jason Gunthorpe 2025-11-04 915 return ret; dcd6a011a8d523a Jason Gunthorpe 2025-11-04 916 map.attrs.gfp = gfp; dcd6a011a8d523a Jason Gunthorpe 2025-11-04 917 dcd6a011a8d523a Jason Gunthorpe 2025-11-04 918 ret = make_range_no_check(common, &range, iova, len); dcd6a011a8d523a Jason Gunthorpe 2025-11-04 919 if (ret) dcd6a011a8d523a Jason Gunthorpe 2025-11-04 920 return ret; dcd6a011a8d523a Jason Gunthorpe 2025-11-04 921 dcd6a011a8d523a Jason Gunthorpe 2025-11-04 922 /* Calculate target page size and level for the leaves */ d6c65b0fd6218bd Jason Gunthorpe 2026-02-27 923 if (pt_has_system_page_size(common) && len == PAGE_SIZE) { dcd6a011a8d523a Jason Gunthorpe 2025-11-04 924 PT_WARN_ON(!(pgsize_bitmap & PAGE_SIZE)); dcd6a011a8d523a Jason Gunthorpe 2025-11-04 925 if (log2_mod(iova | paddr, PAGE_SHIFT)) dcd6a011a8d523a Jason Gunthorpe 2025-11-04 926 return -ENXIO; dcd6a011a8d523a Jason Gunthorpe 2025-11-04 927 map.leaf_pgsize_lg2 = PAGE_SHIFT; dcd6a011a8d523a Jason Gunthorpe 2025-11-04 928 map.leaf_level = 0; d6c65b0fd6218bd Jason Gunthorpe 2026-02-27 929 map.num_leaves = 1; dcd6a011a8d523a Jason Gunthorpe 2025-11-04 930 single_page = true; dcd6a011a8d523a Jason Gunthorpe 2025-11-04 931 } else { dcd6a011a8d523a Jason Gunthorpe 2025-11-04 932 map.leaf_pgsize_lg2 = pt_compute_best_pgsize( dcd6a011a8d523a Jason Gunthorpe 2025-11-04 933 pgsize_bitmap, range.va, range.last_va, paddr); dcd6a011a8d523a Jason Gunthorpe 2025-11-04 934 if (!map.leaf_pgsize_lg2) dcd6a011a8d523a Jason Gunthorpe 2025-11-04 935 return -ENXIO; dcd6a011a8d523a Jason Gunthorpe 2025-11-04 936 map.leaf_level = dcd6a011a8d523a Jason Gunthorpe 2025-11-04 937 pt_pgsz_lg2_to_level(common, map.leaf_pgsize_lg2); d6c65b0fd6218bd Jason Gunthorpe 2026-02-27 938 map.num_leaves = pt_pgsz_count(pgsize_bitmap, range.va, d6c65b0fd6218bd Jason Gunthorpe 2026-02-27 939 range.last_va, paddr, d6c65b0fd6218bd Jason Gunthorpe 2026-02-27 940 map.leaf_pgsize_lg2); dcd6a011a8d523a Jason Gunthorpe 2025-11-04 941 } dcd6a011a8d523a Jason Gunthorpe 2025-11-04 942 dcd6a011a8d523a Jason Gunthorpe 2025-11-04 943 ret = check_map_range(iommu_table, &range, &map); dcd6a011a8d523a Jason Gunthorpe 2025-11-04 944 if (ret) dcd6a011a8d523a Jason Gunthorpe 2025-11-04 945 return ret; dcd6a011a8d523a Jason Gunthorpe 2025-11-04 946 dcd6a011a8d523a Jason Gunthorpe 2025-11-04 947 PT_WARN_ON(map.leaf_level > range.top_level); dcd6a011a8d523a Jason Gunthorpe 2025-11-04 948 efa03dab7ce4ed7 Jason Gunthorpe 2025-10-23 949 ret = do_map(&range, common, single_page, &map); dcd6a011a8d523a Jason Gunthorpe 2025-11-04 950 dcd6a011a8d523a Jason Gunthorpe 2025-11-04 951 /* dcd6a011a8d523a Jason Gunthorpe 2025-11-04 952 * Table levels were freed and replaced with large items, flush any walk dcd6a011a8d523a Jason Gunthorpe 2025-11-04 953 * cache that may refer to the freed levels. dcd6a011a8d523a Jason Gunthorpe 2025-11-04 954 */ dcd6a011a8d523a Jason Gunthorpe 2025-11-04 955 if (!iommu_pages_list_empty(&iotlb_gather.freelist)) dcd6a011a8d523a Jason Gunthorpe 2025-11-04 956 iommu_iotlb_sync(&iommu_table->domain, &iotlb_gather); dcd6a011a8d523a Jason Gunthorpe 2025-11-04 957 dcd6a011a8d523a Jason Gunthorpe 2025-11-04 958 /* Bytes successfully mapped */ dcd6a011a8d523a Jason Gunthorpe 2025-11-04 959 PT_WARN_ON(!ret && map.oa - paddr != len); dcd6a011a8d523a Jason Gunthorpe 2025-11-04 960 *mapped += map.oa - paddr; dcd6a011a8d523a Jason Gunthorpe 2025-11-04 961 return ret; dcd6a011a8d523a Jason Gunthorpe 2025-11-04 962 } dcd6a011a8d523a Jason Gunthorpe 2025-11-04 963 :::::: The code at line 908 was first introduced by commit :::::: dcd6a011a8d523a114af2360a8753de5bd60c139 iommupt: Add map_pages op :::::: TO: Jason Gunthorpe <[email protected]> :::::: CC: Joerg Roedel <[email protected]> -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki