[android-common:android16-6.12 1/1] drivers/android/wrapfd.c:542:32-49: opportunity for str_yes_no(ctx -> allow_guests)

BCC: [email protected]
CC: [email protected]
TO: [email protected]

tree:   https://android.googlesource.com/kernel/common android16-6.12
head:   0fd55a309793adc6b8cddb5c29e80caa545ba4bb
commit: 780777f21fb7cac4a28f1dffe5581a50c3c6cb32 [1/1] ANDROID: drivers/wrapfd: add wrapfd driver base code
:::::: branch date: 12 hours ago
:::::: commit date: 5 months ago
config: x86_64-randconfig-r062-20260718 (https://download.01.org/0day-ci/archive/20260718/[email protected]/config)
compiler: clang version 22.1.3 (https://github.com/llvm/llvm-project e9846648fd6183ee6d8cbdb4502213fcf902a211)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Reported-by: Julia Lawall <[email protected]>
| Closes: https://lore.kernel.org/r/[email protected]/

cocci warnings: (new ones prefixed by >>)
>> drivers/android/wrapfd.c:542:32-49: opportunity for str_yes_no(ctx -> allow_guests)

vim +542 drivers/android/wrapfd.c

780777f21fb7ca Suren Baghdasaryan 2025-11-21  527  
780777f21fb7ca Suren Baghdasaryan 2025-11-21  528  #ifdef CONFIG_PROC_FS
780777f21fb7ca Suren Baghdasaryan 2025-11-21  529  static void wrap_show_fdinfo(struct seq_file *m, struct file *file)
780777f21fb7ca Suren Baghdasaryan 2025-11-21  530  {
780777f21fb7ca Suren Baghdasaryan 2025-11-21  531  	struct wrap_ctx *ctx = file->private_data;
780777f21fb7ca Suren Baghdasaryan 2025-11-21  532  
780777f21fb7ca Suren Baghdasaryan 2025-11-21  533  	spin_lock(&ctx->lock);
780777f21fb7ca Suren Baghdasaryan 2025-11-21  534  	if (ctx->owner.task) {
780777f21fb7ca Suren Baghdasaryan 2025-11-21  535  		seq_printf(m, "owner:\t%d\n", ctx->owner.task->pid);
780777f21fb7ca Suren Baghdasaryan 2025-11-21  536  	} else {
780777f21fb7ca Suren Baghdasaryan 2025-11-21  537  		if (ctx->owner.dev)
780777f21fb7ca Suren Baghdasaryan 2025-11-21  538  			seq_printf(m, "owner:\t<device>\n");
780777f21fb7ca Suren Baghdasaryan 2025-11-21  539  		else
780777f21fb7ca Suren Baghdasaryan 2025-11-21  540  			seq_printf(m, "owner:\t<none>\n");
780777f21fb7ca Suren Baghdasaryan 2025-11-21  541  	}
780777f21fb7ca Suren Baghdasaryan 2025-11-21 @542  	seq_printf(m, "guests:\t%s\n", ctx->allow_guests ? "yes" : "no");
780777f21fb7ca Suren Baghdasaryan 2025-11-21  543  	seq_printf(m, "maps:\t%d\n", ctx->map_count);
780777f21fb7ca Suren Baghdasaryan 2025-11-21  544  	seq_printf(m, "empty:\t%s\n", ctx->content ? "no" : "yes");
780777f21fb7ca Suren Baghdasaryan 2025-11-21  545  	if (ctx->content) {
780777f21fb7ca Suren Baghdasaryan 2025-11-21  546  		struct wrap_content *content = ctx->content;
780777f21fb7ca Suren Baghdasaryan 2025-11-21  547  
780777f21fb7ca Suren Baghdasaryan 2025-11-21  548  		seq_printf(m, "rdonly:\t%s\n",
780777f21fb7ca Suren Baghdasaryan 2025-11-21  549  			   content->ops->is_writable(content) ? "no" : "yes");
780777f21fb7ca Suren Baghdasaryan 2025-11-21  550  		content->ops->show_fdinfo(content, m);
780777f21fb7ca Suren Baghdasaryan 2025-11-21  551  	}
780777f21fb7ca Suren Baghdasaryan 2025-11-21  552  	spin_unlock(&ctx->lock);
780777f21fb7ca Suren Baghdasaryan 2025-11-21  553  }
780777f21fb7ca Suren Baghdasaryan 2025-11-21  554  #endif
780777f21fb7ca Suren Baghdasaryan 2025-11-21  555  

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki