[bcachefs:master 775/1155] fs/bcachefs/btree/commit.c:201 bch2_btree_bset_insert_key() error: we previously assumed 'k' could be null (see line 185)
kernel test robot <[email protected]>
| Newsgroups | dev.linux.lists.oe-kbuild |
|---|---|
| Message-ID | <[email protected]> |
BCC: [email protected] CC: [email protected] CC: Kent Overstreet <[email protected]> TO: Kent Overstreet <[email protected]> tree: https://evilpiepirate.org/git/bcachefs.git master head: ca944a61e079450f82be88c91e349638c75cf4b6 commit: 29a3ec38abe9847fa4a636aa9f6c5da6cab3b8d8 [775/1155] bcachefs: bch2_btree_bset_insert_key(): kill gotos :::::: branch date: 9 weeks ago :::::: commit date: 8 months ago config: x86_64-randconfig-161 (https://download.01.org/0day-ci/archive/20260718/[email protected]/config) compiler: gcc-14 (Debian 14.2.0-19) 14.2.0 smatch: v0.5.0-9185-gbcc58b9c If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <[email protected]> | Reported-by: Dan Carpenter <[email protected]> | Closes: https://lore.kernel.org/r/[email protected]/ smatch warnings: fs/bcachefs/btree/commit.c:201 bch2_btree_bset_insert_key() error: we previously assumed 'k' could be null (see line 185) vim +/k +201 fs/bcachefs/btree/commit.c 1c6fdbd8f2465d fs/bcachefs/btree_update_leaf.c Kent Overstreet 2017-03-16 157 1c6fdbd8f2465d fs/bcachefs/btree_update_leaf.c Kent Overstreet 2017-03-16 158 /* Handle overwrites and do insert, for non extents: */ 9f6bd30703a32c fs/bcachefs/btree_update_leaf.c Kent Overstreet 2021-08-24 159 bool bch2_btree_bset_insert_key(struct btree_trans *trans, 67e0dd8f0d8b4b fs/bcachefs/btree_update_leaf.c Kent Overstreet 2021-08-30 160 struct btree_path *path, 1c6fdbd8f2465d fs/bcachefs/btree_update_leaf.c Kent Overstreet 2017-03-16 161 struct btree *b, 1c6fdbd8f2465d fs/bcachefs/btree_update_leaf.c Kent Overstreet 2017-03-16 162 struct btree_node_iter *node_iter, 1c6fdbd8f2465d fs/bcachefs/btree_update_leaf.c Kent Overstreet 2017-03-16 163 struct bkey_i *insert) 1c6fdbd8f2465d fs/bcachefs/btree_update_leaf.c Kent Overstreet 2017-03-16 164 { 1c6fdbd8f2465d fs/bcachefs/btree_update_leaf.c Kent Overstreet 2017-03-16 165 EBUG_ON(btree_node_just_written(b)); 1c6fdbd8f2465d fs/bcachefs/btree_update_leaf.c Kent Overstreet 2017-03-16 166 EBUG_ON(bset_written(b, btree_bset_last(b))); 1c6fdbd8f2465d fs/bcachefs/btree_update_leaf.c Kent Overstreet 2017-03-16 167 EBUG_ON(bkey_deleted(&insert->k) && bkey_val_u64s(&insert->k)); e88a75ebe86c1d fs/bcachefs/btree_update_leaf.c Kent Overstreet 2022-11-24 168 EBUG_ON(bpos_lt(insert->k.p, b->data->min_key)); e88a75ebe86c1d fs/bcachefs/btree_update_leaf.c Kent Overstreet 2022-11-24 169 EBUG_ON(bpos_gt(insert->k.p, b->data->max_key)); ec4edd7b9d2038 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2024-01-16 170 EBUG_ON(insert->k.u64s > bch2_btree_keys_u64s_remaining(b)); da525760802b9f fs/bcachefs/btree_trans_commit.c Kent Overstreet 2023-08-21 171 EBUG_ON(!b->c.level && !bpos_eq(insert->k.p, path->pos)); 28aa859b6b422d fs/bcachefs/btree_trans_commit.c Kent Overstreet 2025-03-20 172 kmsan_check_memory(insert, bkey_bytes(&insert->k)); 1c6fdbd8f2465d fs/bcachefs/btree_update_leaf.c Kent Overstreet 2017-03-16 173 29a3ec38abe984 fs/bcachefs/btree/commit.c Kent Overstreet 2025-10-31 174 struct bkey_packed *k = bch2_btree_node_iter_peek_all(node_iter, b); 811d2bcd85a826 fs/bcachefs/btree_update_leaf.c Kent Overstreet 2020-11-07 175 if (k && bkey_cmp_left_packed(b, k, &insert->k.p)) ae54c4539b3cf8 fs/bcachefs/btree_update_leaf.c Kent Overstreet 2020-01-06 176 k = NULL; 1c6fdbd8f2465d fs/bcachefs/btree_update_leaf.c Kent Overstreet 2017-03-16 177 ae54c4539b3cf8 fs/bcachefs/btree_update_leaf.c Kent Overstreet 2020-01-06 178 /* @k is the key being overwritten/deleted, if any: */ c052cf82f3d66a fs/bcachefs/btree_update_leaf.c Kent Overstreet 2021-02-19 179 EBUG_ON(k && bkey_deleted(k)); 1c6fdbd8f2465d fs/bcachefs/btree_update_leaf.c Kent Overstreet 2017-03-16 180 fdf224003354fb fs/bcachefs/btree_update_leaf.c Kent Overstreet 2020-01-30 181 /* Deleting, but not found? nothing to do: */ c052cf82f3d66a fs/bcachefs/btree_update_leaf.c Kent Overstreet 2021-02-19 182 if (bkey_deleted(&insert->k) && !k) ae54c4539b3cf8 fs/bcachefs/btree_update_leaf.c Kent Overstreet 2020-01-06 183 return false; 1c6fdbd8f2465d fs/bcachefs/btree_update_leaf.c Kent Overstreet 2017-03-16 184 29a3ec38abe984 fs/bcachefs/btree/commit.c Kent Overstreet 2025-10-31 @185 if (k) { ae54c4539b3cf8 fs/bcachefs/btree_update_leaf.c Kent Overstreet 2020-01-06 186 btree_account_key_drop(b, k); c9bebae65eade6 fs/bcachefs/btree_update_leaf.c Kent Overstreet 2019-11-29 187 k->type = KEY_TYPE_deleted; c9bebae65eade6 fs/bcachefs/btree_update_leaf.c Kent Overstreet 2019-11-29 188 29a3ec38abe984 fs/bcachefs/btree/commit.c Kent Overstreet 2025-10-31 189 if (k->needs_whiteout) { 29a3ec38abe984 fs/bcachefs/btree/commit.c Kent Overstreet 2025-10-31 190 if (bkey_deleted(&insert->k)) ec4edd7b9d2038 fs/bcachefs/btree_trans_commit.c Kent Overstreet 2024-01-16 191 push_whiteout(b, insert->k.p); 29a3ec38abe984 fs/bcachefs/btree/commit.c Kent Overstreet 2025-10-31 192 else 29a3ec38abe984 fs/bcachefs/btree/commit.c Kent Overstreet 2025-10-31 193 insert->k.needs_whiteout = true; c9bebae65eade6 fs/bcachefs/btree_update_leaf.c Kent Overstreet 2019-11-29 194 k->needs_whiteout = false; c9bebae65eade6 fs/bcachefs/btree_update_leaf.c Kent Overstreet 2019-11-29 195 } c9bebae65eade6 fs/bcachefs/btree_update_leaf.c Kent Overstreet 2019-11-29 196 29a3ec38abe984 fs/bcachefs/btree/commit.c Kent Overstreet 2025-10-31 197 if (k < btree_bset_last(b)->start) 29a3ec38abe984 fs/bcachefs/btree/commit.c Kent Overstreet 2025-10-31 198 bch2_btree_path_fix_key_modified(trans, b, k); ae54c4539b3cf8 fs/bcachefs/btree_update_leaf.c Kent Overstreet 2020-01-06 199 } c9bebae65eade6 fs/bcachefs/btree_update_leaf.c Kent Overstreet 2019-11-29 200 29a3ec38abe984 fs/bcachefs/btree/commit.c Kent Overstreet 2025-10-31 @201 unsigned clobber_u64s = k >= btree_bset_last(b)->start ? k->u64s : 0; f2e8c69fcb63d2 fs/bcachefs/btree_update_leaf.c Kent Overstreet 2020-01-05 202 29a3ec38abe984 fs/bcachefs/btree/commit.c Kent Overstreet 2025-10-31 203 if (bkey_deleted(&insert->k)) { 29a3ec38abe984 fs/bcachefs/btree/commit.c Kent Overstreet 2025-10-31 204 if (k >= btree_bset_last(b)->start) 29a3ec38abe984 fs/bcachefs/btree/commit.c Kent Overstreet 2025-10-31 205 bch2_bset_delete(b, k, clobber_u64s); 1c6fdbd8f2465d fs/bcachefs/btree_update_leaf.c Kent Overstreet 2017-03-16 206 } else { 29a3ec38abe984 fs/bcachefs/btree/commit.c Kent Overstreet 2025-10-31 207 if (k < btree_bset_last(b)->start) 216c9facfd7568 fs/bcachefs/btree_update_leaf.c Kent Overstreet 2018-08-11 208 k = bch2_btree_node_iter_bset_pos(node_iter, b, bset_tree_last(b)); 29a3ec38abe984 fs/bcachefs/btree/commit.c Kent Overstreet 2025-10-31 209 5935bf3341b82b fs/bcachefs/btree_trans_commit.c Alan Huang 2024-08-14 210 bch2_bset_insert(b, k, insert, clobber_u64s); 29a3ec38abe984 fs/bcachefs/btree/commit.c Kent Overstreet 2025-10-31 211 } 29a3ec38abe984 fs/bcachefs/btree/commit.c Kent Overstreet 2025-10-31 212 29a3ec38abe984 fs/bcachefs/btree/commit.c Kent Overstreet 2025-10-31 213 unsigned new_u64s = !bkey_deleted(&insert->k) ? k->u64s : 0; fdf224003354fb fs/bcachefs/btree_update_leaf.c Kent Overstreet 2020-01-30 214 if (clobber_u64s != new_u64s) 29a3ec38abe984 fs/bcachefs/btree/commit.c Kent Overstreet 2025-10-31 215 bch2_btree_node_iter_fix(trans, path, b, node_iter, k, clobber_u64s, new_u64s); 29a3ec38abe984 fs/bcachefs/btree/commit.c Kent Overstreet 2025-10-31 216 1c6fdbd8f2465d fs/bcachefs/btree_update_leaf.c Kent Overstreet 2017-03-16 217 return true; 1c6fdbd8f2465d fs/bcachefs/btree_update_leaf.c Kent Overstreet 2017-03-16 218 } 1c6fdbd8f2465d fs/bcachefs/btree_update_leaf.c Kent Overstreet 2017-03-16 219 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki