[linux-next:master 5141/7793] drivers/gpu/drm/amd/amdgpu/../display/dc/dio/dcn10/dcn10_link_encoder.c:1192 dcn10_link_encoder_dp_set_phy_pattern() warn: variable dereferenced before check 'param' (see line 1169)
Dan Carpenter <[email protected]> Thu, 23 Jul 2026 11:31:55 +0300
| Newsgroups | dev.linux.lists.oe-kbuild |
|---|---|
| Message-ID | <20260723083155.QyhQT6WlGxtFJPz0Mm-sDX4jSTBLDXy4CFk0tpDb_YA@z> |
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 3fe08b9796f36ef437ab9328e7dd1e5ff2d66603 commit: b6f466c509ad2f390b3fc91cd0de4783554f5f98 [5141/7793] drm/amd/display: add null pointer access check config: x86_64-randconfig-161-20260721 (https://download.01.org/0day-ci/archive/20260722/[email protected]/config) compiler: gcc-14 (Debian 14.2.0-19) 14.2.0 smatch: v0.5.0-9187-g5189e3fb If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <[email protected]> | Reported-by: Dan Carpenter <[email protected]> | Closes: https://lore.kernel.org/r/[email protected]/ New smatch warnings: drivers/gpu/drm/amd/amdgpu/../display/dc/dio/dcn10/dcn10_link_encoder.c:1192 dcn10_link_encoder_dp_set_phy_pattern() warn: variable dereferenced before check 'param' (see line 1169) Old smatch warnings: drivers/gpu/drm/amd/amdgpu/../display/dc/dio/dcn10/dcn10_link_encoder.c:1206 dcn10_link_encoder_dp_set_phy_pattern() warn: variable dereferenced before check 'param' (see line 1169) vim +/param +1192 drivers/gpu/drm/amd/amdgpu/../display/dc/dio/dcn10/dcn10_link_encoder.c f0cd0a346dfd1d drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c Eric Bernstein 2018-04-26 1163 void dcn10_link_encoder_dp_set_phy_pattern( f0cd0a346dfd1d drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c Eric Bernstein 2018-04-26 1164 struct link_encoder *enc, f0cd0a346dfd1d drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c Eric Bernstein 2018-04-26 1165 const struct encoder_set_dp_phy_pattern_param *param) f0cd0a346dfd1d drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c Eric Bernstein 2018-04-26 1166 { f0cd0a346dfd1d drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c Eric Bernstein 2018-04-26 1167 struct dcn10_link_encoder *enc10 = TO_DCN10_LINK_ENC(enc); f0cd0a346dfd1d drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c Eric Bernstein 2018-04-26 1168 f0cd0a346dfd1d drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c Eric Bernstein 2018-04-26 @1169 switch (param->dp_phy_pattern) { ^^^^^^^^^^^^^^^^^^^^^ Dereference f0cd0a346dfd1d drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c Eric Bernstein 2018-04-26 1170 case DP_TEST_PATTERN_TRAINING_PATTERN1: f0cd0a346dfd1d drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c Eric Bernstein 2018-04-26 1171 dcn10_link_encoder_set_dp_phy_pattern_training_pattern(enc, 0); f0cd0a346dfd1d drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c Eric Bernstein 2018-04-26 1172 break; f0cd0a346dfd1d drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c Eric Bernstein 2018-04-26 1173 case DP_TEST_PATTERN_TRAINING_PATTERN2: f0cd0a346dfd1d drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c Eric Bernstein 2018-04-26 1174 dcn10_link_encoder_set_dp_phy_pattern_training_pattern(enc, 1); f0cd0a346dfd1d drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c Eric Bernstein 2018-04-26 1175 break; f0cd0a346dfd1d drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c Eric Bernstein 2018-04-26 1176 case DP_TEST_PATTERN_TRAINING_PATTERN3: f0cd0a346dfd1d drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c Eric Bernstein 2018-04-26 1177 dcn10_link_encoder_set_dp_phy_pattern_training_pattern(enc, 2); f0cd0a346dfd1d drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c Eric Bernstein 2018-04-26 1178 break; f0cd0a346dfd1d drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c Eric Bernstein 2018-04-26 1179 case DP_TEST_PATTERN_TRAINING_PATTERN4: f0cd0a346dfd1d drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c Eric Bernstein 2018-04-26 1180 dcn10_link_encoder_set_dp_phy_pattern_training_pattern(enc, 3); f0cd0a346dfd1d drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c Eric Bernstein 2018-04-26 1181 break; f0cd0a346dfd1d drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c Eric Bernstein 2018-04-26 1182 case DP_TEST_PATTERN_D102: f0cd0a346dfd1d drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c Eric Bernstein 2018-04-26 1183 set_dp_phy_pattern_d102(enc10); f0cd0a346dfd1d drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c Eric Bernstein 2018-04-26 1184 break; f0cd0a346dfd1d drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c Eric Bernstein 2018-04-26 1185 case DP_TEST_PATTERN_SYMBOL_ERROR: f0cd0a346dfd1d drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c Eric Bernstein 2018-04-26 1186 set_dp_phy_pattern_symbol_error(enc10); f0cd0a346dfd1d drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c Eric Bernstein 2018-04-26 1187 break; f0cd0a346dfd1d drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c Eric Bernstein 2018-04-26 1188 case DP_TEST_PATTERN_PRBS7: f0cd0a346dfd1d drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c Eric Bernstein 2018-04-26 1189 set_dp_phy_pattern_prbs7(enc10); f0cd0a346dfd1d drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c Eric Bernstein 2018-04-26 1190 break; f0cd0a346dfd1d drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c Eric Bernstein 2018-04-26 1191 case DP_TEST_PATTERN_80BIT_CUSTOM: b6f466c509ad2f drivers/gpu/drm/amd/display/dc/dio/dcn10/dcn10_link_encoder.c Charlene Liu 2026-06-22 @1192 if (param) ^^^^^ The patch adds a pointless check. f0cd0a346dfd1d drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c Eric Bernstein 2018-04-26 1193 set_dp_phy_pattern_80bit_custom( f0cd0a346dfd1d drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c Eric Bernstein 2018-04-26 1194 enc10, param->custom_pattern); f0cd0a346dfd1d drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c Eric Bernstein 2018-04-26 1195 break; f0cd0a346dfd1d drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c Eric Bernstein 2018-04-26 1196 case DP_TEST_PATTERN_CP2520_1: f0cd0a346dfd1d drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c Eric Bernstein 2018-04-26 1197 set_dp_phy_pattern_hbr2_compliance_cp2520_2(enc10, 1); f0cd0a346dfd1d drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c Eric Bernstein 2018-04-26 1198 break; f0cd0a346dfd1d drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c Eric Bernstein 2018-04-26 1199 case DP_TEST_PATTERN_CP2520_2: f0cd0a346dfd1d drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c Eric Bernstein 2018-04-26 1200 set_dp_phy_pattern_hbr2_compliance_cp2520_2(enc10, 2); f0cd0a346dfd1d drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c Eric Bernstein 2018-04-26 1201 break; f0cd0a346dfd1d drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c Eric Bernstein 2018-04-26 1202 case DP_TEST_PATTERN_CP2520_3: f0cd0a346dfd1d drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c Eric Bernstein 2018-04-26 1203 set_dp_phy_pattern_hbr2_compliance_cp2520_2(enc10, 3); f0cd0a346dfd1d drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c Eric Bernstein 2018-04-26 1204 break; f0cd0a346dfd1d drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c Eric Bernstein 2018-04-26 1205 case DP_TEST_PATTERN_VIDEO_MODE: { b6f466c509ad2f drivers/gpu/drm/amd/display/dc/dio/dcn10/dcn10_link_encoder.c Charlene Liu 2026-06-22 1206 if (param) And another. f0cd0a346dfd1d drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c Eric Bernstein 2018-04-26 1207 set_dp_phy_pattern_passthrough_mode( f0cd0a346dfd1d drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c Eric Bernstein 2018-04-26 1208 enc10, param->dp_panel_mode); f0cd0a346dfd1d drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c Eric Bernstein 2018-04-26 1209 break; f0cd0a346dfd1d drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c Eric Bernstein 2018-04-26 1210 } f0cd0a346dfd1d drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c Eric Bernstein 2018-04-26 1211 f0cd0a346dfd1d drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c Eric Bernstein 2018-04-26 1212 default: f0cd0a346dfd1d drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c Eric Bernstein 2018-04-26 1213 /* invalid phy pattern */ f0cd0a346dfd1d drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c Eric Bernstein 2018-04-26 1214 ASSERT_CRITICAL(false); f0cd0a346dfd1d drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c Eric Bernstein 2018-04-26 1215 break; f0cd0a346dfd1d drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c Eric Bernstein 2018-04-26 1216 } f0cd0a346dfd1d drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c Eric Bernstein 2018-04-26 1217 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki