[linux-next:master 5380/8209] drivers/gpu/drm/amd/amdgpu/../display/dc/hubp/dcn10/dcn10_hubp.c:775 hubp1_is_flip_pending() error: we previously assumed 'hubp' could be null (see line 760)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   290aaf24a551d5a0dce037e3fab30820f9113a10
commit: b736792e5bd4a62f24e8d1e310bf4a75bfbeaaaa [5380/8209] drm/amd/display: Remove unused-but-set variable hubp from
config: x86_64-randconfig-161-20260721 (https://download.01.org/0day-ci/archive/20260722/[email protected]/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
smatch: v0.5.0-9187-g5189e3fb

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Reported-by: Dan Carpenter <[email protected]>
| Closes: https://lore.kernel.org/r/[email protected]/

smatch warnings:
drivers/gpu/drm/amd/amdgpu/../display/dc/hubp/dcn10/dcn10_hubp.c:775 hubp1_is_flip_pending() error: we previously assumed 'hubp' could be null (see line 760)

vim +/hubp +775 drivers/gpu/drm/amd/amdgpu/../display/dc/hubp/dcn10/dcn10_hubp.c

8feabd03d34e45 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_mem_input.c Yue Hin Lau        2017-10-02  754  bool hubp1_is_flip_pending(struct hubp *hubp)
70ccab604049bb drivers/gpu/drm/amd/display/dc/dcn10/dcn10_mem_input.c Harry Wentland     2017-05-08  755  {
db3bc05034a4b0 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_mem_input.c Dmytro Laktyushkin 2017-06-28  756  	uint32_t flip_pending = 0;
8feabd03d34e45 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_mem_input.c Yue Hin Lau        2017-10-02  757  	struct dcn10_hubp *hubp1 = TO_DCN10_HUBP(hubp);
2f1e8efd10315c drivers/gpu/drm/amd/display/dc/dcn10/dcn10_mem_input.c Yongqiang Sun      2017-06-06  758  	struct dc_plane_address earliest_inuse_address;
70ccab604049bb drivers/gpu/drm/amd/display/dc/dcn10/dcn10_mem_input.c Harry Wentland     2017-05-08  759  
e8cb7a4dd9dfff drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hubp.c      Aric Cyr           2020-08-21 @760  	if (hubp && hubp->power_gated)
                                                                                                                    ^^^^
This check can be deleted.  If you have cross function analysis then
Smatch knows that the NULL check is harmless but if you don't then it
warns that the NULL check doesn't make sense.

e8cb7a4dd9dfff drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hubp.c      Aric Cyr           2020-08-21  761  		return false;
e8cb7a4dd9dfff drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hubp.c      Aric Cyr           2020-08-21  762  
70ccab604049bb drivers/gpu/drm/amd/display/dc/dcn10/dcn10_mem_input.c Harry Wentland     2017-05-08  763  	REG_GET(DCSURF_FLIP_CONTROL,
db3bc05034a4b0 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_mem_input.c Dmytro Laktyushkin 2017-06-28  764  			SURFACE_FLIP_PENDING, &flip_pending);
70ccab604049bb drivers/gpu/drm/amd/display/dc/dcn10/dcn10_mem_input.c Harry Wentland     2017-05-08  765  
2f1e8efd10315c drivers/gpu/drm/amd/display/dc/dcn10/dcn10_mem_input.c Yongqiang Sun      2017-06-06  766  	REG_GET(DCSURF_SURFACE_EARLIEST_INUSE,
2f1e8efd10315c drivers/gpu/drm/amd/display/dc/dcn10/dcn10_mem_input.c Yongqiang Sun      2017-06-06  767  			SURFACE_EARLIEST_INUSE_ADDRESS, &earliest_inuse_address.grph.addr.low_part);
2f1e8efd10315c drivers/gpu/drm/amd/display/dc/dcn10/dcn10_mem_input.c Yongqiang Sun      2017-06-06  768  
2f1e8efd10315c drivers/gpu/drm/amd/display/dc/dcn10/dcn10_mem_input.c Yongqiang Sun      2017-06-06  769  	REG_GET(DCSURF_SURFACE_EARLIEST_INUSE_HIGH,
2f1e8efd10315c drivers/gpu/drm/amd/display/dc/dcn10/dcn10_mem_input.c Yongqiang Sun      2017-06-06  770  			SURFACE_EARLIEST_INUSE_ADDRESS_HIGH, &earliest_inuse_address.grph.addr.high_part);
2f1e8efd10315c drivers/gpu/drm/amd/display/dc/dcn10/dcn10_mem_input.c Yongqiang Sun      2017-06-06  771  
db3bc05034a4b0 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_mem_input.c Dmytro Laktyushkin 2017-06-28  772  	if (flip_pending)
70ccab604049bb drivers/gpu/drm/amd/display/dc/dcn10/dcn10_mem_input.c Harry Wentland     2017-05-08  773  		return true;
70ccab604049bb drivers/gpu/drm/amd/display/dc/dcn10/dcn10_mem_input.c Harry Wentland     2017-05-08  774  
b736792e5bd4a6 drivers/gpu/drm/amd/display/dc/hubp/dcn10/dcn10_hubp.c Gleb Markov        2026-06-29 @775  	if (earliest_inuse_address.grph.addr.quad_part != hubp->request_address.grph.addr.quad_part)
2f1e8efd10315c drivers/gpu/drm/amd/display/dc/dcn10/dcn10_mem_input.c Yongqiang Sun      2017-06-06  776  		return true;
2f1e8efd10315c drivers/gpu/drm/amd/display/dc/dcn10/dcn10_mem_input.c Yongqiang Sun      2017-06-06  777  
70ccab604049bb drivers/gpu/drm/amd/display/dc/dcn10/dcn10_mem_input.c Harry Wentland     2017-05-08  778  	return false;
70ccab604049bb drivers/gpu/drm/amd/display/dc/dcn10/dcn10_mem_input.c Harry Wentland     2017-05-08  779  }

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki