drivers/gpu/drm/stm/ltdc.c:1903 ltdc_resume() warn: 'ldev->pixel_clk' from clk_prepare_enable() not released on lines: 1903.

BCC: [email protected]
CC: [email protected]
CC: [email protected]
TO: Yannick Fertre <[email protected]>
CC: "Raphael Gallais-Pou" <[email protected]>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git =
master
head:   4539944e515183668109bdf4d0c3d7d228383d88
commit: d80667642b0f43580efd489d627dd24aa10ab98f drm/stm: ltdc: support new=
 hardware version for STM32MP25 SoC
date:   11 months ago
:::::: branch date: 2 days ago
:::::: commit date: 11 months ago
config: um-randconfig-r071-20260724 (https://download.01.org/0day-ci/archiv=
e/20260724/[email protected]/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
smatch: v0.5.0-9187-g5189e3fb

If you fix the issue in a separate patch/commit (i.e. not just a new versio=
n of
the same patch/commit), kindly add following tags
| Fixes: d80667642b0f ("drm/stm: ltdc: support new hardware version for STM=
32MP25 SoC")
| Reported-by: kernel test robot <[email protected]>
| Reported-by: Dan Carpenter <[email protected]>
| Closes: https://lore.kernel.org/r/[email protected]/

New smatch warnings:
drivers/gpu/drm/stm/ltdc.c:1903 ltdc_resume() warn: 'ldev->pixel_clk' from =
clk_prepare_enable() not released on lines: 1903.

Old smatch warnings:
drivers/gpu/drm/stm/ltdc.c:939 ltdc_crtc_mode_set_nofb() warn: pm_runtime_g=
et_sync() also returns 1 on success

vim +1903 drivers/gpu/drm/stm/ltdc.c

df61c776657fa5 Yannick Fertr=C3=A9      2019-03-21  1883 =20
df61c776657fa5 Yannick Fertr=C3=A9      2019-03-21  1884  int ltdc_resume(s=
truct drm_device *ddev)
df61c776657fa5 Yannick Fertr=C3=A9      2019-03-21  1885  {
df61c776657fa5 Yannick Fertr=C3=A9      2019-03-21  1886  	struct ltdc_devi=
ce *ldev =3D ddev->dev_private;
df61c776657fa5 Yannick Fertr=C3=A9      2019-03-21  1887  	int ret;
df61c776657fa5 Yannick Fertr=C3=A9      2019-03-21  1888 =20
1e00a12dbb09a7 Raphael Gallais-Pou 2025-08-25  1889  	drm_dbg_driver(ddev, =
"\n");
df61c776657fa5 Yannick Fertr=C3=A9      2019-03-21  1890 =20
df61c776657fa5 Yannick Fertr=C3=A9      2019-03-21  1891  	ret =3D clk_prep=
are_enable(ldev->pixel_clk);
df61c776657fa5 Yannick Fertr=C3=A9      2019-03-21  1892  	if (ret) {
1e00a12dbb09a7 Raphael Gallais-Pou 2025-08-25  1893  		drm_err(ddev, "faile=
d to enable pixel clock (%d)\n", ret);
df61c776657fa5 Yannick Fertr=C3=A9      2019-03-21  1894  		return ret;
df61c776657fa5 Yannick Fertr=C3=A9      2019-03-21  1895  	}
df61c776657fa5 Yannick Fertr=C3=A9      2019-03-21  1896 =20
d80667642b0f43 Yannick Fertre      2025-08-22  1897  	if (ldev->bus_clk) {
d80667642b0f43 Yannick Fertre      2025-08-22  1898  		ret =3D clk_prepare_=
enable(ldev->bus_clk);
d80667642b0f43 Yannick Fertre      2025-08-22  1899  		if (ret)
d80667642b0f43 Yannick Fertre      2025-08-22  1900  			drm_err(ddev, "fail=
ed to enable bus clock (%d)\n", ret);
d80667642b0f43 Yannick Fertre      2025-08-22  1901  	}
d80667642b0f43 Yannick Fertre      2025-08-22  1902 =20
d80667642b0f43 Yannick Fertre      2025-08-22 @1903  	return ret;
df61c776657fa5 Yannick Fertr=C3=A9      2019-03-21  1904  }
df61c776657fa5 Yannick Fertr=C3=A9      2019-03-21  1905 =20

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki