drivers/crypto/ti/dthev2-aes.c:205 dthe_aes_set_ctrl_key() error: buffer overflow 'ctx->key' 16 <= u32max
kernel test robot <[email protected]>
| Newsgroups | dev.linux.lists.oe-kbuild |
|---|---|
| Message-ID | <[email protected]> |
BCC: [email protected] CC: [email protected] CC: [email protected] TO: T Pratham <[email protected]> CC: Herbert Xu <[email protected]> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: f5bbbfec59b4e2fb7520a91de3df8a6174325d6a commit: 4fbfd7b206b1aa3fedfe8e82a8d3b8daca007d57 crypto: ti - Add support for AES-XTS in DTHEv2 driver date: 10 months ago :::::: branch date: 35 hours ago :::::: commit date: 10 months ago config: parisc-randconfig-r072-20260813 (https://download.01.org/0day-ci/archive/20260813/[email protected]/config) compiler: hppa-linux-gcc (GCC) 8.5.0 smatch: v0.5.0-9187-g5189e3fb If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Fixes: 4fbfd7b206b1 ("crypto: ti - Add support for AES-XTS in DTHEv2 driver") | Reported-by: kernel test robot <[email protected]> | Reported-by: Dan Carpenter <[email protected]> | Closes: https://lore.kernel.org/r/[email protected]/ smatch warnings: drivers/crypto/ti/dthev2-aes.c:205 dthe_aes_set_ctrl_key() error: buffer overflow 'ctx->key' 16 <= u32max vim +205 drivers/crypto/ti/dthev2-aes.c 4fbfd7b206b1aa T Pratham 2025-10-22 179 52f641bc63a466 T Pratham 2025-08-20 180 static void dthe_aes_set_ctrl_key(struct dthe_tfm_ctx *ctx, 52f641bc63a466 T Pratham 2025-08-20 181 struct dthe_aes_req_ctx *rctx, 52f641bc63a466 T Pratham 2025-08-20 182 u32 *iv_in) 52f641bc63a466 T Pratham 2025-08-20 183 { 52f641bc63a466 T Pratham 2025-08-20 184 struct dthe_data *dev_data = dthe_get_dev(ctx); 52f641bc63a466 T Pratham 2025-08-20 185 void __iomem *aes_base_reg = dev_data->regs + DTHE_P_AES_BASE; 52f641bc63a466 T Pratham 2025-08-20 186 u32 ctrl_val = 0; 52f641bc63a466 T Pratham 2025-08-20 187 52f641bc63a466 T Pratham 2025-08-20 188 writel_relaxed(ctx->key[0], aes_base_reg + DTHE_P_AES_KEY1_0); 52f641bc63a466 T Pratham 2025-08-20 189 writel_relaxed(ctx->key[1], aes_base_reg + DTHE_P_AES_KEY1_1); 52f641bc63a466 T Pratham 2025-08-20 190 writel_relaxed(ctx->key[2], aes_base_reg + DTHE_P_AES_KEY1_2); 52f641bc63a466 T Pratham 2025-08-20 191 writel_relaxed(ctx->key[3], aes_base_reg + DTHE_P_AES_KEY1_3); 52f641bc63a466 T Pratham 2025-08-20 192 52f641bc63a466 T Pratham 2025-08-20 193 if (ctx->keylen > AES_KEYSIZE_128) { 52f641bc63a466 T Pratham 2025-08-20 194 writel_relaxed(ctx->key[4], aes_base_reg + DTHE_P_AES_KEY1_4); 52f641bc63a466 T Pratham 2025-08-20 195 writel_relaxed(ctx->key[5], aes_base_reg + DTHE_P_AES_KEY1_5); 52f641bc63a466 T Pratham 2025-08-20 196 } 52f641bc63a466 T Pratham 2025-08-20 197 if (ctx->keylen == AES_KEYSIZE_256) { 52f641bc63a466 T Pratham 2025-08-20 198 writel_relaxed(ctx->key[6], aes_base_reg + DTHE_P_AES_KEY1_6); 52f641bc63a466 T Pratham 2025-08-20 199 writel_relaxed(ctx->key[7], aes_base_reg + DTHE_P_AES_KEY1_7); 52f641bc63a466 T Pratham 2025-08-20 200 } 52f641bc63a466 T Pratham 2025-08-20 201 4fbfd7b206b1aa T Pratham 2025-10-22 202 if (ctx->aes_mode == DTHE_AES_XTS) { 4fbfd7b206b1aa T Pratham 2025-10-22 203 size_t key2_offset = ctx->keylen / sizeof(u32); 4fbfd7b206b1aa T Pratham 2025-10-22 204 4fbfd7b206b1aa T Pratham 2025-10-22 @205 writel_relaxed(ctx->key[key2_offset + 0], aes_base_reg + DTHE_P_AES_KEY2_0); 4fbfd7b206b1aa T Pratham 2025-10-22 206 writel_relaxed(ctx->key[key2_offset + 1], aes_base_reg + DTHE_P_AES_KEY2_1); 4fbfd7b206b1aa T Pratham 2025-10-22 207 writel_relaxed(ctx->key[key2_offset + 2], aes_base_reg + DTHE_P_AES_KEY2_2); 4fbfd7b206b1aa T Pratham 2025-10-22 208 writel_relaxed(ctx->key[key2_offset + 3], aes_base_reg + DTHE_P_AES_KEY2_3); 4fbfd7b206b1aa T Pratham 2025-10-22 209 4fbfd7b206b1aa T Pratham 2025-10-22 210 if (ctx->keylen > AES_KEYSIZE_128) { 4fbfd7b206b1aa T Pratham 2025-10-22 211 writel_relaxed(ctx->key[key2_offset + 4], aes_base_reg + DTHE_P_AES_KEY2_4); 4fbfd7b206b1aa T Pratham 2025-10-22 212 writel_relaxed(ctx->key[key2_offset + 5], aes_base_reg + DTHE_P_AES_KEY2_5); 4fbfd7b206b1aa T Pratham 2025-10-22 213 } 4fbfd7b206b1aa T Pratham 2025-10-22 214 if (ctx->keylen == AES_KEYSIZE_256) { 4fbfd7b206b1aa T Pratham 2025-10-22 215 writel_relaxed(ctx->key[key2_offset + 6], aes_base_reg + DTHE_P_AES_KEY2_6); 4fbfd7b206b1aa T Pratham 2025-10-22 216 writel_relaxed(ctx->key[key2_offset + 7], aes_base_reg + DTHE_P_AES_KEY2_7); 4fbfd7b206b1aa T Pratham 2025-10-22 217 } 4fbfd7b206b1aa T Pratham 2025-10-22 218 } 4fbfd7b206b1aa T Pratham 2025-10-22 219 52f641bc63a466 T Pratham 2025-08-20 220 if (rctx->enc) 52f641bc63a466 T Pratham 2025-08-20 221 ctrl_val |= DTHE_AES_CTRL_DIR_ENC; 52f641bc63a466 T Pratham 2025-08-20 222 52f641bc63a466 T Pratham 2025-08-20 223 if (ctx->keylen == AES_KEYSIZE_128) 52f641bc63a466 T Pratham 2025-08-20 224 ctrl_val |= DTHE_AES_CTRL_KEYSIZE_16B; 52f641bc63a466 T Pratham 2025-08-20 225 else if (ctx->keylen == AES_KEYSIZE_192) 52f641bc63a466 T Pratham 2025-08-20 226 ctrl_val |= DTHE_AES_CTRL_KEYSIZE_24B; 52f641bc63a466 T Pratham 2025-08-20 227 else 52f641bc63a466 T Pratham 2025-08-20 228 ctrl_val |= DTHE_AES_CTRL_KEYSIZE_32B; 52f641bc63a466 T Pratham 2025-08-20 229 52f641bc63a466 T Pratham 2025-08-20 230 // Write AES mode 52f641bc63a466 T Pratham 2025-08-20 231 ctrl_val &= DTHE_AES_CTRL_MODE_CLEAR_MASK; 52f641bc63a466 T Pratham 2025-08-20 232 switch (ctx->aes_mode) { 52f641bc63a466 T Pratham 2025-08-20 233 case DTHE_AES_ECB: 52f641bc63a466 T Pratham 2025-08-20 234 ctrl_val |= AES_CTRL_ECB_MASK; 52f641bc63a466 T Pratham 2025-08-20 235 break; 52f641bc63a466 T Pratham 2025-08-20 236 case DTHE_AES_CBC: 52f641bc63a466 T Pratham 2025-08-20 237 ctrl_val |= AES_CTRL_CBC_MASK; 52f641bc63a466 T Pratham 2025-08-20 238 break; 4fbfd7b206b1aa T Pratham 2025-10-22 239 case DTHE_AES_XTS: 4fbfd7b206b1aa T Pratham 2025-10-22 240 ctrl_val |= AES_CTRL_XTS_MASK; 4fbfd7b206b1aa T Pratham 2025-10-22 241 break; 52f641bc63a466 T Pratham 2025-08-20 242 } 52f641bc63a466 T Pratham 2025-08-20 243 52f641bc63a466 T Pratham 2025-08-20 244 if (iv_in) { 52f641bc63a466 T Pratham 2025-08-20 245 ctrl_val |= DTHE_AES_CTRL_SAVE_CTX_SET; 52f641bc63a466 T Pratham 2025-08-20 246 for (int i = 0; i < AES_IV_WORDS; ++i) 52f641bc63a466 T Pratham 2025-08-20 247 writel_relaxed(iv_in[i], 52f641bc63a466 T Pratham 2025-08-20 248 aes_base_reg + DTHE_P_AES_IV_IN_0 + (DTHE_REG_SIZE * i)); 52f641bc63a466 T Pratham 2025-08-20 249 } 52f641bc63a466 T Pratham 2025-08-20 250 52f641bc63a466 T Pratham 2025-08-20 251 writel_relaxed(ctrl_val, aes_base_reg + DTHE_P_AES_CTRL); 52f641bc63a466 T Pratham 2025-08-20 252 } 52f641bc63a466 T Pratham 2025-08-20 253 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki