[gerg-m68knommu:dt 2/22] drivers/tty/serial/mcf.c:586:25: sparse: sparse: unsigned value that used to be signed checked against zero?

kernel test robot <[email protected]>
Newsgroups dev.linux.lists.oe-kbuild
Message-ID <[email protected]>
:::::: 
:::::: Manual check reason: "low confidence static check warning: drivers/tty/serial/mcf.c:586:25: sparse: sparse: unsigned value that used to be signed checked against zero?"
:::::: 

BCC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
TO: Greg Ungerer <[email protected]>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gerg/m68knommu.git dt
head:   76a231d031905d3bbc982b9a3d92619ce917e306
commit: 191a962ceb628c9ba07bb6d5687820afaa2823fb [2/22] serial: mcf: convert to use proper platform resources
:::::: branch date: 3 days ago
:::::: commit date: 3 days ago
config: m68k-randconfig-r122-20260813 (https://download.01.org/0day-ci/archive/20260814/[email protected]/config)
compiler: m68k-linux-gcc (GCC) 15.2.0
sparse: v0.6.5-rc1
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260814/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/r/[email protected]/

sparse warnings: (new ones prefixed by >>)
>> drivers/tty/serial/mcf.c:586:25: sparse: sparse: unsigned value that used to be signed checked against zero?
   drivers/tty/serial/mcf.c:585:37: sparse: signed value source

vim +586 drivers/tty/serial/mcf.c

49aa49bfd40d71 drivers/serial/mcf.c     Greg Ungerer      2007-10-23  570  
9671f09921d93e drivers/tty/serial/mcf.c Bill Pemberton    2012-11-19  571  static int mcf_probe(struct platform_device *pdev)
49aa49bfd40d71 drivers/serial/mcf.c     Greg Ungerer      2007-10-23  572  {
49aa49bfd40d71 drivers/serial/mcf.c     Greg Ungerer      2007-10-23  573  	struct uart_port *port;
191a962ceb628c drivers/tty/serial/mcf.c Greg Ungerer      2025-01-15  574  	struct resource *res;
49aa49bfd40d71 drivers/serial/mcf.c     Greg Ungerer      2007-10-23  575  
191a962ceb628c drivers/tty/serial/mcf.c Greg Ungerer      2025-01-15  576  	if (pdev->id >= MCF_MAXPORTS)
191a962ceb628c drivers/tty/serial/mcf.c Greg Ungerer      2025-01-15  577  		return -ENODEV;
191a962ceb628c drivers/tty/serial/mcf.c Greg Ungerer      2025-01-15  578  	port = &mcf_ports[pdev->id].port;
191a962ceb628c drivers/tty/serial/mcf.c Greg Ungerer      2025-01-15  579  
191a962ceb628c drivers/tty/serial/mcf.c Greg Ungerer      2025-01-15  580  	port->membase = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
191a962ceb628c drivers/tty/serial/mcf.c Greg Ungerer      2025-01-15  581  	if (IS_ERR(port->membase))
191a962ceb628c drivers/tty/serial/mcf.c Greg Ungerer      2025-01-15  582  		return PTR_ERR(port->membase);
191a962ceb628c drivers/tty/serial/mcf.c Greg Ungerer      2025-01-15  583  	port->mapbase = res->start;
49aa49bfd40d71 drivers/serial/mcf.c     Greg Ungerer      2007-10-23  584  
191a962ceb628c drivers/tty/serial/mcf.c Greg Ungerer      2025-01-15  585  	port->irq = platform_get_irq(pdev, 0);
191a962ceb628c drivers/tty/serial/mcf.c Greg Ungerer      2025-01-15 @586  	if (port->irq < 0)
191a962ceb628c drivers/tty/serial/mcf.c Greg Ungerer      2025-01-15  587  		return port->irq;
191a962ceb628c drivers/tty/serial/mcf.c Greg Ungerer      2025-01-15  588  
191a962ceb628c drivers/tty/serial/mcf.c Greg Ungerer      2025-01-15  589  	port->line = pdev->id;
49aa49bfd40d71 drivers/serial/mcf.c     Greg Ungerer      2007-10-23  590  	port->type = PORT_MCF;
201d8975ae5ada drivers/tty/serial/mcf.c Greg Ungerer      2015-01-08  591  	port->dev = &pdev->dev;
49aa49bfd40d71 drivers/serial/mcf.c     Greg Ungerer      2007-10-23  592  	port->iotype = SERIAL_IO_MEM;
49aa49bfd40d71 drivers/serial/mcf.c     Greg Ungerer      2007-10-23  593  	port->uartclk = MCF_BUSCLK;
49aa49bfd40d71 drivers/serial/mcf.c     Greg Ungerer      2007-10-23  594  	port->ops = &mcf_uart_ops;
5fda7a0e715c32 drivers/tty/serial/mcf.c Peter Hurley      2014-06-16  595  	port->flags = UPF_BOOT_AUTOCONF;
2fc0184dae7be5 drivers/tty/serial/mcf.c Ricardo Ribalda   2014-11-06  596  	port->rs485_config = mcf_config_rs485;
0139da50dc53f0 drivers/tty/serial/mcf.c Ilpo Järvinen     2022-07-04  597  	port->rs485_supported = mcf_rs485_supported;
4be87603b6dc9e drivers/tty/serial/mcf.c Angelo Dureghello 2020-10-02  598  	port->has_sysrq = IS_ENABLED(CONFIG_SERIAL_MCF_CONSOLE);
49aa49bfd40d71 drivers/serial/mcf.c     Greg Ungerer      2007-10-23  599  
49aa49bfd40d71 drivers/serial/mcf.c     Greg Ungerer      2007-10-23  600  	uart_add_one_port(&mcf_driver, port);
49aa49bfd40d71 drivers/serial/mcf.c     Greg Ungerer      2007-10-23  601  	return 0;
49aa49bfd40d71 drivers/serial/mcf.c     Greg Ungerer      2007-10-23  602  }
49aa49bfd40d71 drivers/serial/mcf.c     Greg Ungerer      2007-10-23  603  

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.