[android-common:android15-6.6 2/2] drivers/ufs/core/ufshcd.c:5399 ufshcd_uic_cmd_compl() error: we previously assumed 'cmd' could be null (see line 5389)
kernel test robot <[email protected]>
| Newsgroups | dev.linux.lists.oe-kbuild |
|---|---|
| Message-ID | <[email protected]> |
BCC: [email protected] CC: [email protected] TO: [email protected] tree: https://android.googlesource.com/kernel/common android15-6.6 head: 24c059d9e217f32d61570fdbd7eb66bc999657a9 commit: 4c0eff913df7b0583209fdaff1b33ff8c913dbaa [2/2] FROMLIST: scsi: ufs: core: Make ufshcd_uic_cmd_compl() easier to read :::::: branch date: 33 hours ago :::::: commit date: 2 years ago config: i386-randconfig-141-20260816 (https://download.01.org/0day-ci/archive/20260816/[email protected]/config) compiler: clang version 22.1.3 (https://github.com/llvm/llvm-project e9846648fd6183ee6d8cbdb4502213fcf902a211) smatch: v0.5.0-9187-g5189e3fb If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <[email protected]> | Reported-by: Dan Carpenter <[email protected]> | Closes: https://lore.kernel.org/r/[email protected]/ New smatch warnings: drivers/ufs/core/ufshcd.c:5399 ufshcd_uic_cmd_compl() error: we previously assumed 'cmd' could be null (see line 5389) Old smatch warnings: drivers/ufs/core/ufshcd.c:9203 ufshcd_setup_clocks() warn: 'clki->clk' from clk_prepare_enable() not released on lines: 9183. vim +/cmd +5399 drivers/ufs/core/ufshcd.c a45f937110fa6b0 drivers/scsi/ufs/ufshcd.c Can Guo 2021-05-24 5369 6ccf44fe4cd7c45 drivers/scsi/ufs/ufshcd.c Seungwon Jeon 2013-06-26 5370 /** 6ccf44fe4cd7c45 drivers/scsi/ufs/ufshcd.c Seungwon Jeon 2013-06-26 5371 * ufshcd_uic_cmd_compl - handle completion of uic command 6ccf44fe4cd7c45 drivers/scsi/ufs/ufshcd.c Seungwon Jeon 2013-06-26 5372 * @hba: per adapter instance 53b3d9c3fdda94d drivers/scsi/ufs/ufshcd.c Seungwon Jeon 2013-08-31 5373 * @intr_status: interrupt status generated by the controller 9333d77573485c8 drivers/scsi/ufs/ufshcd.c Venkat Gopalakrishnan 2019-11-14 5374 * 3a17fefe0f1960d drivers/ufs/core/ufshcd.c Bart Van Assche 2023-07-27 5375 * Return: 9333d77573485c8 drivers/scsi/ufs/ufshcd.c Venkat Gopalakrishnan 2019-11-14 5376 * IRQ_HANDLED - If interrupt is valid 9333d77573485c8 drivers/scsi/ufs/ufshcd.c Venkat Gopalakrishnan 2019-11-14 5377 * IRQ_NONE - If invalid interrupt 6ccf44fe4cd7c45 drivers/scsi/ufs/ufshcd.c Seungwon Jeon 2013-06-26 5378 */ 9333d77573485c8 drivers/scsi/ufs/ufshcd.c Venkat Gopalakrishnan 2019-11-14 5379 static irqreturn_t ufshcd_uic_cmd_compl(struct ufs_hba *hba, u32 intr_status) 6ccf44fe4cd7c45 drivers/scsi/ufs/ufshcd.c Seungwon Jeon 2013-06-26 5380 { 9333d77573485c8 drivers/scsi/ufs/ufshcd.c Venkat Gopalakrishnan 2019-11-14 5381 irqreturn_t retval = IRQ_NONE; 4c0eff913df7b05 drivers/ufs/core/ufshcd.c Bart Van Assche 2024-08-21 5382 struct uic_command *cmd; 9333d77573485c8 drivers/scsi/ufs/ufshcd.c Venkat Gopalakrishnan 2019-11-14 5383 a45f937110fa6b0 drivers/scsi/ufs/ufshcd.c Can Guo 2021-05-24 5384 spin_lock(hba->host->host_lock); 4c0eff913df7b05 drivers/ufs/core/ufshcd.c Bart Van Assche 2024-08-21 5385 cmd = hba->active_uic_cmd; a45f937110fa6b0 drivers/scsi/ufs/ufshcd.c Can Guo 2021-05-24 5386 if (ufshcd_is_auto_hibern8_error(hba, intr_status)) a45f937110fa6b0 drivers/scsi/ufs/ufshcd.c Can Guo 2021-05-24 5387 hba->errors |= (UFSHCD_UIC_HIBERN8_MASK & intr_status); a45f937110fa6b0 drivers/scsi/ufs/ufshcd.c Can Guo 2021-05-24 5388 4c0eff913df7b05 drivers/ufs/core/ufshcd.c Bart Van Assche 2024-08-21 @5389 if (intr_status & UIC_COMMAND_COMPL && cmd) { 4c0eff913df7b05 drivers/ufs/core/ufshcd.c Bart Van Assche 2024-08-21 5390 cmd->argument2 |= ufshcd_get_uic_cmd_result(hba); 4c0eff913df7b05 drivers/ufs/core/ufshcd.c Bart Van Assche 2024-08-21 5391 cmd->argument3 = ufshcd_get_dme_attr_val(hba); 0f52fcb99ea2738 drivers/scsi/ufs/ufshcd.c Can Guo 2020-11-02 5392 if (!hba->uic_async_done) 4c0eff913df7b05 drivers/ufs/core/ufshcd.c Bart Van Assche 2024-08-21 5393 cmd->cmd_active = 0; 4c0eff913df7b05 drivers/ufs/core/ufshcd.c Bart Van Assche 2024-08-21 5394 complete(&cmd->done); 9333d77573485c8 drivers/scsi/ufs/ufshcd.c Venkat Gopalakrishnan 2019-11-14 5395 retval = IRQ_HANDLED; 6ccf44fe4cd7c45 drivers/scsi/ufs/ufshcd.c Seungwon Jeon 2013-06-26 5396 } 53b3d9c3fdda94d drivers/scsi/ufs/ufshcd.c Seungwon Jeon 2013-08-31 5397 4c0eff913df7b05 drivers/ufs/core/ufshcd.c Bart Van Assche 2024-08-21 5398 if (intr_status & UFSHCD_UIC_PWR_MASK && hba->uic_async_done) { 4c0eff913df7b05 drivers/ufs/core/ufshcd.c Bart Van Assche 2024-08-21 @5399 cmd->cmd_active = 0; 57d104c153d3d6d drivers/scsi/ufs/ufshcd.c Subhash Jadavani 2014-09-25 5400 complete(hba->uic_async_done); 9333d77573485c8 drivers/scsi/ufs/ufshcd.c Venkat Gopalakrishnan 2019-11-14 5401 retval = IRQ_HANDLED; 9333d77573485c8 drivers/scsi/ufs/ufshcd.c Venkat Gopalakrishnan 2019-11-14 5402 } aa5c697988b4c7e drivers/scsi/ufs/ufshcd.c Stanley Chu 2020-06-15 5403 aa5c697988b4c7e drivers/scsi/ufs/ufshcd.c Stanley Chu 2020-06-15 5404 if (retval == IRQ_HANDLED) 4c0eff913df7b05 drivers/ufs/core/ufshcd.c Bart Van Assche 2024-08-21 5405 ufshcd_add_uic_command_trace(hba, cmd, UFS_CMD_COMP); a45f937110fa6b0 drivers/scsi/ufs/ufshcd.c Can Guo 2021-05-24 5406 spin_unlock(hba->host->host_lock); 9333d77573485c8 drivers/scsi/ufs/ufshcd.c Venkat Gopalakrishnan 2019-11-14 5407 return retval; 6ccf44fe4cd7c45 drivers/scsi/ufs/ufshcd.c Seungwon Jeon 2013-06-26 5408 } 6ccf44fe4cd7c45 drivers/scsi/ufs/ufshcd.c Seungwon Jeon 2013-06-26 5409 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki