drivers/gpu/drm/i915/display/intel_plane.c:687 intel_plane_atomic_check_with_state() error: we previously assumed 'fb' could be null (see line 675)
kernel test robot <[email protected]>
| Newsgroups | dev.linux.lists.oe-kbuild |
|---|---|
| Message-ID | <[email protected]> |
BCC: [email protected] CC: [email protected] CC: [email protected] TO: Jani Nikula <[email protected]> CC: Gustavo Sousa <[email protected]> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: cb8a75eec0877810b50aa1c5a833f929525cd2ee commit: a649c2abfae0c68d07f127ff4e570c44636afe7e drm/i915/plane: rename intel_atomic_plane.[ch] to intel_plane.[ch] date: 1 year, 2 months ago :::::: branch date: 6 hours ago :::::: commit date: 1 year, 2 months ago config: x86_64-randconfig-161-20260820 (https://download.01.org/0day-ci/archive/20260820/[email protected]/config) compiler: gcc-14 (Debian 14.2.0-19) 14.2.0 smatch: v0.5.0-9187-g5189e3fb If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Fixes: a649c2abfae0 ("drm/i915/plane: rename intel_atomic_plane.[ch] to intel_plane.[ch]") | Reported-by: kernel test robot <[email protected]> | Reported-by: Dan Carpenter <[email protected]> | Closes: https://lore.kernel.org/r/[email protected]/ smatch warnings: drivers/gpu/drm/i915/display/intel_plane.c:687 intel_plane_atomic_check_with_state() error: we previously assumed 'fb' could be null (see line 675) vim +/fb +687 drivers/gpu/drm/i915/display/intel_plane.c c17897428e1d25 drivers/gpu/drm/i915/display/intel_atomic_plane.c Ville Syrjälä 2022-02-11 655 b2b55502d683c7 drivers/gpu/drm/i915/intel_atomic_plane.c Ville Syrjälä 2017-08-23 656 int intel_plane_atomic_check_with_state(const struct intel_crtc_state *old_crtc_state, 790cc9941b137e drivers/gpu/drm/i915/intel_atomic_plane.c Ville Syrjälä 2019-01-11 657 struct intel_crtc_state *new_crtc_state, b2b55502d683c7 drivers/gpu/drm/i915/intel_atomic_plane.c Ville Syrjälä 2017-08-23 658 const struct intel_plane_state *old_plane_state, 790cc9941b137e drivers/gpu/drm/i915/intel_atomic_plane.c Ville Syrjälä 2019-01-11 659 struct intel_plane_state *new_plane_state) ea2c67bb4affa8 drivers/gpu/drm/i915/intel_atomic_plane.c Matt Roper 2014-12-23 660 { f90a85e76c2a89 drivers/gpu/drm/i915/display/intel_atomic_plane.c Maarten Lankhorst 2019-10-31 661 struct intel_plane *plane = to_intel_plane(new_plane_state->uapi.plane); 7d8d2cbce5af5e drivers/gpu/drm/i915/display/intel_atomic_plane.c Ville Syrjälä 2020-01-10 662 const struct drm_framebuffer *fb = new_plane_state->hw.fb; da20eabd2c6976 drivers/gpu/drm/i915/intel_atomic_plane.c Maarten Lankhorst 2015-06-15 663 int ret; ea2c67bb4affa8 drivers/gpu/drm/i915/intel_atomic_plane.c Matt Roper 2014-12-23 664 cb1824bb1ec6b4 drivers/gpu/drm/i915/display/intel_atomic_plane.c Ville Syrjälä 2020-03-18 665 intel_plane_set_invisible(new_crtc_state, new_plane_state); ee42ec19ca2e55 drivers/gpu/drm/i915/display/intel_atomic_plane.c Ville Syrjälä 2020-11-24 666 new_crtc_state->enabled_planes &= ~BIT(plane->id); 62ef0dd3cc0c21 drivers/gpu/drm/i915/intel_atomic_plane.c Maarten Lankhorst 2018-09-20 667 7b3cb17a48dc1b drivers/gpu/drm/i915/display/intel_atomic_plane.c Maarten Lankhorst 2019-10-31 668 if (!new_plane_state->hw.crtc && !old_plane_state->hw.crtc) c196e1d66c36b0 drivers/gpu/drm/i915/intel_atomic_plane.c Matt Roper 2015-01-21 669 return 0; c196e1d66c36b0 drivers/gpu/drm/i915/intel_atomic_plane.c Matt Roper 2015-01-21 670 790cc9941b137e drivers/gpu/drm/i915/intel_atomic_plane.c Ville Syrjälä 2019-01-11 671 ret = plane->check_plane(new_crtc_state, new_plane_state); c389c9c4d981e4 drivers/gpu/drm/i915/intel_atomic_plane.c Maarten Lankhorst 2015-06-15 672 if (ret) da20eabd2c6976 drivers/gpu/drm/i915/intel_atomic_plane.c Maarten Lankhorst 2015-06-15 673 return ret; da20eabd2c6976 drivers/gpu/drm/i915/intel_atomic_plane.c Maarten Lankhorst 2015-06-15 674 97bc7ffa1b1e9a drivers/gpu/drm/i915/display/intel_atomic_plane.c Ville Syrjälä 2021-03-05 @675 if (fb) 97bc7ffa1b1e9a drivers/gpu/drm/i915/display/intel_atomic_plane.c Ville Syrjälä 2021-03-05 676 new_crtc_state->enabled_planes |= BIT(plane->id); 97bc7ffa1b1e9a drivers/gpu/drm/i915/display/intel_atomic_plane.c Ville Syrjälä 2021-03-05 677 e9728bd888e1fa drivers/gpu/drm/i915/intel_atomic_plane.c Ville Syrjälä 2017-03-02 678 /* FIXME pre-g4x don't work like this */ f90a85e76c2a89 drivers/gpu/drm/i915/display/intel_atomic_plane.c Maarten Lankhorst 2019-10-31 679 if (new_plane_state->uapi.visible) 790cc9941b137e drivers/gpu/drm/i915/intel_atomic_plane.c Ville Syrjälä 2019-01-11 680 new_crtc_state->active_planes |= BIT(plane->id); e9728bd888e1fa drivers/gpu/drm/i915/intel_atomic_plane.c Ville Syrjälä 2017-03-02 681 3358e2ca0ebd64 drivers/gpu/drm/i915/display/intel_atomic_plane.c Ville Syrjälä 2022-02-11 682 if (new_plane_state->uapi.visible && 3358e2ca0ebd64 drivers/gpu/drm/i915/display/intel_atomic_plane.c Ville Syrjälä 2022-02-11 683 intel_plane_is_scaled(new_plane_state)) 3358e2ca0ebd64 drivers/gpu/drm/i915/display/intel_atomic_plane.c Ville Syrjälä 2022-02-11 684 new_crtc_state->scaled_planes |= BIT(plane->id); 3358e2ca0ebd64 drivers/gpu/drm/i915/display/intel_atomic_plane.c Ville Syrjälä 2022-02-11 685 f90a85e76c2a89 drivers/gpu/drm/i915/display/intel_atomic_plane.c Maarten Lankhorst 2019-10-31 686 if (new_plane_state->uapi.visible && 4941f35b48f7f3 drivers/gpu/drm/i915/display/intel_atomic_plane.c Imre Deak 2019-12-21 @687 intel_format_info_is_yuv_semiplanar(fb->format, fb->modifier)) 790cc9941b137e drivers/gpu/drm/i915/intel_atomic_plane.c Ville Syrjälä 2019-01-11 688 new_crtc_state->nv12_planes |= BIT(plane->id); 8e021151948c56 drivers/gpu/drm/i915/intel_atomic_plane.c Maarten Lankhorst 2018-05-12 689 f90a85e76c2a89 drivers/gpu/drm/i915/display/intel_atomic_plane.c Maarten Lankhorst 2019-10-31 690 if (new_plane_state->uapi.visible && d1d23d7f4be6a6 drivers/gpu/drm/i915/display/intel_atomic_plane.c Ville Syrjälä 2019-09-13 691 fb->format->format == DRM_FORMAT_C8) 02c52f1ed20aba drivers/gpu/drm/i915/intel_atomic_plane.c Ville Syrjälä 2019-02-07 692 new_crtc_state->c8_planes |= BIT(plane->id); 02c52f1ed20aba drivers/gpu/drm/i915/intel_atomic_plane.c Ville Syrjälä 2019-02-07 693 f90a85e76c2a89 drivers/gpu/drm/i915/display/intel_atomic_plane.c Maarten Lankhorst 2019-10-31 694 if (new_plane_state->uapi.visible || old_plane_state->uapi.visible) 790cc9941b137e drivers/gpu/drm/i915/intel_atomic_plane.c Ville Syrjälä 2019-01-11 695 new_crtc_state->update_planes |= BIT(plane->id); afbd8a722bd64e drivers/gpu/drm/i915/intel_atomic_plane.c Ville Syrjälä 2018-11-27 696 943ed3cc02191b drivers/gpu/drm/i915/display/intel_atomic_plane.c Ville Syrjälä 2022-03-03 697 if (new_plane_state->uapi.visible && 943ed3cc02191b drivers/gpu/drm/i915/display/intel_atomic_plane.c Ville Syrjälä 2022-03-03 698 intel_format_info_is_yuv_semiplanar(fb->format, fb->modifier)) { 943ed3cc02191b drivers/gpu/drm/i915/display/intel_atomic_plane.c Ville Syrjälä 2022-03-03 699 new_crtc_state->data_rate_y[plane->id] = 943ed3cc02191b drivers/gpu/drm/i915/display/intel_atomic_plane.c Ville Syrjälä 2022-03-03 700 intel_plane_data_rate(new_crtc_state, new_plane_state, 0); c457d9cf256e94 drivers/gpu/drm/i915/intel_atomic_plane.c Ville Syrjälä 2019-05-24 701 new_crtc_state->data_rate[plane->id] = 943ed3cc02191b drivers/gpu/drm/i915/display/intel_atomic_plane.c Ville Syrjälä 2022-03-03 702 intel_plane_data_rate(new_crtc_state, new_plane_state, 1); c034363ca898ea drivers/gpu/drm/i915/display/intel_atomic_plane.c Ville Syrjälä 2022-03-03 703 c034363ca898ea drivers/gpu/drm/i915/display/intel_atomic_plane.c Ville Syrjälä 2022-03-03 704 new_crtc_state->rel_data_rate_y[plane->id] = c034363ca898ea drivers/gpu/drm/i915/display/intel_atomic_plane.c Ville Syrjälä 2022-03-03 705 intel_plane_relative_data_rate(new_crtc_state, c034363ca898ea drivers/gpu/drm/i915/display/intel_atomic_plane.c Ville Syrjälä 2022-03-03 706 new_plane_state, 0); c034363ca898ea drivers/gpu/drm/i915/display/intel_atomic_plane.c Ville Syrjälä 2022-03-03 707 new_crtc_state->rel_data_rate[plane->id] = c034363ca898ea drivers/gpu/drm/i915/display/intel_atomic_plane.c Ville Syrjälä 2022-03-03 708 intel_plane_relative_data_rate(new_crtc_state, c034363ca898ea drivers/gpu/drm/i915/display/intel_atomic_plane.c Ville Syrjälä 2022-03-03 709 new_plane_state, 1); 943ed3cc02191b drivers/gpu/drm/i915/display/intel_atomic_plane.c Ville Syrjälä 2022-03-03 710 } else if (new_plane_state->uapi.visible) { 943ed3cc02191b drivers/gpu/drm/i915/display/intel_atomic_plane.c Ville Syrjälä 2022-03-03 711 new_crtc_state->data_rate[plane->id] = 943ed3cc02191b drivers/gpu/drm/i915/display/intel_atomic_plane.c Ville Syrjälä 2022-03-03 712 intel_plane_data_rate(new_crtc_state, new_plane_state, 0); c034363ca898ea drivers/gpu/drm/i915/display/intel_atomic_plane.c Ville Syrjälä 2022-03-03 713 c034363ca898ea drivers/gpu/drm/i915/display/intel_atomic_plane.c Ville Syrjälä 2022-03-03 714 new_crtc_state->rel_data_rate[plane->id] = c034363ca898ea drivers/gpu/drm/i915/display/intel_atomic_plane.c Ville Syrjälä 2022-03-03 715 intel_plane_relative_data_rate(new_crtc_state, c034363ca898ea drivers/gpu/drm/i915/display/intel_atomic_plane.c Ville Syrjälä 2022-03-03 716 new_plane_state, 0); 943ed3cc02191b drivers/gpu/drm/i915/display/intel_atomic_plane.c Ville Syrjälä 2022-03-03 717 } c457d9cf256e94 drivers/gpu/drm/i915/intel_atomic_plane.c Ville Syrjälä 2019-05-24 718 4f25720b2c04a3 drivers/gpu/drm/i915/display/intel_atomic_plane.c Maarten Lankhorst 2019-06-28 719 return intel_plane_atomic_calc_changes(old_crtc_state, new_crtc_state, 4f25720b2c04a3 drivers/gpu/drm/i915/display/intel_atomic_plane.c Maarten Lankhorst 2019-06-28 720 old_plane_state, new_plane_state); 4f25720b2c04a3 drivers/gpu/drm/i915/display/intel_atomic_plane.c Maarten Lankhorst 2019-06-28 721 } 4f25720b2c04a3 drivers/gpu/drm/i915/display/intel_atomic_plane.c Maarten Lankhorst 2019-06-28 722 :::::: The code at line 687 was first introduced by commit :::::: 4941f35b48f7f329bdf2ccad17d6fdb2190f8d34 drm/i915: Make sure CCS YUV semiplanar format checks work :::::: TO: Imre Deak <[email protected]> :::::: CC: Imre Deak <[email protected]> -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki