Re: [PATCH net] net: amd-xgbe: support receiving packets with bad FCS

kernel test robot <[email protected]>
Newsgroups dev.linux.lists.oe-kbuild
Message-ID <[email protected]> 
:::::: 
:::::: Manual check reason: "linux-review patch is more than 7 days old, verify it wasn't already superseded"
:::::: 

BCC: [email protected]
CC: [email protected]
In-Reply-To: <[email protected]>
References: <[email protected]>
TO: James <[email protected]>
TO: Raju Rangoju <[email protected]>
TO: Prashanth Kumar K R <[email protected]>
CC: [email protected]
CC: [email protected]
CC: James Nugraha <[email protected]>

Hi James,

kernel test robot noticed the following build warnings:

[auto build test WARNING on net/main]

url:    https://github.com/intel-lab-lkp/linux/commits/James/net-amd-xgbe-support-receiving-packets-with-bad-FCS/20260812-091616
base:   net/main
patch link:    https://lore.kernel.org/r/20260812091616.35811-1-aslan.jnn%40gmail.com
patch subject: [PATCH net] net: amd-xgbe: support receiving packets with bad FCS
:::::: branch date: 16 hours ago
:::::: commit date: 16 hours ago
config: powerpc-randconfig-r123-20260821 (https://download.01.org/0day-ci/archive/20260822/[email protected]/config)
compiler: clang version 24.0.0git (https://github.com/llvm/llvm-project 935bfc708590c60147a79c7df145bb6e68b1d388)
sparse: v0.6.5-rc1
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260822/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/r/[email protected]/

sparse warnings: (new ones prefixed by >>)
>> drivers/net/ethernet/amd/xgbe/xgbe-drv.c:2022:17: sparse: sparse: dubious: !x & y
   drivers/net/ethernet/amd/xgbe/xgbe-drv.c: note: in included file (through include/linux/tcp.h):
   include/linux/skbuff.h:2904:28: sparse: sparse: unsigned value that used to be signed checked against zero?
   include/linux/skbuff.h:2904:28: sparse: signed value source
--
>> drivers/net/ethernet/amd/xgbe/xgbe-dev.c:3403:9: sparse: sparse: dubious: !x & y

vim +2022 drivers/net/ethernet/amd/xgbe/xgbe-drv.c

1a510ccf5869a9 Lendacky, Thomas 2017-08-18  1977  
c5aa9e3b815645 Lendacky, Thomas 2014-06-05  1978  static int xgbe_set_features(struct net_device *netdev,
c5aa9e3b815645 Lendacky, Thomas 2014-06-05  1979  			     netdev_features_t features)
c5aa9e3b815645 Lendacky, Thomas 2014-06-05  1980  {
c5aa9e3b815645 Lendacky, Thomas 2014-06-05  1981  	struct xgbe_prv_data *pdata = netdev_priv(netdev);
c5aa9e3b815645 Lendacky, Thomas 2014-06-05  1982  	struct xgbe_hw_if *hw_if = &pdata->hw_if;
5a1edf2f430d12 James Nugraha    2026-08-12  1983  	netdev_features_t rxhash, rxcsum, rxvlan, rxvlan_filter, rxall;
5b9dfe299e5560 Lendacky, Thomas 2014-11-04  1984  	int ret = 0;
c5aa9e3b815645 Lendacky, Thomas 2014-06-05  1985  
5b9dfe299e5560 Lendacky, Thomas 2014-11-04  1986  	rxhash = pdata->netdev_features & NETIF_F_RXHASH;
801c62d945c612 Lendacky, Thomas 2014-06-24  1987  	rxcsum = pdata->netdev_features & NETIF_F_RXCSUM;
801c62d945c612 Lendacky, Thomas 2014-06-24  1988  	rxvlan = pdata->netdev_features & NETIF_F_HW_VLAN_CTAG_RX;
801c62d945c612 Lendacky, Thomas 2014-06-24  1989  	rxvlan_filter = pdata->netdev_features & NETIF_F_HW_VLAN_CTAG_FILTER;
5a1edf2f430d12 James Nugraha    2026-08-12  1990  	rxall = pdata->netdev_features & NETIF_F_RXALL;
c5aa9e3b815645 Lendacky, Thomas 2014-06-05  1991  
5b9dfe299e5560 Lendacky, Thomas 2014-11-04  1992  	if ((features & NETIF_F_RXHASH) && !rxhash)
5b9dfe299e5560 Lendacky, Thomas 2014-11-04  1993  		ret = hw_if->enable_rss(pdata);
5b9dfe299e5560 Lendacky, Thomas 2014-11-04  1994  	else if (!(features & NETIF_F_RXHASH) && rxhash)
5b9dfe299e5560 Lendacky, Thomas 2014-11-04  1995  		ret = hw_if->disable_rss(pdata);
5b9dfe299e5560 Lendacky, Thomas 2014-11-04  1996  	if (ret)
5b9dfe299e5560 Lendacky, Thomas 2014-11-04  1997  		return ret;
5b9dfe299e5560 Lendacky, Thomas 2014-11-04  1998  
f04dd30f1bef1e Vishal Badole    2025-04-24  1999  	if ((features & NETIF_F_RXCSUM) && !rxcsum) {
f04dd30f1bef1e Vishal Badole    2025-04-24  2000  		hw_if->enable_sph(pdata);
f04dd30f1bef1e Vishal Badole    2025-04-24  2001  		hw_if->enable_vxlan(pdata);
c5aa9e3b815645 Lendacky, Thomas 2014-06-05  2002  		hw_if->enable_rx_csum(pdata);
f04dd30f1bef1e Vishal Badole    2025-04-24  2003  		schedule_work(&pdata->restart_work);
f04dd30f1bef1e Vishal Badole    2025-04-24  2004  	} else if (!(features & NETIF_F_RXCSUM) && rxcsum) {
f04dd30f1bef1e Vishal Badole    2025-04-24  2005  		hw_if->disable_sph(pdata);
f04dd30f1bef1e Vishal Badole    2025-04-24  2006  		hw_if->disable_vxlan(pdata);
c5aa9e3b815645 Lendacky, Thomas 2014-06-05  2007  		hw_if->disable_rx_csum(pdata);
f04dd30f1bef1e Vishal Badole    2025-04-24  2008  		schedule_work(&pdata->restart_work);
f04dd30f1bef1e Vishal Badole    2025-04-24  2009  	}
c5aa9e3b815645 Lendacky, Thomas 2014-06-05  2010  
801c62d945c612 Lendacky, Thomas 2014-06-24  2011  	if ((features & NETIF_F_HW_VLAN_CTAG_RX) && !rxvlan)
c5aa9e3b815645 Lendacky, Thomas 2014-06-05  2012  		hw_if->enable_rx_vlan_stripping(pdata);
801c62d945c612 Lendacky, Thomas 2014-06-24  2013  	else if (!(features & NETIF_F_HW_VLAN_CTAG_RX) && rxvlan)
c5aa9e3b815645 Lendacky, Thomas 2014-06-05  2014  		hw_if->disable_rx_vlan_stripping(pdata);
801c62d945c612 Lendacky, Thomas 2014-06-24  2015  
801c62d945c612 Lendacky, Thomas 2014-06-24  2016  	if ((features & NETIF_F_HW_VLAN_CTAG_FILTER) && !rxvlan_filter)
801c62d945c612 Lendacky, Thomas 2014-06-24  2017  		hw_if->enable_rx_vlan_filtering(pdata);
801c62d945c612 Lendacky, Thomas 2014-06-24  2018  	else if (!(features & NETIF_F_HW_VLAN_CTAG_FILTER) && rxvlan_filter)
801c62d945c612 Lendacky, Thomas 2014-06-24  2019  		hw_if->disable_rx_vlan_filtering(pdata);
c5aa9e3b815645 Lendacky, Thomas 2014-06-05  2020  
5a1edf2f430d12 James Nugraha    2026-08-12  2021  	if ((features & NETIF_F_RXALL) != rxall)
5a1edf2f430d12 James Nugraha    2026-08-12 @2022  		XGMAC_IOWRITE_BITS(pdata, MAC_RCR, DCRCC,
5a1edf2f430d12 James Nugraha    2026-08-12  2023  				   !!(features & NETIF_F_RXALL));
5a1edf2f430d12 James Nugraha    2026-08-12  2024  
c5aa9e3b815645 Lendacky, Thomas 2014-06-05  2025  	pdata->netdev_features = features;
c5aa9e3b815645 Lendacky, Thomas 2014-06-05  2026  
c5aa9e3b815645 Lendacky, Thomas 2014-06-05  2027  	DBGPR("<--xgbe_set_features\n");
c5aa9e3b815645 Lendacky, Thomas 2014-06-05  2028  
c5aa9e3b815645 Lendacky, Thomas 2014-06-05  2029  	return 0;
c5aa9e3b815645 Lendacky, Thomas 2014-06-05  2030  }
c5aa9e3b815645 Lendacky, Thomas 2014-06-05  2031  

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.