Re: [PATCH v5 6/6] arm64: dts: qcom: milos-fairphone-fp6: Add NFC

On 8/12/26 12:01 AM, Jorijn van der Graaf wrote:
> Add the Samsung S3NRN4V NCI NFC controller on i2c1. Its XI clock comes
> from the PMK7635 CLK7_LN buffer (RPMH_LN_BB_CLK2), and the reference is
> load-bearing: with no clocks reference at all the chip polls but never
> activates a tag, while a held rpmh clock vote lets it read (verified on
> hardware).

hw generally works better when plugged in!

> PVDD is fed from PM7550 LDO20, the rail the downstream driver switches
> for this chip.
> 
> The enable line is routed to the chip's power-down input. The driver
> drives its "en" descriptor to logical 1 to hold the chip powered down,
> and on this board the chip is off while the pin is physically high, so
> the line is GPIO_ACTIVE_HIGH. The pin is pulled up so the chip stays
> off while the line is not driven.
> 
> Assisted-by: Claude:claude-opus-4-8
> Assisted-by: Claude:claude-fable-5
> Signed-off-by: Jorijn van der Graaf <[email protected]>
> ---

Reviewed-by: Konrad Dybcio <[email protected]>

Konrad