Re: [PATCH 1/3] dt-bindings: net: nfc: add st,st21nfcd-i2c
David Heidelberg <[email protected]>
| Newsgroups | dev.linux.lists.oe-linux-nfc,org.kernel.vger.linux-arm-msm,org.kernel.vger.netdev |
|---|---|
| Message-ID | <[email protected]> |
On 18/08/2026 22:59, Kristian Brox wrote: > The ST21NFCD (e.g. Fairphone 5) speaks raw NCI on I2C. Existing > st,st21nfcb-* and st,st21nfcc-i2c compatibles stay NDLC. Add a > separate compatible so those boards are not switched to the wrong > framing. > > Also document the difference and add an I2C example without > ese-present / uicc-present. > > Signed-off-by: Kristian Brox <[email protected]> > --- > diff --git a/Documentation/devicetree/bindings/net/nfc/st,st-nci.yaml b/Documentation/devicetree/bindings/net/nfc/st,st-nci.yaml > index 1dcbddbc5..3523a8df0 100644 > --- a/Documentation/devicetree/bindings/net/nfc/st,st-nci.yaml > +++ b/Documentation/devicetree/bindings/net/nfc/st,st-nci.yaml > @@ -11,10 +11,14 @@ maintainers: > > properties: > compatible: > + description: | > + st,st21nfcb-* and st,st21nfcc-i2c use NDLC on the wire. > + st,st21nfcd-i2c is ST21NFCD with raw NCI (no NDLC PCB). > enum: > - st,st21nfcb-i2c > - st,st21nfcb-spi > - st,st21nfcc-i2c > + - st,st21nfcd-i2c Hello Kristian. Thank you for your patches! Before I do full review, for next revision, definitely the compatible should omit -i2c suffix, thus only `st,st21nfcd`. If possible, send next revision with b4 (thou you don't have to, it's usually more fancy and convenient for both parties, takes care about CCing the right people, checkpatch etc.) [1]. Thanks David [1] https://b4.docs.kernel.org/en/latest/contributor/overview.html [...]