Re: [PATCH] nfc: nfcmrvl: spi: Fix irq_of_parse_and_map() return value
Krzysztof Kozlowski <[email protected]>
| Newsgroups | dev.linux.lists.oe-linux-nfc,org.01.lists.linux-nfc,org.kernel.vger.linux-kernel,org.kernel.vger.netdev |
|---|---|
| Message-ID | <[email protected]> |
On 23/04/2022 01:13, Jakub Kicinski wrote:
> On Fri, 22 Apr 2022 12:47:58 +0200 Krzysztof Kozlowski wrote:
>> The irq_of_parse_and_map() returns 0 on failure, not a negative ERRNO.
>>
>> Fixes: caf6e49bf6d0 ("NFC: nfcmrvl: add spi driver")
>> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>> ---
>> This is another issue to https://lore.kernel.org/all/20220422084605.2775542-1-lv.ruyi(a)zte.com.cn/
>
> Maybe send one patch that fixes both and also fixes the usage of ret?
Bah, I just blindly copied one part of his patch without deeper check.
Thanks for noticing it.
Best regards,
Krzysztof