Re: [PATCH] btrfs: prevent COW amplification during btrfs_search_slot
kernel test robot <[email protected]>
| Newsgroups | dev.linux.lists.oe-lkp,org.kernel.vger.linux-btrfs |
|---|---|
| Message-ID | <[email protected]> |
Hello,
kernel test robot noticed "INFO:trying_to_register_non-static_key" on:
commit: ba9c6f19149df060c2b7c71eaac21c394c161190 ("[PATCH] btrfs: prevent COW amplification during btrfs_search_slot")
url: https://github.com/intel-lab-lkp/linux/commits/Leo-Martins/btrfs-prevent-COW-amplification-during-btrfs_search_slot/20260128-044526
base: https://git.kernel.org/cgit/linux/kernel/git/kdave/linux.git for-next
patch link: https://lore.kernel.org/all/ba53d279b8bb3456f61cb8a4f15d9a4b1e618d0e.1769546089.git.loemra.dev@gmail.com/
patch subject: [PATCH] btrfs: prevent COW amplification during btrfs_search_slot
in testcase: perf-sanity-tests
version:
with following parameters:
perf_compiler: gcc
group: group-01
config: x86_64-rhel-9.4-bpf
compiler: gcc-14
test machine: 8 threads 1 sockets Intel(R) Core(TM) i7-7700 CPU @ 3.60GHz (Kaby Lake) with 32G memory
(please refer to attached dmesg/kmsg for entire log/backtrace)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-lkp/[email protected]
[ 125.965833][ T4372] INFO: trying to register non-static key.
[ 125.971503][ T4372] The code is fine but needs lockdep annotation, or maybe
[ 125.978465][ T4372] you didn't initialize this object before use?
[ 125.984560][ T4372] turning off the locking correctness validator.
[ 125.990745][ T4372] CPU: 3 UID: 0 PID: 4372 Comm: mount Tainted: G S I 6.19.0-rc7-00122-gba9c6f19149d #1 PREEMPT(full)
[ 125.990755][ T4372] Tainted: [S]=CPU_OUT_OF_SPEC, [I]=FIRMWARE_WORKAROUND
[ 125.990758][ T4372] Hardware name: Dell Inc. OptiPlex 7050/062KRH, BIOS 1.2.0 12/22/2016
[ 125.990761][ T4372] Call Trace:
[ 125.990764][ T4372] <TASK>
[ 125.990767][ T4372] dump_stack_lvl (lib/dump_stack.c:122)
[ 125.990777][ T4372] register_lock_class (kernel/locking/lockdep.c:985 kernel/locking/lockdep.c:1299)
[ 125.990784][ T4372] ? lock_release (kernel/locking/lockdep.c:470 (discriminator 4) kernel/locking/lockdep.c:5891 (discriminator 4) kernel/locking/lockdep.c:5875 (discriminator 4))
[ 125.990790][ T4372] ? __rcu_read_unlock (kernel/rcu/tree_plugin.h:441 (discriminator 1))
[ 125.990799][ T4372] __lock_acquire (kernel/locking/lockdep.c:5113)
[ 125.990809][ T4372] lock_acquire (include/linux/preempt.h:469 (discriminator 2) include/trace/events/lock.h:24 (discriminator 2) include/trace/events/lock.h:24 (discriminator 2) kernel/locking/lockdep.c:5831 (discriminator 2))
[ 125.990815][ T4372] ? xa_destroy (lib/xarray.c:2390 (discriminator 1))
[ 125.990823][ T4372] ? xa_find (include/linux/rcupdate.h:341 include/linux/rcupdate.h:897 lib/xarray.c:2202)
[ 125.990830][ T4372] ? rcu_is_watching (arch/x86/include/asm/atomic.h:23 include/linux/atomic/atomic-arch-fallback.h:457 include/linux/context_tracking.h:128 kernel/rcu/tree.c:751)
[ 125.990836][ T4372] ? lock_acquire (include/trace/events/lock.h:24 (discriminator 2) kernel/locking/lockdep.c:5831 (discriminator 2))
[ 125.990844][ T4372] _raw_spin_lock_irqsave (include/linux/spinlock_api_smp.h:111 kernel/locking/spinlock.c:162)
[ 125.990851][ T4372] ? xa_destroy (lib/xarray.c:2390 (discriminator 1))
[ 125.990858][ T4372] xa_destroy (lib/xarray.c:2390 (discriminator 1))
[ 125.990865][ T4372] ? xa_find (lib/xarray.c:2204)
[ 125.990872][ T4372] ? __pfx_xa_destroy (lib/xarray.c:2384)
[ 125.990884][ T4372] ? unlock_up (fs/btrfs/ctree.c:1427) btrfs
[ 125.991323][ T4372] btrfs_search_slot (fs/btrfs/ctree.c:2043) btrfs
[ 125.991720][ T4372] ? rcu_is_watching (arch/x86/include/asm/atomic.h:23 include/linux/atomic/atomic-arch-fallback.h:457 include/linux/context_tracking.h:128 kernel/rcu/tree.c:751)
[ 125.991732][ T4372] ? __pfx_btrfs_search_slot (fs/btrfs/ctree.c:2043) btrfs
[ 125.992150][ T4372] ? lockdep_hardirqs_on_prepare (kernel/locking/lockdep.c:4629 (discriminator 4))
[ 125.992158][ T4372] ? ___slab_alloc (arch/x86/include/asm/irqflags.h:42 arch/x86/include/asm/irqflags.h:119 arch/x86/include/asm/irqflags.h:159 mm/slub.c:4555)
[ 125.992166][ T4372] ? __pfx___mutex_lock (kernel/locking/mutex.c:775)
[ 125.992173][ T4372] ? trace_preempt_on (include/trace/events/preemptirq.h:53 (discriminator 2) kernel/trace/trace_preemptirq.c:120 (discriminator 2))
[ 125.992184][ T4372] ? kmem_cache_alloc_noprof (include/trace/events/kmem.h:12 (discriminator 2) mm/slub.c:5273 (discriminator 2))
[ 125.992191][ T4372] ? btrfs_read_chunk_tree (fs/btrfs/volumes.c:7639) btrfs
[ 125.992599][ T4372] btrfs_read_chunk_tree (fs/btrfs/volumes.c:7680) btrfs
[ 125.993066][ T4372] ? __pfx_btrfs_read_chunk_tree (fs/btrfs/volumes.c:7627) btrfs
[ 125.993473][ T4372] ? __pfx_load_super_root (fs/btrfs/disk-io.c:2617) btrfs
[ 125.993868][ T4372] ? __pfx_btrfs_read_sys_array (fs/btrfs/volumes.c:7494) btrfs
[ 125.994309][ T4372] ? __asan_memcpy (mm/kasan/shadow.c:105 (discriminator 1))
[ 125.994317][ T4372] ? read_extent_buffer (fs/btrfs/extent_io.c:3981) btrfs
[ 125.994743][ T4372] open_ctree (fs/btrfs/disk-io.c:3481) btrfs
[ 125.995173][ T4372] btrfs_fill_super.cold (fs/btrfs/super.c:981) btrfs
[ 125.995570][ T4372] btrfs_get_tree_super (fs/btrfs/super.c:1945) btrfs
[ 125.995959][ T4372] btrfs_get_tree_subvol (fs/btrfs/super.c:2087) btrfs
[ 125.996378][ T4372] vfs_get_tree (fs/super.c:1751)
[ 125.996387][ T4372] vfs_cmd_create (fs/fsopen.c:231)
[ 125.996394][ T4372] __do_sys_fsconfig (fs/fsopen.c:474)
[ 125.996401][ T4372] ? __pfx___do_sys_fsconfig (fs/fsopen.c:356)
[ 125.996411][ T4372] ? vfs_read (include/linux/sched/xacct.h:24 fs/read_write.c:579)
[ 125.996417][ T4372] ? do_syscall_64 (arch/x86/include/asm/irqflags.h:42 arch/x86/include/asm/irqflags.h:119 include/linux/entry-common.h:108 arch/x86/entry/syscall_64.c:90)
[ 125.996425][ T4372] do_syscall_64 (arch/x86/entry/syscall_64.c:63 (discriminator 1) arch/x86/entry/syscall_64.c:94 (discriminator 1))
[ 125.996431][ T4372] ? kasan_quarantine_put (arch/x86/include/asm/irqflags.h:42 arch/x86/include/asm/irqflags.h:119 arch/x86/include/asm/irqflags.h:159 mm/kasan/quarantine.c:234)
[ 125.996438][ T4372] ? lockdep_hardirqs_on_prepare (kernel/locking/lockdep.c:4629 (discriminator 4))
[ 125.996446][ T4372] ? kasan_quarantine_put (arch/x86/include/asm/irqflags.h:42 arch/x86/include/asm/irqflags.h:119 arch/x86/include/asm/irqflags.h:159 mm/kasan/quarantine.c:234)
[ 125.996453][ T4372] ? kfree (mm/slub.c:6674 (discriminator 3) mm/slub.c:6882 (discriminator 3))
[ 125.996459][ T4372] ? __do_sys_fsconfig (fs/fsopen.c:499)
[ 125.996467][ T4372] ? ksys_read (fs/read_write.c:715)
[ 125.996473][ T4372] ? __pfx_ksys_read (fs/read_write.c:705)
[ 125.996479][ T4372] ? __do_sys_fsconfig (fs/fsopen.c:499)
[ 125.996486][ T4372] ? __pfx___do_sys_fsconfig (fs/fsopen.c:356)
[ 125.996492][ T4372] ? do_syscall_64 (include/linux/irq-entry-common.h:298 include/linux/entry-common.h:196 arch/x86/entry/syscall_64.c:100)
[ 125.996499][ T4372] ? do_syscall_64 (arch/x86/entry/syscall_64.c:113)
[ 125.996505][ T4372] ? __pfx_css_rstat_updated (kernel/cgroup/rstat.c:71)
[ 125.996512][ T4372] ? do_syscall_64 (include/linux/irq-entry-common.h:298 include/linux/entry-common.h:196 arch/x86/entry/syscall_64.c:100)
[ 125.996520][ T4372] ? do_syscall_64 (arch/x86/entry/syscall_64.c:113)
[ 125.996525][ T4372] ? find_held_lock (kernel/locking/lockdep.c:5350 (discriminator 1))
[ 125.996531][ T4372] ? count_memcg_events_mm+0x91/0x170
[ 125.996539][ T4372] ? count_memcg_events_mm+0x91/0x170
[ 125.996545][ T4372] ? __lock_release+0x5d/0x1b0
[ 125.996553][ T4372] ? find_held_lock (kernel/locking/lockdep.c:5350 (discriminator 1))
[ 125.996559][ T4372] ? exc_page_fault (arch/x86/include/asm/irqflags.h:26 arch/x86/include/asm/irqflags.h:109 arch/x86/include/asm/irqflags.h:151 arch/x86/mm/fault.c:1480 arch/x86/mm/fault.c:1527)
[ 125.996567][ T4372] ? exc_page_fault (arch/x86/include/asm/irqflags.h:26 arch/x86/include/asm/irqflags.h:109 arch/x86/include/asm/irqflags.h:151 arch/x86/mm/fault.c:1480 arch/x86/mm/fault.c:1527)
[ 125.996573][ T4372] ? __lock_release+0x5d/0x1b0
[ 125.996578][ T4372] ? handle_mm_fault (mm/memory.c:6469 (discriminator 1) mm/memory.c:6609 (discriminator 1))
[ 125.996587][ T4372] ? lock_release (kernel/locking/lockdep.c:470 (discriminator 4) kernel/locking/lockdep.c:5891 (discriminator 4) kernel/locking/lockdep.c:5875 (discriminator 4))
[ 125.996594][ T4372] ? irqentry_exit (include/linux/irq-entry-common.h:298 include/linux/irq-entry-common.h:341 kernel/entry/common.c:196)
[ 125.996600][ T4372] ? trace_hardirqs_on_prepare (kernel/trace/trace_preemptirq.c:64 (discriminator 4) kernel/trace/trace_preemptirq.c:59 (discriminator 4))
[ 125.996605][ T4372] ? lockdep_hardirqs_on_prepare (kernel/locking/lockdep.c:4629 (discriminator 4))
[ 125.996612][ T4372] ? irqentry_exit (arch/x86/include/asm/jump_label.h:37 include/linux/context_tracking_state.h:138 include/linux/context_tracking.h:41 include/linux/irq-entry-common.h:301 include/linux/irq-entry-common.h:341 kernel/entry/common.c:196)
[ 125.996619][ T4372] entry_SYSCALL_64_after_hwframe (arch/x86/entry/entry_64.S:131)
[ 125.996625][ T4372] RIP: 0033:0x7f169cce04aa
[ 125.996652][ T4372] Code: 73 01 c3 48 8b 0d 4e 59 0d 00 f7 d8 64 89 01 48 83 c8 ff c3 66 2e 0f 1f 84 00 00 00 00 00 66 90 49 89 ca b8 af 01 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 1e 59 0d 00 f7 d8 64 89 01 48
All code
========
0: 73 01 jae 0x3
2: c3 ret
3: 48 8b 0d 4e 59 0d 00 mov 0xd594e(%rip),%rcx # 0xd5958
a: f7 d8 neg %eax
c: 64 89 01 mov %eax,%fs:(%rcx)
f: 48 83 c8 ff or $0xffffffffffffffff,%rax
13: c3 ret
14: 66 2e 0f 1f 84 00 00 cs nopw 0x0(%rax,%rax,1)
1b: 00 00 00
1e: 66 90 xchg %ax,%ax
20: 49 89 ca mov %rcx,%r10
23: b8 af 01 00 00 mov $0x1af,%eax
28: 0f 05 syscall
2a:* 48 3d 01 f0 ff ff cmp $0xfffffffffffff001,%rax <-- trapping instruction
30: 73 01 jae 0x33
32: c3 ret
33: 48 8b 0d 1e 59 0d 00 mov 0xd591e(%rip),%rcx # 0xd5958
3a: f7 d8 neg %eax
3c: 64 89 01 mov %eax,%fs:(%rcx)
3f: 48 rex.W
Code starting with the faulting instruction
===========================================
0: 48 3d 01 f0 ff ff cmp $0xfffffffffffff001,%rax
6: 73 01 jae 0x9
8: c3 ret
9: 48 8b 0d 1e 59 0d 00 mov 0xd591e(%rip),%rcx # 0xd592e
10: f7 d8 neg %eax
12: 64 89 01 mov %eax,%fs:(%rcx)
15: 48 rex.W
The kernel config and materials to reproduce are available at:
https://download.01.org/0day-ci/archive/20260210/[email protected]
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki