Re: Improper Handling for Messages That Do Not Specify Source/Address Port

Hi

On Mon, Oct 28, 2024 at 01:32:09PM -0500, Denis Kenzior wrote:
> > ofonod[3912]: PN_SMS (0x02): SMS_PP_ROUTING_NTF [id=0x08 utid=0x03 len=136]:
> > ofonod[3912]:     * 03 08 00 01 11 84 00 02 82 0C 02 08 07 91 62 78 : ...............bx
> > ofonod[3912]:     * 09 00 00 F5 80 74 6D 00 04 14 D0 C5 F9 1D 04 6A : .....tm........j
> > ofonod[3912]:     * BE C5 69 76 19 00 14 42 01 62 41 51 81 80 56 48 : ..iv...B.bAQ..VH
> > ofonod[3912]:     * 65 6C 6C 6F 20 32 36 38 37 39 39 30 30 34 35 32 : ello.26879900452
> > ofonod[3912]:     * 20 79 6F 75 20 68 61 76 65 20 62 65 65 6E 20 63 : .you.have.been.c
> > ofonod[3912]:     * 68 61 72 67 65 64 20 45 30 20 66 6F 72 20 30 20 : harged.E0.for.0.
> > ofonod[3912]:     * 4D 42 2E 47 65 74 20 6D 6F 72 65 20 66 72 6F 6D : MB.Get.more.from
> > ofonod[3912]:     * 20 6F 75 72 20 62 75 6E 64 6C 65 73 20 6F 6E 20 : .our.bundles.on.
> > ofonod[3912]:     * 6F 66 66 65 72 00 00 00                         : offer...
> > ofonod[3912]: gisi: No error information NTF to 0x63fa40 [res=0x02, id=0x08, utid=0x03]
> > ofonod[3912]: src/sms.c:ofono_sms_deliver_notify() len 117 tpdu len 109
> > ofonod[3912]: src/sms.c:handle_deliver()
> > ofonod[3912]: src/sms.c:sms_dispatch()
> > ofonod[3912]: src/sms.c:sms_dispatch() dst -1 src -1
> > 
> > So yes, this particular message is ASCII
> 
> Do you want to send a patch?  I'm still not sure how oFono would know that
> this is a flash message?  I suppose we can check whether it is valid utf8
> and treat it as a text message.

I also have no clue at this point, so not sure what to do in the code.
However I will see if I can find any information, and maybe find
relevant code in Android for more clues.

Regards
Sicelo