Re: [PATCH 1/8] rmnet: Add skeleton

Hi Denis,

> Add skeleton of the RMNet interface management module.  Implement the
> basic API structure and register the module with oFono core.
> ---
> Makefile.am |  2 ++
> src/rmnet.c | 59 +++++++++++++++++++++++++++++++++++++++++++++++++++++
> src/rmnet.h | 25 +++++++++++++++++++++++
> 3 files changed, 86 insertions(+)
> create mode 100644 src/rmnet.c
> create mode 100644 src/rmnet.h
> 
> diff --git a/Makefile.am b/Makefile.am
> index d379201d362b..d107dc410fd2 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -353,6 +353,8 @@ builtin_sources += plugins/u8500.c
> endif
> 
> if QMIMODEM
> +builtin_sources += src/rmnet.h src/rmnet.c
> +
> qmi_sources = drivers/qmimodem/qmi.h drivers/qmimodem/qmi.c \
> drivers/qmimodem/ctl.h \
> drivers/qmimodem/dms.h \

does this make really sense? Putting this into drivers/qmimodem/rmnet.c is not possible?

We might actually need a generic abstraction for del_interface / add_interface and allow for drivers to register their implementation for it, but that is a different story.

Regards

Marcel