Re: [PATCH 01/10] qmi: Added minimum service request period property string.

Hi Grant,

On 2/11/25 11:52 PM, Grant Erickson wrote:
> This may be used by ofono_modem_{g,s}et_integer to get or set the QMI
> minimum service request period, in microseconds, modem property.
> ---
>   drivers/qmimodem/qmi.h | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/qmimodem/qmi.h b/drivers/qmimodem/qmi.h
> index 69698ee049c6..0c786ed065a3 100644
> --- a/drivers/qmimodem/qmi.h
> +++ b/drivers/qmimodem/qmi.h
> @@ -43,6 +43,8 @@
>   #define QMI_SERVICE_RMS		225	/* Remote management service */
>   #define QMI_SERVICE_OMA		226	/* OMA device management service */
>   
> +#define QMI_PROP_MIN_REQ_PERIOD_US "QMIMinReqPeriodUs"
> +

This doesn't really belong here.  Properties that are communicated between 
udevng and gobi/qrtrqmi are documented above the probe() method implementation. 
Also, maybe 'RequestThrottleTimeUs'?

>   enum qmi_data_endpoint_type {
>   	QMI_DATA_ENDPOINT_TYPE_UNKNOWN   = 0x00,
>   	QMI_DATA_ENDPOINT_TYPE_HSIC      = 0x01,

Regards,
-Denis