Re: [PATCH v2 4/7] qmi: Implement QMI service request rate limiting in 'can_write_data'.

On Feb 13, 2025, at 8:22 PM, Grant Erickson <[email protected]> wrote:
> 
> 
> On Feb 12, 2025, at 6:07 PM, Denis Kenzior <[email protected]> wrote:
>> Pretty sure this won't work and gcc will complain.
> 
> Surprisingly, GCC 8.2.0 didn’t squawk about it:

Surprisingly, GCC 12.3.1 didn’t squawk about it either:

% ${SYSROOT}/bin/arm-none-linux-gnueabihf-gcc --version
arm-none-linux-gnueabihf-gcc (Arm GNU Toolchain 12.3.Rel1 (Build arm-12.35))
12.3.1 20230626 Copyright (C) 2022 Free Software Foundation, Inc. This is free
software; see the source for copying conditions.  There is NO warranty; not even
for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

${SYSROOT}/bin/arm-none-linux-gnueabihf-gcc -DHAVE_CONFIG_H -I.
-I${PROJECTROOT}/third_party/ofono/repo  -I./include -I./src
-I${PROJECTROOT}/third_party/ofono/repo/src
-I${PROJECTROOT}/third_party/ofono/repo/gdbus
-I${PROJECTROOT}/third_party/ofono/repo/gisi
-I${PROJECTROOT}/third_party/ofono/repo/gatchat
-I${PROJECTROOT}/third_party/ofono/repo/gril
--sysroot=${SYSROOT}/arm-none-linux-gnueabihf/libc
-D_POSIX_C_SOURCE=201112L -D_DEFAULT_SOURCE
-D_XOPEN_SOURCE -isystem ${SYSROOT}/arm-none-linux-gnueabihf/libc/usr/include
-I${PROJECTROOT}/results/${BUILDPRODUCT}/arm/gnu-toolchain/12.3.1/${BUILDCONFIG}/third_party/linux/linux-dey/include
-I${PROJECTROOT}/results/${BUILDPRODUCT}/arm/gnu-toolchain/12.3.1/${BUILDCONFIG}/third_party/dbus/usr/include/dbus-1.0
-I${PROJECTROOT}/results/${BUILDPRODUCT}/arm/gnu-toolchain/12.3.1/${BUILDCONFIG}/third_party/dbus/usr/lib/dbus-1.0/include
-I${PROJECTROOT}/results/${BUILDPRODUCT}/arm/gnu-toolchain/12.3.1/${BUILDCONFIG}/third_party/glib/usr/include/gio-unix-2.0
-I${PROJECTROOT}/results/${BUILDPRODUCT}/arm/gnu-toolchain/12.3.1/${BUILDCONFIG}/third_party/glib/usr/include/glib-2.0
-I${PROJECTROOT}/results/${BUILDPRODUCT}/arm/gnu-toolchain/12.3.1/${BUILDCONFIG}/third_party/glib/usr/lib/glib-2.0/include
-I${PROJECTROOT}/results/${BUILDPRODUCT}/arm/gnu-toolchain/12.3.1/${BUILDCONFIG}/third_party/ell/usr/include
-I${PROJECTROOT}/results/${BUILDPRODUCT}/arm/gnu-toolchain/12.3.1/${BUILDCONFIG}/third_party/eudev/usr/include -DOFONO_PLUGIN_BUILTIN
-DPLUGINDIR=\""/usr/lib/ofono/plugins"\" -DUNITDIR=\""./unit/"\"
--sysroot=${SYSROOT}/arm-none-linux-gnueabihf/libc -mcpu=cortex-a8
-mfloat-abi=hard -mfpu=neon -fno-omit-frame-pointer -fno-strict-aliasing     
-O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -MT drivers/qmimodem/qmi.o -MD -MP -MF
$depbase.Tpo -c -o drivers/qmimodem/qmi.o
${PROJECTROOT}/third_party/ofono/repo/drivers/qmimodem/qmi.c &&\ mv -f
$depbase.Tpo $depbase.Po

Regardless, I’ll address it and have a v3 shortly.

-- 
Principal
Nuovations

[email protected]
https://www.nuovations.com/