Re: [PATCH v3 4/7] qmi: Implement QMI service request rate limiting in 'can_write_data'.

Hi Grant,
 >
> I’ve noted that the default ofono warning flags do not highlight the potential conditional issue with ’now’ on arm, aarch64, or x86_64 with gcc or clang. If I dial up warnings with -Wall -Wextra -Weverything, then I get the warning.

This sometimes depends on the version of gcc as well.

> 
> With that in mind, do you want ’now’ to follow M7 with the default warning flag set or to not follow M7 but ensuring the warning is addressed using default initialization with a non-default set of warning flags?

M7 should be followed, and if the warning is known to be spurious, then a pragma 
may be added.  See ell for examples of this (grep for _Pragma).  However, 
_Pragma is not always followed.  Easiest may be to give the compiler a chance of 
misinterpreting the intent :)

Regards,
-Denis