Re: [PATCH v1 0/4] mbim: Add support for MediaTek T700 modem

Hi Denis,

On 5/2/25 20:03, Denis Kenzior wrote:
> Do you know if this modem is available in the US for purchase? 
According to Lenovo, this modem is not available for sale in the USA due 
to it not passing FCC certifications or something.
>
> I had this cycle through the CI, and CI complains quite a bit. Also, 
> if you really want this to be applied upstream, then I'll need a a 
> last name in the author information.
>
> Alpine (musl) gcc optimized
> ===========================
> Configure: PASS
> Build: FAIL
>     plugins/udevng.c: In function 'setup_mbim':
>     plugins/udevng.c:1203:25: error: ISO C90 forbids mixed 
> declarations and code [-Werror=declaration-after-statement]
>      1203 |                         DIR *d = opendir(path);
>           |                         ^~~
>     plugins/udevng.c:1214:41: error: ISO C90 forbids mixed 
> declarations and code [-Werror=declaration-after-statement]
>      1214 |                                         char wwan_path[1024];
>           |                                         ^~~~
>     plugins/udevng.c:1217:41: error: ISO C90 forbids mixed 
> declarations and code [-Werror=declaration-after-statement]
>      1217 |                                         struct udev_device 
> *wwan_device = udev_device_new_from_syspath(new_udev, wwan_path);
>           |                                         ^~~~~~
>     plugins/udevng.c:1221:41: error: ISO C90 forbids mixed 
> declarations and code [-Werror=declaration-after-statement]
>      1221 |                                         DIR *sd = 
> opendir(wwan_path);
>           |                                         ^~~
>     plugins/udevng.c:1231:49: error: ISO C90 forbids mixed 
> declarations and code [-Werror=declaration-after-statement]
>      1231 |                                                 char 
> sub_path[2048];
>           |                                                 ^~~~
>     plugins/udevng.c:1234:49: error: ISO C90 forbids mixed 
> declarations and code [-Werror=declaration-after-statement]
>      1234 |                                                 struct 
> udev_device *sub_device = udev_device_new_from_syspath(new_udev, 
> sub_path);
>           |                                                 ^~~~~~
>     cc1: all warnings being treated as errors
>     make[1]: *** [Makefile:4090: plugins/udevng.o] Error 1
>     make[1]: Target 'all-am' not remade because of errors.
>     make: *** [Makefile:2405: all] Error 2
>
> Fedora (glibc) clang optimized
> ==============================
> Configure: FAIL
>     configure.ac:25: installing 'build-aux/compile'
>     configure.ac:41: installing 'build-aux/config.guess'
>     configure.ac:41: installing 'build-aux/config.sub'
>     configure.ac:10: installing 'build-aux/install-sh'
>     configure.ac:10: installing 'build-aux/missing'
>     configure.ac:8: installing 'build-aux/tap-driver.sh'
>     Makefile.am: installing 'build-aux/depcomp'
>     parallel-tests: installing 'build-aux/test-driver'
>     ./configure: line 12804: awk: command not found
>     ./configure: line 12874: awk: command not found
>     ./configure: line 13443: awk: command not found
>     ./config.status: line 1300: awk: command not found
>     config.status: error: could not create Makefile
>
>
> Checkpatch Output
> =================
> 0001-plugins-udevng-Add-support-for-PCIe-MBIM-modems-Pars.patch:8: 
> WARNING: Missing commit description - Add an appropriate one
> 0001-plugins-udevng-Add-support-for-PCIe-MBIM-modems-Pars.patch:22: 
> WARNING: Missing a blank line after declarations
> 0001-plugins-udevng-Add-support-for-PCIe-MBIM-modems-Pars.patch:26: 
> WARNING: Missing a blank line after declarations
> 0001-plugins-udevng-Add-support-for-PCIe-MBIM-modems-Pars.patch:28: 
> WARNING: Missing a blank line after declarations
> 0001-plugins-udevng-Add-support-for-PCIe-MBIM-modems-Pars.patch:36: 
> WARNING: Missing a blank line after declarations
> 0001-plugins-udevng-Add-support-for-PCIe-MBIM-modems-Pars.patch:38: 
> WARNING: line length of 124 exceeds 100 columns
> 0001-plugins-udevng-Add-support-for-PCIe-MBIM-modems-Pars.patch:39: 
> WARNING: Missing a blank line after declarations
> 0001-plugins-udevng-Add-support-for-PCIe-MBIM-modems-Pars.patch:44: 
> WARNING: Missing a blank line after declarations
> 0001-plugins-udevng-Add-support-for-PCIe-MBIM-modems-Pars.patch:45: 
> WARNING: Too many leading tabs - consider code refactoring
> 0001-plugins-udevng-Add-support-for-PCIe-MBIM-modems-Pars.patch:48: 
> WARNING: Too many leading tabs - consider code refactoring
> 0001-plugins-udevng-Add-support-for-PCIe-MBIM-modems-Pars.patch:53: 
> WARNING: line length of 102 exceeds 100 columns
> 0001-plugins-udevng-Add-support-for-PCIe-MBIM-modems-Pars.patch:53: 
> WARNING: Missing a blank line after declarations
> 0001-plugins-udevng-Add-support-for-PCIe-MBIM-modems-Pars.patch:55: 
> WARNING: line length of 130 exceeds 100 columns
> 0001-plugins-udevng-Add-support-for-PCIe-MBIM-modems-Pars.patch:56: 
> WARNING: line length of 114 exceeds 100 columns
> 0001-plugins-udevng-Add-support-for-PCIe-MBIM-modems-Pars.patch:58: 
> WARNING: Too many leading tabs - consider code refactoring
> 0001-plugins-udevng-Add-support-for-PCIe-MBIM-modems-Pars.patch:59: 
> WARNING: line length of 125 exceeds 100 columns
> 0001-plugins-udevng-Add-support-for-PCIe-MBIM-modems-Pars.patch:61: 
> WARNING: Too many leading tabs - consider code refactoring
> 0001-plugins-udevng-Add-support-for-PCIe-MBIM-modems-Pars.patch:62: 
> WARNING: line length of 106 exceeds 100 columns
> 0001-plugins-udevng-Add-support-for-PCIe-MBIM-modems-Pars.patch:63: 
> WARNING: Too many leading tabs - consider code refactoring
> 0001-plugins-udevng-Add-support-for-PCIe-MBIM-modems-Pars.patch:64: 
> WARNING: line length of 108 exceeds 100 columns
> total: 0 errors, 20 warnings, 59 lines checked
> 0002-mbimmodem-add-support-for-MBIM-extensions-With-MBIME.patch:8: 
> WARNING: Missing commit description - Add an appropriate one
> 0002-mbimmodem-add-support-for-MBIM-extensions-With-MBIME.patch:27: 
> WARNING: line length of 101 exceeds 100 columns
> 0002-mbimmodem-add-support-for-MBIM-extensions-With-MBIME.patch:134: 
> WARNING: please, no spaces at the start of a line
> 0002-mbimmodem-add-support-for-MBIM-extensions-With-MBIME.patch:135: 
> WARNING: please, no spaces at the start of a line
> 0002-mbimmodem-add-support-for-MBIM-extensions-With-MBIME.patch:140: 
> WARNING: please, no spaces at the start of a line
> 0002-mbimmodem-add-support-for-MBIM-extensions-With-MBIME.patch:142: 
> WARNING: please, no spaces at the start of a line
> 0002-mbimmodem-add-support-for-MBIM-extensions-With-MBIME.patch:143: 
> WARNING: please, no spaces at the start of a line
> 0002-mbimmodem-add-support-for-MBIM-extensions-With-MBIME.patch:144: 
> WARNING: please, no spaces at the start of a line
> 0002-mbimmodem-add-support-for-MBIM-extensions-With-MBIME.patch:145: 
> WARNING: please, no spaces at the start of a line
> 0002-mbimmodem-add-support-for-MBIM-extensions-With-MBIME.patch:158: 
> WARNING: please, no spaces at the start of a line
> 0002-mbimmodem-add-support-for-MBIM-extensions-With-MBIME.patch:161: 
> WARNING: please, no spaces at the start of a line
> 0002-mbimmodem-add-support-for-MBIM-extensions-With-MBIME.patch:163: 
> WARNING: please, no spaces at the start of a line
> 0002-mbimmodem-add-support-for-MBIM-extensions-With-MBIME.patch:164: 
> ERROR: code indent should use tabs where possible
> 0002-mbimmodem-add-support-for-MBIM-extensions-With-MBIME.patch:164: 
> WARNING: please, no spaces at the start of a line
> 0002-mbimmodem-add-support-for-MBIM-extensions-With-MBIME.patch:165: 
> ERROR: code indent should use tabs where possible
> 0002-mbimmodem-add-support-for-MBIM-extensions-With-MBIME.patch:165: 
> WARNING: please, no spaces at the start of a line
> 0002-mbimmodem-add-support-for-MBIM-extensions-With-MBIME.patch:167: 
> WARNING: please, no spaces at the start of a line
> 0002-mbimmodem-add-support-for-MBIM-extensions-With-MBIME.patch:168: 
> ERROR: code indent should use tabs where possible
> 0002-mbimmodem-add-support-for-MBIM-extensions-With-MBIME.patch:168: 
> WARNING: please, no spaces at the start of a line
> 0002-mbimmodem-add-support-for-MBIM-extensions-With-MBIME.patch:169: 
> ERROR: code indent should use tabs where possible
> 0002-mbimmodem-add-support-for-MBIM-extensions-With-MBIME.patch:169: 
> WARNING: please, no spaces at the start of a line
> 0002-mbimmodem-add-support-for-MBIM-extensions-With-MBIME.patch:172: 
> WARNING: please, no spaces at the start of a line
> 0002-mbimmodem-add-support-for-MBIM-extensions-With-MBIME.patch:175: 
> WARNING: line length of 103 exceeds 100 columns
> 0002-mbimmodem-add-support-for-MBIM-extensions-With-MBIME.patch:177: 
> WARNING: please, no spaces at the start of a line
> 0002-mbimmodem-add-support-for-MBIM-extensions-With-MBIME.patch:178: 
> ERROR: code indent should use tabs where possible
> 0002-mbimmodem-add-support-for-MBIM-extensions-With-MBIME.patch:178: 
> WARNING: please, no spaces at the start of a line
> 0002-mbimmodem-add-support-for-MBIM-extensions-With-MBIME.patch:179: 
> ERROR: code indent should use tabs where possible
> 0002-mbimmodem-add-support-for-MBIM-extensions-With-MBIME.patch:179: 
> WARNING: please, no spaces at the start of a line
> 0002-mbimmodem-add-support-for-MBIM-extensions-With-MBIME.patch:193: 
> WARNING: please, no space before tabs
> 0002-mbimmodem-add-support-for-MBIM-extensions-With-MBIME.patch:211: 
> WARNING: line length of 104 exceeds 100 columns
> total: 6 errors, 24 warnings, 181 lines checked
> 0003-mbim-fetch-MBIM-version-on-init.patch:7: WARNING: Missing commit 
> description - Add an appropriate one
> total: 0 errors, 1 warnings, 8 lines checked
> 0004-plugins-udevng-Add-support-for-the-MediaTek-T700-5G-.patch:9: 
> WARNING: Missing commit description - Add an appropriate one
> 0004-plugins-udevng-Add-support-for-the-MediaTek-T700-5G-.patch:21: 
> WARNING: please, no space before tabs
> total: 0 errors, 2 warnings, 7 lines checked
>
> Regards,
> -Denis

Thank you for the insights. I will reformat the patches, fix the 
warnings and send a new revision.

Regards,

- Muhammad