Re: [PATCH v4 3/6] mbim: fetch MBIM version on init

Muhammad <[email protected]> Tue, 6 May 2025 16:16:43 +0500
Newsgroups dev.linux.lists.ofono
Message-ID <[email protected]>
Hi Denis,

On 5/5/25 21:07, Denis Kenzior wrote:
> Hi Muhammad,
>
> On 5/4/25 2:19 PM, Muhammad Asif wrote:
>> ---
>>   plugins/mbim.c | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/plugins/mbim.c b/plugins/mbim.c
>> index e1d33f47..3a1942da 100644
>> --- a/plugins/mbim.c
>> +++ b/plugins/mbim.c
>> @@ -287,6 +287,8 @@ static int mbim_enable(struct ofono_modem *modem)
>>                       mbim_device_closed, modem, NULL);
>>       mbim_device_set_debug(md->device, mbim_debug, "MBIM:", NULL);
>>   +    mbim_device_get_version(md->device);
>> +
>
> I think you need to invoke this after mbim_device_ready() has been 
> invoked.
>
>>       return -EINPROGRESS;
>>   }
>
> Regards,
> -Denis

I will move it to be invoked after the device is ready.

- Muhammad