[PATCH 4/5] mbim: Do not require the DescriptorsFile property

Denis Kenzior <[email protected]> Fri, 9 May 2025 15:01:11 -0500
Newsgroups dev.linux.lists.ofono
Message-ID <[email protected]>
Some PCIe MBIM devices (for example, based on MHI) do not provide a
descriptors file, unlike USB MBIM devices.
---
 plugins/mbim.c | 17 +++++++----------
 1 file changed, 7 insertions(+), 10 deletions(-)

diff --git a/plugins/mbim.c b/plugins/mbim.c
index e1d33f477515..fa4a25d58eee 100644
--- a/plugins/mbim.c
+++ b/plugins/mbim.c
@@ -80,22 +80,19 @@ static int mbim_probe(struct ofono_modem *modem)
 {
 	const char *descriptors;
 	struct mbim_data *data;
-	int err;
 
 	DBG("%p", modem);
 
-	descriptors = ofono_modem_get_string(modem, "DescriptorFile");
-
-	if (!descriptors)
-		return -EINVAL;
-
 	data = l_new(struct mbim_data, 1);
 	data->max_outstanding = 1;
+	data->max_segment = 512;
+
+	descriptors = ofono_modem_get_string(modem, "DescriptorFile");
+	if (descriptors) {
+		int err = mbim_parse_descriptors(data, descriptors);
 
-	err = mbim_parse_descriptors(data, descriptors);
-	if (err < 0) {
-		DBG("Warning, unable to load descriptors, setting defaults");
-		data->max_segment = 512;
+		if (err < 0)
+			ofono_warn("Unable to load descriptors");
 	}
 
 	DBG("MaxSegment: %d, MaxOutstanding: %d",
-- 
2.48.1