Re: [PATCH 4/4] doc: sim-api document ForbiddenPLMN

Hi Denis,

On Tue, Jul 01, 2025 at 10:02:55AM +0100, Denis Kenzior wrote:
> Hi Sean,
> 
> On 7/1/25 4:29 AM, Sean Nyekjaer wrote:
> > ---
> >   doc/sim-api.txt | 7 +++++++
> >   1 file changed, 7 insertions(+)
> >
> > diff --git a/doc/sim-api.txt b/doc/sim-api.txt
> > index 419d8ec3ef17fc5b2876d1047249ab76bf608cce..a127ad55b358c082e853e15f52eead5bbbf5fae3 100644
> > --- a/doc/sim-api.txt
> > +++ b/doc/sim-api.txt
> > @@ -227,3 +227,10 @@ Properties	boolean Present [readonly]
> >
> >   			This property will range from 1 (default) to
> >   			CardSlotCount (max) value.
> > +
> > +		array{string} ForbiddenPLMN
> 
> Maybe ForbiddenNetworks or ForbiddenNetworkOperators?  I like to not use
> all-caps acronyms in snake-case APIs.  We also use NetworkOperator in
> network-api.txt...

ForbiddenNetworkOperators it is :)

> 
> > +
> > +			The list contains a list of forbidden PLMNs
> > +			(Mobile Country Code (MCC) and Mobile Network Code (MNC)).
> 
> So you want to always be overwriting the entire list?  I guess that would work,
> but note that the modem can actually manage this file as well.  How would oFono
> know when this happened?  Does the modem send a SIM REFRESH via STK/CAT?  Does
> your vendor have any guidance here?
> 
> > +
> > +			Max allowed elements in sim is 4.
> 
> This isn't really limited to 4, in fact it is variable length, see 3GPP 31.102,
> or the ETSI equivalent here:
> https://www.etsi.org/deliver/etsi_ts/131100_131199/131102/18.04.00_60/ts_131102v180400p.pdf.
>   Section 4.2.16.
> 
> Either we only support the 'clear' operation, or we need to expose the length
> somehow.

I'm in favor of only supporting the 'clear' operation.

For the get operation would it be okay to collect the list on demand
when GetProperties is called?

> 
> Regards,
> -Denis

/Sean