[PATCH 4/6] gobi: Do not try to create WDA service if modem does not support it
Ivaylo Dimitrov <[email protected]> Fri, 25 Jul 2025 15:19:52 +0300
| Newsgroups | dev.linux.lists.ofono |
|---|---|
| Message-ID | <[email protected]> |
fix create_wda_cb() qmi_qmux_device_create_client() result check while at
it
---
plugins/gobi.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/plugins/gobi.c b/plugins/gobi.c
index 8af449ae..f908f935 100644
--- a/plugins/gobi.c
+++ b/plugins/gobi.c
@@ -717,7 +717,7 @@ static void create_wda_cb(struct qmi_service *service, void *user_data)
DBG("Failed to request WDA service, assume 802.3");
if (qmi_qmux_device_create_client(data->device, QMI_SERVICE_DMS,
- request_service_cb, modem, NULL) > 0)
+ request_service_cb, modem, NULL))
return;
goto error;
@@ -797,8 +797,11 @@ static void discover_cb(void *user_data)
if (data->features & GOBI_UIM)
add_service_request(data, &data->uim, QMI_SERVICE_UIM);
- if (qmi_qmux_device_create_client(data->device, QMI_SERVICE_WDA,
- create_wda_cb, modem, NULL))
+ if (data->features & GOBI_WDA) {
+ if (qmi_qmux_device_create_client(data->device,
+ QMI_SERVICE_WDA, create_wda_cb, modem, NULL))
+ return;
+ } else if (start_service_requests(modem))
return;
error:
--
2.25.1