Re: [PATCH v8 8/8] mbim/network-registration: add support for manual registration

On 12/12/25 16:02, Muhammad Asif wrote:
> Adds support for scanning available operators, and manually registering
> to a selected network.
[...]
> @@ -217,8 +283,8 @@ static void mbim_register_state_set_cb(struct mbim_message *message, void *user)
>   		CALLBACK_WITH_SUCCESS(cb, cbd->data);
>   }
>   
> -static void mbim_register_auto(struct ofono_netreg *netreg,
> -				ofono_netreg_register_cb_t cb, void *data)
> +static void mbim_register(struct cb_data *cbd, enum mbim_register_type reg_type,
> +				const char *provider_id)
>   {
>   	static const uint32_t data_class = MBIM_DATA_CLASS_GPRS |
>   						MBIM_DATA_CLASS_EDGE |
> @@ -226,22 +292,48 @@ static void mbim_register_auto(struct ofono_netreg *netreg,
>   						MBIM_DATA_CLASS_HSDPA |
>   						MBIM_DATA_CLASS_HSUPA |
>   						MBIM_DATA_CLASS_LTE;
> -	struct netreg_data *nd = ofono_netreg_get_data(netreg);
> -	struct cb_data *cbd = cb_data_new(cb, data);
>   	struct mbim_message *message;
>   
>   	message = mbim_message_new(mbim_uuid_basic_connect,
>   					MBIM_CID_REGISTER_STATE,
>   					MBIM_COMMAND_TYPE_SET);
> -	mbim_message_set_arguments(message, "suu", NULL, 0, data_class);
>   
> -	if (mbim_device_send(nd->device, NETREG_GROUP, message,
> +	mbim_message_set_arguments(message, "suu", provider_id,
> +					reg_type, data_class);
> +
> +	if (mbim_device_send(cbd->data, NETREG_GROUP, message,

Did you mean to pass cbd->data here, instaed of nd->device?


>   				mbim_register_state_set_cb, cbd, l_free) > 0)
>   		return;
>   
>   	l_free(cbd);
>   	mbim_message_unref(message);
> -	CALLBACK_WITH_FAILURE(cb, data);
> +	CALLBACK_WITH_FAILURE(cb, cbd->data);
> +}