Re: [PATCH v8] staging: vt6655: Remove unused declaration of RFbAL7230SelectChannelPostProcess()

On 3/16/24 21:42, Dorine Tipo wrote:
> Remove unused function RFbAL7230SelectChannelPostProcess declared in
> rf.h but has no associated implementation.
> 
> Commit dd2837bdea0e removed the RFbAL7230SelectChannelPostProcess() but
> accidentally forgot to delete the declaration in the header file.
> 
> Fixes: dd2837bdea0e ("staging: vt6655: Remove unused byRFType in rf.c")
> Signed-off-by: Dorine Tipo <[email protected]>
> ---
> Changes since V1:
> 
> V2: - Removed the unintended blank line after removing the dead code
>      - Removed "in rf.h" from the subject
> 
> V3: - Added in the Description Comment about unintended blank line
> 
> V4: - Adjusted complete description according to hint from feedback
>      - Rebased patch
> V5: - Added a missing closing parenthesis in the fixes tag
> 
> V6: - Sent the wrong patch for v5. This version includes the fix in v5
> 
> V7: - Made the subjectline more uniques as suggested by
>        [email protected]
> 
> V8: - Put the entire subject on one line to ensure the function name
>        appears on the subject
> 
>   drivers/staging/vt6655/rf.h | 4 ----
>   1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/staging/vt6655/rf.h b/drivers/staging/vt6655/rf.h
> index 6f842ac00526..8eef100c7ef2 100644
> --- a/drivers/staging/vt6655/rf.h
> +++ b/drivers/staging/vt6655/rf.h
> @@ -68,8 +68,4 @@ bool RFbRawSetPower(struct vnt_private *priv, unsigned char byPwr,
>   void RFvRSSITodBm(struct vnt_private *priv, unsigned char byCurrRSSI,
>   		  long *pldBm);
> 
> -/* {{ RobertYu: 20050104 */
> -bool RFbAL7230SelectChannelPostProcess(struct vnt_private *priv, u16 byOldChannel, u16 byNewChannel);
> -/* }} RobertYu */
> -
>   #endif /* __RF_H__ */
> --
> 2.25.1
> 
> 

Tested-by: Philipp Hortmann <[email protected]>