Re: [PATCH] staging: sm750fb: Replace comparisons with NULL and 0

Dan Carpenter <[email protected]> Wed, 20 Mar 2024 08:08:15 +0300

Newsgroups	dev.linux.lists.outreachy,dev.linux.lists.linux-staging,org.kernel.vger.linux-fbdev,org.kernel.vger.linux-kernel
Message-ID	<[email protected]>

On Tue, Mar 19, 2024 at 11:47:35PM +0530, Chandra Pratap wrote:
> Replace '(foo != NULL)' with '(foo)' and 'x != 0'
> with 'x' to adhere to the coding standards.
> 

In your commit message use "opt" and "*opt" instead of "foo" and "x".

Removing the != NULL is fine, but the *opt != 0 should be changed to
(*opt != '\0').  There are times where comparing against zero helps
readability.  I wrote a blog about this, but I had forgotten the case
with the NUL terminator...

https://staticthinking.wordpress.com/2024/02/20/when-to-use-0/

regards,
dan carpenter