Re: [PATCH v3] staging: nvec: Use x instead of x != NULL to improve readability.
Philipp Hortmann <[email protected]>
| Newsgroups | dev.linux.lists.outreachy,dev.linux.lists.linux-staging,org.kernel.vger.linux-kernel,org.kernel.vger.linux-tegra |
|---|---|
| Message-ID | <[email protected]> |
On 6/29/24 19:47, Tom Mounet wrote: > Use x instead of x != NULL to improve readability. > Issue identified by checkpatch. > > Signed-off-by: Tom Mounet <[email protected]> > --- > v3: Add change history and proper description > v2: Make commit title clearer > > drivers/staging/nvec/nvec.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c > index e5ca78e57..814eb121c 100644 > --- a/drivers/staging/nvec/nvec.c > +++ b/drivers/staging/nvec/nvec.c > @@ -300,7 +300,7 @@ int nvec_write_sync(struct nvec_chip *nvec, > { > mutex_lock(&nvec->sync_write_mutex); > > - if (msg != NULL) > + if (msg) > *msg = NULL; > > nvec->sync_write_pending = (data[1] << 8) + data[0]; > @@ -322,7 +322,7 @@ int nvec_write_sync(struct nvec_chip *nvec, > > dev_dbg(nvec->dev, "nvec_sync_write: pong!\n"); > > - if (msg != NULL) > + if (msg) > *msg = nvec->last_sync_msg; > else > nvec_msg_free(nvec, nvec->last_sync_msg); Reviewed-by: Philipp Hortmann <[email protected]>