Re: [PATCH v9 2/5] selftests/Landlock: Abstract unix socket restriction tests

On Mon, Aug 19, 2024 at 05:42:59PM +0200, Mickaël Salaün wrote:
> On Wed, Aug 14, 2024 at 12:22:20AM -0600, Tahera Fahimi wrote:
> > The patch introduces Landlock ABI version 6 and has three types of tests
> 
> "and adds three types" ?
> 
> > that examines different scenarios for abstract unix socket connection:
> 
> Not only connection.
> 
> > 1) unix_socket: base tests of the abstract socket scoping mechanism for a
> >    landlocked process, same as the ptrace test.
> > 2) optional_scoping: generates three processes with different domains and
> >    tests if a process with a non-scoped domain can connect to other
> >    processes.
> > 3) unix_sock_special_cases: since the socket's creator credentials are used
> 
> "unix_sock_special_cases" seems a bit too generic and is not
> self-explanatory.  What about "outside_socket"?
Sure, I'll change it to "outside_socket"

> >    for scoping sockets, this test examines the cases where the socket's
> >    credentials are different from the process using it.
> > 
> > Signed-off-by: Tahera Fahimi <[email protected]>
> > ---
> 
> > --- /dev/null
> > +++ b/tools/testing/selftests/landlock/scoped_abstract_unix_test.c
> > @@ -0,0 +1,942 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * Landlock tests - Abstract Unix Socket
> > + *
> > + * Copyright © 2017-2020 Mickaël Salaün <[email protected]>
> > + * Copyright © 2019-2020 ANSSI
> 
> You can replace these two lines with your copyright (same for the signal
> test file):
> Copyright © 2024 Tahera Fahimi <[email protected]>
Right. I copied this from ptrace_test.c and forgot to change it. Thanks
:)