Re: [PATCH] staging: greybus: remove unnecessary parentheses
Greg Kroah-Hartman <[email protected]>
| Newsgroups | dev.linux.lists.outreachy,dev.linux.lists.linux-staging,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <2025010932-rice-landed-2b96@gregkh> |
On Thu, Jan 09, 2025 at 10:45:50AM +0300, Dan Carpenter wrote: > On Wed, Jan 08, 2025 at 08:56:50PM -0600, Alex Elder wrote: > > On 1/8/25 6:36 PM, Will Walsh wrote: > > > Unnecessary parentheses in boolean comparisons make it harder to read. > > > > > > Removed the extra parentheses on line 305 for code readability. > > > > > > Signed-off-by: Will Walsh <[email protected]> > > > > I'm not sure this makes a big difference in readability but I > > personally avoid extra parentheses unless adding them makes a > > compiler warning go away. > > It's not a compiler warning, it checkpatch. And it is a checkpatch warning that I HATE and keep rejecting, here's where I did so yesterday: https://lore.kernel.org/r/2025010738-gong-rewind-2583@gregkh Will, sorry, but I don't want to take this. greg k-h