Re: [PATCH] staging: bcm2835-camera: Modify function call formatting
Julia Lawall <[email protected]>
| Newsgroups | dev.linux.lists.outreachy,dev.linux.lists.linux-staging,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <alpine.DEB.2.22.394.2503221510230.12345@hadrien> |
On Sat, 22 Mar 2025, Abraham Samuel Adekunle wrote:
> The line is a function call which ends with an opening parenthesis
> thereby not adhering to the Linux kernel coding style.
>
> Modify the function call to include parameters on the same line as
> the opening parenthesis to improve readability and consistency while
> adhering to Linux coding styles.
>
> Reported by checkpatch:
>
> CHECK: Lines should not end with '('
Please check the get_maintainer script (see tutorial). It looks like
there are some other people who should receive patches on this driver.
julia
>
> Signed-off-by: Abraham Samuel Adekunle <[email protected]>
> ---
> .../vc04_services/bcm2835-camera/controls.c | 14 ++++++--------
> 1 file changed, 6 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/staging/vc04_services/bcm2835-camera/controls.c b/drivers/staging/vc04_services/bcm2835-camera/controls.c
> index 6bce45925bf1..e670226f1edf 100644
> --- a/drivers/staging/vc04_services/bcm2835-camera/controls.c
> +++ b/drivers/staging/vc04_services/bcm2835-camera/controls.c
> @@ -533,17 +533,15 @@ static int ctrl_set_image_effect(struct bcm2835_mmal_dev *dev,
>
> control = &dev->component[COMP_CAMERA]->control;
>
> - ret = vchiq_mmal_port_parameter_set(
> - dev->instance, control,
> - MMAL_PARAMETER_IMAGE_EFFECT_PARAMETERS,
> - &imagefx, sizeof(imagefx));
> + ret = vchiq_mmal_port_parameter_set(dev->instance, control,
> + MMAL_PARAMETER_IMAGE_EFFECT_PARAMETERS,
> + &imagefx, sizeof(imagefx));
> if (ret)
> goto exit;
>
> - ret = vchiq_mmal_port_parameter_set(
> - dev->instance, control,
> - MMAL_PARAMETER_COLOUR_EFFECT,
> - &dev->colourfx, sizeof(dev->colourfx));
> + ret = vchiq_mmal_port_parameter_set(dev->instance, control,
> + MMAL_PARAMETER_COLOUR_EFFECT,
> + &dev->colourfx, sizeof(dev->colourfx));
> }
>
> exit:
> --
> 2.34.1
>
>