Re: [PATCH] staging: octeon: Fix unused macro Argument 'x'
Julia Lawall <[email protected]>
| Newsgroups | dev.linux.lists.outreachy,dev.linux.lists.linux-staging,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On Tue, 25 Mar 2025, nancyenos wrote: > warning found by checkpath.pl > > Signed-off-by: nancyenos <[email protected]> > --- > drivers/staging/octeon/octeon-stubs.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/octeon/octeon-stubs.h b/drivers/staging/octeon/octeon-stubs.h > index 44cced319c11..0155f3c41657 100644 > --- a/drivers/staging/octeon/octeon-stubs.h > +++ b/drivers/staging/octeon/octeon-stubs.h > @@ -8,8 +8,8 @@ > #define OCTEON_IRQ_WORKQ0 0 > #define OCTEON_IRQ_RML 0 > #define OCTEON_IRQ_TIMER1 0 > -#define OCTEON_IS_MODEL(x) 0 > -#define octeon_has_feature(x) 0 > +#define OCTEON_IS_MODEL(x) ((void)(x), 0) > +#define octeon_has_feature(x) ((void)(x), 0) I'm not sure that this is useful. It seems that there may be multiple definitions; one that has an argument and a default one that doesn't need anything. It's true that this change will ensure that x is checked by the compiler, which may help find some bugs. Have you seen other code that makes this kind of change? thanks, julia > #define octeon_get_clock_rate() 0 > > #define CVMX_SYNCIOBDMA do { } while (0) > -- > 2.25.1 > > >