Re: Can't Build Linux Kernel from Tutorial

On Sun, Mar 30, 2025 at 6:40 PM Richard Akintola
<[email protected]> wrote:
>
> Hi Julia,
>
> Having reviewed previous messages on the mailing list, and running the command:
> perl scripts/checkpatch.pl --strict -f drivers/staging/sm750fb/* | less
>
> I found:
> ------------------------------------
> drivers/staging/sm750fb/ddk750_dvi.c
> ------------------------------------
> CHECK: Avoid CamelCase: <sii164GetDeviceID>
> #19: FILE: drivers/staging/sm750fb/ddk750_dvi.c:19:
> +               .get_device_id = sii164GetDeviceID,
>
> CHECK: Avoid CamelCase: <sii164ResetChip>
> #21: FILE: drivers/staging/sm750fb/ddk750_dvi.c:21:
> +               .reset_chip = sii164ResetChip,
>
> CHECK: Avoid CamelCase: <sii164GetChipString>
> #22: FILE: drivers/staging/sm750fb/ddk750_dvi.c:22:
> +               .get_chip_string = sii164GetChipString,
>
> CHECK: Avoid CamelCase: <sii164SetPower>
> #23: FILE: drivers/staging/sm750fb/ddk750_dvi.c:23:
> +               .set_power = sii164SetPower,
>
> CHECK: Avoid CamelCase: <sii164EnableHotPlugDetection>
> #24: FILE: drivers/staging/sm750fb/ddk750_dvi.c:24:
> +               .enable_hot_plug_detection = sii164EnableHotPlugDetection,
>
> CHECK: Avoid CamelCase: <sii164IsConnected>
> #25: FILE: drivers/staging/sm750fb/ddk750_dvi.c:25:
> +               .is_connected = sii164IsConnected,
>
> CHECK: Avoid CamelCase: <sii164CheckInterrupt>
> #26: FILE: drivers/staging/sm750fb/ddk750_dvi.c:26:
> +               .check_interrupt = sii164CheckInterrupt,
>
> CHECK: Avoid CamelCase: <sii164ClearInterrupt>
> #27: FILE: drivers/staging/sm750fb/ddk750_dvi.c:27:
> +               .clear_interrupt = sii164ClearInterrupt,
>
> total: 0 errors, 0 warnings, 8 checks, 62 lines checked
>
> I would love to have all the 8 checks done, although I learnt it is one
> check at a time.
>
> Please how do I go about sending the patches, given the fact that same
> definitions are
> found in file: drivers/staging/sm750fb/ddk750_dvi.c and file:
> drivers/staging/sm750fb/ddk750_sii164.h
> and I don't know which other files they are defined.
>
> Richard Akintola
>

Hello Richard
Here are some steps to send your patch
1. Since you have identified the files that checkpatch has checks for,
    you can pick some of the files to modify and assess if it is
appropriate to modify the file
2. If it is appropriate to modify, then modify it to adhere to Linux
coding styles and/or any other files you want to modify
3. Rebuild to be sure nothing breaks and no compiler errors using
`make drivers/staging/`
4. If nothing breaks and all is fine, you can view your modified files
with `git diff`
5. Add your modified file to the staging area using git add -A
6. Commit your changes using git commit -s -v, writing your commit messages
7. Use git format-patch -o /tmp/ HEAD^ to format your commit into a patch
8. Use mutt -H /tmp/<filename.patch> or git send-mail to send your patch

I hope this helps

Adekunle