Re: [PATCH v2 5/5] staging: rtl8723bs: no space before tabs
Greg KH <[email protected]> Tue, 1 Apr 2025 19:18:21 +0100
| Newsgroups | dev.linux.lists.outreachy,dev.linux.lists.linux-staging,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <2025040127-unretired-veto-b056@gregkh> |
On Tue, Apr 01, 2025 at 07:59:37PM +0300, Erick Karanja wrote: > Remove spaces before tabs to comply with the Linux kernel coding style > guidelines. Proper indentation using tabs improves code consistency > and readability. > > Reported by checkpatch: > > WARNING: please, no space before tabs > > Signed-off-by: Erick Karanja <[email protected]> > --- > drivers/staging/rtl8723bs/hal/hal_btcoex.c | 33 ++++------------------ > 1 file changed, 6 insertions(+), 27 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/hal/hal_btcoex.c b/drivers/staging/rtl8723bs/hal/hal_btcoex.c > index 9105594d2dde..44f73baf1cb4 100644 > --- a/drivers/staging/rtl8723bs/hal/hal_btcoex.c > +++ b/drivers/staging/rtl8723bs/hal/hal_btcoex.c > @@ -9,14 +9,14 @@ > #include <hal_btcoex.h> > #include <Mp_Precomp.h> > > -/* Global variables */ > +/*Global variables */ Does that look right? (hint, it isn't...) Always put a space after the /* and before text. You removed the one that was there already :( thanks, greg k-h