Re: [PATCH v2 1/3] staging: media: Remove duplicate NULL tests on a value in pci
Samuel Abraham <[email protected]> Fri, 4 Apr 2025 00:32:01 +0100
| Newsgroups | dev.linux.lists.outreachy,dev.linux.lists.linux-staging,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <CADYq+fa4FxmiynHg7BJRCusr3V-GqofEEddzP9Zzg1muPXGdqQ@mail.gmail.com> |
On Thu, Apr 3, 2025 at 2:31 PM Andy Shevchenko <[email protected]> wrote: > > On Thu, Apr 03, 2025 at 02:26:41PM +0100, Abraham Samuel Adekunle wrote: > > When a value has been tested for NULL in an expression, a > > second NULL test on the same value in another expression > > is unnecessary when the value has not been assigned NULL. > > > > Remove unnecessary duplicate NULL tests on the same value that > > has previously been NULL tested. > > > > Found by Coccinelle > > Missing period. And Subject should be as simple as > > "media: atomisp: Remove ..." > > ... > > Please, send this patch separately from the others. > > -- Thank you very much for your review Unfortunately I have been told I cannot work on the media driver as an outreachy applicant. I do appreciate your apparent reviews. I will Cc your email when I apply your review to my rtl8723bs driver patch of the patchset. Thanks Adekunle