Re: [PATCH v4 1/1] staging: rtl8723bs: Prevent duplicate NULL tests on a value

Andy Shevchenko <[email protected]> Fri, 4 Apr 2025 13:54:55 +0300

Newsgroups	dev.linux.lists.outreachy,dev.linux.lists.linux-staging,org.kernel.vger.linux-kernel
Message-ID	<CAHp75VfqbO43KgMOuvuF4oGVp9m6UqbYJOtxTZoiiHwnXd13-g@mail.gmail.com>

On Fri, Apr 4, 2025 at 11:51 AM Abraham Samuel Adekunle
<[email protected]> wrote:

...

> While at it, convert '& 0xfff' cases to use modulo operator and
> decimal number to make the upper limit visible and clear what the
> semantic of it is.

I think there is a consensus now that this should be a separate followup change.

...

> +                       psta->sta_xmitpriv.txseq_tid[pattrib->priority] &= 0xFFF;

This also has the same semantic and may be changed in that patch.

-- 
With Best Regards,
Andy Shevchenko