Re: [PATCH v1 1/1] iio: dummy: Add 3-axis compass (magnetometer) channels to the iio_simple_dummy

Marcelo Schmitt <[email protected]> Sun, 6 Apr 2025 14:42:32 -0300

Newsgroups	dev.linux.lists.outreachy,org.kernel.vger.linux-iio,org.kernel.vger.linux-kernel
Message-ID	<Z_K9CFItAcYS8r4a@debian-BULLSEYE-live-builder-AMD64>

Hi Brajesh,

On 04/06, Brajesh Patil wrote:
> This patch adds support for 3-axis magnetometer data (X, Y, Z) in the
> iio_simple_dummy driver. It introduces three new IIO_MAGN channels and
> populates them with dummy values for testing and prototyping purposes.
> 
> Signed-off-by: Brajesh Patil <[email protected]>
> ---
>  drivers/iio/dummy/iio_simple_dummy.c | 71 +++++++++++++++++++++++++++-
>  drivers/iio/dummy/iio_simple_dummy.h |  6 +++
>  2 files changed, 75 insertions(+), 2 deletions(-)
> 

I'm pretty sure the changes introduced in the IIO dummy tutorial [1] were 
for learning purposes only and not intended for upstreaming.
I don't see a reason for updating the upstream dummy driver with those.
It would also make the tutorial less interesting.

[1]: https://flusp.ime.usp.br/iio/experiment-one-iio-dummy/

So NACK for this patch.

Regards,
Marcelo