Re: Local-variable initialization semantic patch update

On Mon, 2025-04-07 at 08:32 -0400, Julia Lawall wrote:
> 
> 
> On Mon, 7 Apr 2025, Erick Karanja wrote:
> 
> > The original semantic patch had deficiencies in handling
> > local variable initialization, especially with function calls in
> > declarations.
> > This reduced readability, obscured side effects and made debugging
> > harder.
> 
> It is best to inline the semantic patches in the email, so that
> people can
> easily read and comment on it.
> 
> Also, please try to be more direct in your comments.  "had
> deficiencies"
> is not informative.  What was the problem?  What have you done about
> it?
> The log message should be a guide to help the person receiving the
> new
> code to know what to look for and to find out what is going on.
Hello Julia. Thank you for the review and I will make the required
changes.
Erick
> 
> julia
> 
> > 
> > Suggested-by: Greg KH <[email protected]>
> > Suggested-by: Julia Lawall <[email protected]>
> > Suggested-by: Dan Carpenter <[email protected]>
> > 
> >