Re: [PATCH v6 1/2] staging: rtl8723bs: Add white spaces around binary operators

On Tue, Apr 8, 2025 at 12:54 AM Abraham Samuel Adekunle
<[email protected]> wrote:
>
> The code contains no spaces around binary operators making it
> hard to read. This also doesn't adhere to Linux kernel coding
> style.
>
> Add white spaces around the binary operators to increase readability
> and endure adherence to Linux kernel coding styles.

...

> -                                               psta->BA_starting_seqctrl[pattrib->priority & 0x0f] = (tx_seq+1)&0xfff;
> +                                               psta->BA_starting_seqctrl[pattrib->priority & 0x0f] = (tx_seq + 1) & 0xfff;

> -                                               psta->BA_starting_seqctrl[pattrib->priority & 0x0f] = (pattrib->seqnum+1)&0xfff;
> +                                               psta->BA_starting_seqctrl[pattrib->priority & 0x0f] = (pattrib->seqnum + 1) & 0xfff;

You mentioned Linux coding style, which also requires lines not to be
so long. These lines are. That's why a few versions ago I suggested
you to change these to be two lines each. I don't know how many times
to repeat this (it's third one).

-- 
With Best Regards,
Andy Shevchenko