Re: [PATCH v6 1/2] staging: rtl8723bs: Add white spaces around binary operators

Andy Shevchenko <[email protected]> Tue, 8 Apr 2025 12:35:05 +0300

Newsgroups	dev.linux.lists.outreachy,dev.linux.lists.linux-staging,org.kernel.vger.linux-kernel
Organization	Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Message-ID	<[email protected]>

On Tue, Apr 08, 2025 at 10:22:44AM +0100, Samuel Abraham wrote:
> On Tue, Apr 8, 2025 at 8:20 AM Andy Shevchenko
> <[email protected]> wrote:
> > On Tue, Apr 8, 2025 at 12:54 AM Abraham Samuel Adekunle
> > <[email protected]> wrote:

...

> > > -                                               psta->BA_starting_seqctrl[pattrib->priority & 0x0f] = (tx_seq+1)&0xfff;
> > > +                                               psta->BA_starting_seqctrl[pattrib->priority & 0x0f] = (tx_seq + 1) & 0xfff;
> >
> > > -                                               psta->BA_starting_seqctrl[pattrib->priority & 0x0f] = (pattrib->seqnum+1)&0xfff;
> > > +                                               psta->BA_starting_seqctrl[pattrib->priority & 0x0f] = (pattrib->seqnum + 1) & 0xfff;
> >
> > You mentioned Linux coding style, which also requires lines not to be
> > so long. These lines are. That's why a few versions ago I suggested
> > you to change these to be two lines each. I don't know how many times
> > to repeat this (it's third one).
> 
> Okay, sorry
> I will add a third patch for a line break before the patch for %
> operations since each patch should handle a single thing.

I am not sure you need a third patch for that. It lies into category of space
and indentation fix.

-- 
With Best Regards,
Andy Shevchenko