Re: [PATCH v2 1/2] staging: rtl8723bs: Improve code readability

On Wed, 2025-04-09 at 14:11 +0300, Dan Carpenter wrote:
> On Wed, Apr 09, 2025 at 07:04:18AM -0400, Julia Lawall wrote:
> > > @@ -729,10 +721,9 @@ static void hal_ReadEFuse_WiFi(
> > > =C2=A0		}
> > >=20
> > > =C2=A0		if (offset < EFUSE_MAX_SECTION_8723B) {
> > > -			u16 addr;
> > > +			u16 addr =3D offset * PGPKT_DATA_SIZE;
> > > =C2=A0			/*=C2=A0 Get word enable value from PG header
> > > */
> > >=20
> > > -			addr =3D offset * PGPKT_DATA_SIZE;
> >=20
> > I'm not sure about this one, due to the comment.
> >=20
> > julia
> >=20
>=20
> I feel like it works.=C2=A0 I wish there were a blank line after the
> declaration but that's something for a different patch.=C2=A0 Both of
> these are okay with me.=C2=A0 Try to be more creative with the subjects
> next time.=C2=A0 (Just put the file name in the subject because that's
> the only difference).
Thank you for the review.
Erick
>=20
> Reviewed-by: Dan Carpenter <[email protected]>
>=20
> regards,
> dan carpenter
>=20