Re: [PATCH] staging: rtl8723bs: Replace `& 0xfff` with `% 4096u`
Dan Carpenter <[email protected]> Fri, 11 Apr 2025 13:37:05 +0300
| Newsgroups | dev.linux.lists.outreachy,dev.linux.lists.linux-staging,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On Thu, Apr 10, 2025 at 08:43:53PM +0300, Andy Shevchenko wrote: > > > $ make drivers/staging/rtl8723bs/core/rtw_xmit.o > > $ cmp rtw_xmit_before.o rtw_xmit_after.o > > cmp is good but not good enough in general. Here it shows the 1:1 > binary, but in some cases code can be the same, while binaries are > different. To make sure the code is the same use the bloat-o-meter > tool instead. > I don't understand what you're saying at all. cmp shows that the compiler was automaticall tanslating the "& 0xfff" into "% 04096u" so the resulting object files are exactly the same. ./scripts/bloat-o-meter just looks at the sizes so it's less useful in this case. regards, dan carpenter